Merge inhibit applet with GPM?

Hello,

I am thinking of trying to integrate the inhibit applet with GPM, the
reason being is for simplicity. For example, me as a laptop user needs
that feature at times, however, I also only have a limited amount of
space on the panel, and I also only require that feature occasionally
where at other times I am more than happy to let the power management go
on as it's supposed to. So basically what I would like to know is, would
my patch be accepted if I was to make it?

About how it would look like, it would be on the main drop down menu of
the GPM tray icon below the Hibernate and Suspend options and separated
by a separator, the icon would change appearance in the way that the
inhibit applet does. I am also thinking of having an option in the GPM
preferences that allows the user to specify if he wants to control the
inhibition of power savings or not, so depending on that option, the
inhibition menu item would or would not be shown.

I already have the GUI part working(except for the option to show the
menu item or not), however I am still trying to figure out how to do it
for real, now dependencies would be the proxy in the GpmSession object
and the inhibited_old boolean variable.

So, what do you think? :)

Cheers,
Pramod



_______________________________________________
gnome-power-manager-list mailing list
gnome-power-manager-list@...
http://mail.gnome.org/mailman/listinfo/gnome-power-manager-list

[Richard Hughes-6]

2009/8/21 Pramod Dematagoda <pmd.lotr.gandalf@...>:
> I am thinking of trying to integrate the inhibit applet with GPM, the
> reason being is for simplicity.

What's the logic with integrating it? I would say not many users use
the inhibit functionality, as it's designed to be value-add, not core
functionality.

Richard.
_______________________________________________
gnome-power-manager-list mailing list
gnome-power-manager-list@...
http://mail.gnome.org/mailman/listinfo/gnome-power-manager-list

My apologies, I forgot to send a CC of my reply to the mailing list.

Pramod

On Fri, 2009-08-21 at 13:40 +0100, Richard Hughes wrote:
> 2009/8/21 Pramod Dematagoda <pmd.lotr.gandalf@...>:
> > I am thinking of trying to integrate the inhibit applet with GPM, the
> > reason being is for simplicity.
>
> What's the logic with integrating it? I would say not many users use
> the inhibit functionality, as it's designed to be value-add, not core
> functionality.
>
> Richard.

Well, first of all, it would not be on the menu at all times since the
user would have the option of having it or not, so those users who do
not need it do not have to be bothered with it at all. For users who do
need this, they can quickly enable inhibition when they need to without
having to have the inhibition applet sitting in the panel all the time.

The users who would benefit from something like this, would be users
watching videos from websites like You Tube, etc. where inhibition is
not automatically enabled, also it would be useful for users of
applications via WINE where some power saving modes like suspending
would probably cause problems.

>From personal experience, I always hated having the inhibition applet
just sitting in the panel because it was not useful(until I actually
needed it) and it took space on a panel that was already crammed with
other applets, but when I did need it, I had to go through the whole
task of adding it to the panel and then activating the inhibition. By
integrating the applet with GPM, the applet does not get in the user's
way until he/she actually needs it and then it is just a simple matter
of clicking on the tray icon and pressing the inhibition entry.

Cheers,
Pramod


_______________________________________________
gnome-power-manager-list mailing list
gnome-power-manager-list@...
http://mail.gnome.org/mailman/listinfo/gnome-power-manager-list