Minor green screen annoyance in CVS HEAD

[Ville Skyttä]

Hello,

I just noticed a minor annoyance in CVS HEAD which I believe is a result of
the recent ADV717x changes:

When booting my VDR box, when the em8300 and adv717x modules are loaded but
before anything uses them (not even em8300setup) and the microcode has not
been loaded, my TV displays an all bright green screen.  When VDR starts up
and the DXR3 plugin takes over, configuring the card and the microcode is
loaded, everything's fine.

With vanilla 0.16.3 this doesn't happen - with it my TV very quickly flashes
green when the modules are loaded, then goes back to black.

Looks like I can only reproduce this when booting the box; after the card has
been configured once, subsequent module removals/reinstallations no longer
cause the green screen effect.

/etc/modprobe.conf:

remove em8300 /sbin/modprobe -r --ignore-remove em8300 && /sbin/modprobe -r
adv717x
install em8300 /sbin/modprobe adv717x && /sbin/modprobe --ignore-install
em8300
options em8300 dicom_other_pal=0 dicom_control=0 audio_driver=oss
options adv717x pixelport_other_pal=0 output_mode=yuv

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Nicolas Boullis]

Hi,

On Sun, Dec 16, 2007 at 11:01:27PM +0200, Ville Skyttä wrote:

> Hello,
>
> I just noticed a minor annoyance in CVS HEAD which I believe is a result of
> the recent ADV717x changes:
>
> When booting my VDR box, when the em8300 and adv717x modules are loaded but
> before anything uses them (not even em8300setup) and the microcode has not
> been loaded, my TV displays an all bright green screen.  When VDR starts up
> and the DXR3 plugin takes over, configuring the card and the microcode is
> loaded, everything's fine.
>
> With vanilla 0.16.3 this doesn't happen - with it my TV very quickly flashes
> green when the modules are loaded, then goes back to black.
>
> Looks like I can only reproduce this when booting the box; after the card has
> been configured once, subsequent module removals/reinstallations no longer
> cause the green screen effect.

Hmmm... All that sounds strange...
Have you tried with 0.16.3 + my first "adv717x code reorganization"
patch? And with 0.16.3 + both my "adv717x code reorganization" patches?


That would help me figure out where the problem lies...


Nicolas

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Ville Skyttä]

On Monday 17 December 2007, Nicolas Boullis wrote:

> On Sun, Dec 16, 2007 at 11:01:27PM +0200, Ville Skyttä wrote:
> > Hello,
> >
> > I just noticed a minor annoyance in CVS HEAD which I believe is a result
> > of the recent ADV717x changes:
> >
> > When booting my VDR box, when the em8300 and adv717x modules are loaded
> > but before anything uses them (not even em8300setup) and the microcode
> > has not been loaded, my TV displays an all bright green screen.  When VDR
> > starts up and the DXR3 plugin takes over, configuring the card and the
> > microcode is loaded, everything's fine.
> >
> > With vanilla 0.16.3 this doesn't happen - with it my TV very quickly
> > flashes green when the modules are loaded, then goes back to black.
> >
> > Looks like I can only reproduce this when booting the box; after the card
> > has been configured once, subsequent module removals/reinstallations no
> > longer cause the green screen effect.
>
> Hmmm... All that sounds strange...
> Have you tried with 0.16.3 + my first "adv717x code reorganization"
> patch?

Just tested it, no green screen there.

> And with 0.16.3 + both my "adv717x code reorganization" patches?

This I can't test right now because the "part 2 take 3" patch causes rejects
when applied directly on top of vanilla 0.16.3 + part 1 (I suppose it would
require another post 0.16.3 changeset from CVS in between), and I have no
time to try to resolve them at the moment.  But I guess it's fairly safe to
assume that something in the "part 2 take 3" patch is the culprit.

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Nicolas Boullis]

On Mon, Dec 17, 2007 at 09:42:01PM +0200, Ville Skyttä wrote:

> On Monday 17 December 2007, Nicolas Boullis wrote:
> >
> > Have you tried with 0.16.3 + my first "adv717x code reorganization"
> > patch?
>
> Just tested it, no green screen there.
>
> > And with 0.16.3 + both my "adv717x code reorganization" patches?
>
> This I can't test right now because the "part 2 take 3" patch causes rejects
> when applied directly on top of vanilla 0.16.3 + part 1 (I suppose it would
> require another post 0.16.3 changeset from CVS in between), and I have no
> time to try to resolve them at the moment.  But I guess it's fairly safe to
> assume that something in the "part 2 take 3" patch is the culprit.

OK, I think I got it, and you're right that the problem lies in the
second part of the rewriting...

How about with the attached patch?


Cheers,

Nicolas

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Nicolas Boullis]

On Mon, Dec 17, 2007 at 11:34:38PM +0100, Nicolas Boullis wrote:
>
> How about with the attached patch?

I meant this one...


Nicolas


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Ville Skyttä]

On Tuesday 18 December 2007, Nicolas Boullis wrote:
> On Mon, Dec 17, 2007 at 11:34:38PM +0100, Nicolas Boullis wrote:
> > How about with the attached patch?
>
> I meant this one...

Yes, that fixes it (after adding a missing ")" before the trailing
semicolon :)).  Thanks!

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Nicolas Boullis]

Hi,

On Mon, Dec 17, 2007 at 11:34:38PM +0100, Nicolas Boullis wrote:
>
> OK, I think I got it, and you're right that the problem lies in the
> second part of the rewriting...
>
> How about with the attached patch?

OK, applied since nobody objected and Ville reported that it solved his
problem.


Cheers,

Nicolas

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel