Minor notes on the source

[Oliver Stöneberg]

Hey,

here are just a few things I recognised after looking at various
parts of the source:

CTRLSvr.cpp
In the function CTRLHandleSession() the local variable "iTimeout" is
unused. It's a copy of "pCTRLCfg->iTimeout" that is not necessary as
the rest of the function is accessing it directly.

MailSvr.cpp
It would make sense to add a "server started" message in SvrMain() to
match the "server stopped" message.

POP3Utils.cpp
The static functions UPopMessagesSize() and
UPopExtractServerTimeStamp() are not used at all.

UserAuth.cpp
The declaration of the function UAthExecAuthOp() doesn't match the
implementation. The "char const *pszPassword" is missing.

Greetings
Oliver
_______________________________________________
xmail mailing list
xmail@...
http://xmailserver.org/mailman/listinfo/xmail

[Davide Libenzi]

On Thu, 8 Oct 2009, Oliver Stöneberg wrote:

> Hey,
>
> here are just a few things I recognised after looking at various
> parts of the source:
>
> CTRLSvr.cpp
> In the function CTRLHandleSession() the local variable "iTimeout" is
> unused. It's a copy of "pCTRLCfg->iTimeout" that is not necessary as
> the rest of the function is accessing it directly.

Cleaned up.


> MailSvr.cpp
> It would make sense to add a "server started" message in SvrMain() to
> match the "server stopped" message.

Looks good.



> POP3Utils.cpp
> The static functions UPopMessagesSize() and
> UPopExtractServerTimeStamp() are not used at all.

Utility functions for future use. They stay.



> UserAuth.cpp
> The declaration of the function UAthExecAuthOp() doesn't match the
> implementation. The "char const *pszPassword" is missing.

Yep, fixed.


- Davide


_______________________________________________
xmail mailing list
xmail@...
http://xmailserver.org/mailman/listinfo/xmail