Missing curly braces in rsa_params::operator= (gnutlsxx.cpp)?

[Jason Pettiss-3]

I have version 2.8.4 of the source... tried to check the latest in the CVS repository but the CVS server itself seems to be out of disk space?

Anyway it looks like the error check in rsa_params::operator= is missing a code block and will unconditionally throw.

rsa_params & rsa_params::operator=(const rsa_params& src)
{
    rsa_params* dst = new rsa_params;
    int ret;
    ret = gnutls_rsa_params_cpy( dst->params, src.params);
    if (ret < 0)
        delete dst;
    throw(ret);
    return *dst;
}

Probably should have been:

    if (ret < 0) {
        delete dst;
        throw(ret);
    }

--jason


     


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Simon Josefsson-2]

Jason Pettiss <jpettiss@...> writes:

> I have version 2.8.4 of the source... tried to check the latest in the CVS repository but the CVS server itself seems to be out of disk space?

We haven't used CVS in quite a while, please check instructions on how
to retrieve sources from Git:

https://savannah.gnu.org/git/?group=gnutls

Btw, did you read that we used CVS somewhere?  I may have forgotten to
update some old information.

> Anyway it looks like the error check in rsa_params::operator= is missing a code block and will unconditionally throw.
>
> rsa_params & rsa_params::operator=(const rsa_params& src)
> {
>     rsa_params* dst = new rsa_params;
>     int ret;
>     ret = gnutls_rsa_params_cpy( dst->params, src.params);
>     if (ret < 0)
>         delete dst;
>     throw(ret);
>     return *dst;
> }
>
> Probably should have been:
>
>     if (ret < 0) {
>         delete dst;
>         throw(ret);

Heh.  Fixed, thank you.

/Simon


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Jason Pettiss-3]

> We haven't used CVS in quite a while, please check
> instructions on how
> to retrieve sources from Git:
>
> https://savannah.gnu.org/git/?group=gnutls

Oh thank goodness.  CVS gives me hives.  :)

> Btw, did you read that we used CVS somewhere?  I may
> have forgotten to
> update some old information.

http://josefsson.org/gnutls4win/

"First checkout the files in this directory as follows:

cvs -z3 -d:pserver:anonymous@...:/sources/gnutls co gnutls4win
"

There is a CVS server there, and the ViewCVS link does work... I followed that around to find the libraries I thought I needed.

--jason

--- On Fri, 10/23/09, Simon Josefsson <simon@...> wrote:

> From: Simon Josefsson <simon@...>
> Subject: Re: Missing curly braces in rsa_params::operator= (gnutlsxx.cpp)?
> To: "Jason Pettiss" <jpettiss@...>
> Cc: bug-gnutls@...
> Date: Friday, October 23, 2009, 11:22 AM
> Jason Pettiss <jpettiss@...>
> writes:
>
> > I have version 2.8.4 of the source... tried to check
> the latest in the CVS repository but the CVS server itself
> seems to be out of disk space?
>
> We haven't used CVS in quite a while, please check
> instructions on how
> to retrieve sources from Git:
>
> https://savannah.gnu.org/git/?group=gnutls
>
> Btw, did you read that we used CVS somewhere?  I may
> have forgotten to
> update some old information.
>
> > Anyway it looks like the error check in
> rsa_params::operator= is missing a code block and will
> unconditionally throw.
> >
> > rsa_params & rsa_params::operator=(const
> rsa_params& src)
> > {
> >     rsa_params* dst = new
> rsa_params;
> >     int ret;
> >     ret = gnutls_rsa_params_cpy(
> dst->params, src.params);
> >     if (ret < 0)
> >         delete dst;
> >     throw(ret);
> >     return *dst;
> > }
> >
> > Probably should have been:
> >
> >     if (ret < 0) {
> >         delete dst;
> >         throw(ret);
>
> Heh.  Fixed, thank you.
>
> /Simon
>

_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Simon Josefsson-2]

Jason Pettiss <jpettiss@...> writes:

>> Btw, did you read that we used CVS somewhere?  I may
>> have forgotten to
>> update some old information.
>
> http://josefsson.org/gnutls4win/
>
> "First checkout the files in this directory as follows:
>
> cvs -z3 -d:pserver:anonymous@...:/sources/gnutls co gnutls4win
> "
>
> There is a CVS server there, and the ViewCVS link does work... I
> followed that around to find the libraries I thought I needed.

Yeah, that isn't the GnuTLS source code, it is the source code (and
binaries...) for building GnuTLS under Windows.  That is in CVS because
it is just a Makefile and some other files, and I haven't had time to
migrate it.

/Simon


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Jason Pettiss-3]

> Yeah, that isn't the GnuTLS source code, it is the source
> code (and binaries...) for building GnuTLS under Windows.
> That is in CVS because it is just a Makefile and some other
> files, and I haven't had time to migrate it.

Sorry if this is getting off topic but are there source changes necessary to make that happen (and if so, how intense are they?), or is it really just build tweaks?  

Also if I need to do some work to get it rebuilt & running should I comment directly to you, or is there a specific "gnutls4win" mailing list?

Thanks,

--jason



     


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Simon Josefsson-2]

Jason Pettiss <jpettiss@...> writes:

>> Yeah, that isn't the GnuTLS source code, it is the source
>> code (and binaries...) for building GnuTLS under Windows.
>> That is in CVS because it is just a Makefile and some other
>> files, and I haven't had time to migrate it.
>
> Sorry if this is getting off topic but are there source changes
> necessary to make that happen (and if so, how intense are they?), or
> is it really just build tweaks?

No, CVS is just used as a transport mechanism here.  One (of few)
advantage with CVS over Git is that you can have multiple repositories
in a CVS root -- to get the same with Git, I would need to create a new
savannah project for the gnutls4win files and that is really too much
overhead for a few files.

Also, the binaries stored in CVS for gnutls4win should really not be in
CVS, the savannah admins doesn't like that.  I'm not sure where to host
them, though...  I guess they could be uploaded to alpha.gnu.org though.

> Also if I need to do some work to get it rebuilt & running should I
> comment directly to you, or is there a specific "gnutls4win" mailing
> list?

It is fine to keep it on this list.

/Simon


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel