Moodbar extension

[X4lldux]

Hi,

any one interested in helping me finding bugs in my Moodbar extension? You can find source here http://github.com/X4lldux/banshee-moodbar-extension .
Moodbar support was the biggest thing I've missed from amarok. It can show when something interesting happens in song. It works by analyzing frequencies and then displaying the results in a form of colorful stripes.

Screenshot: http://twitpic.com/n4bqu/full

Regards,
X4lldux

[Bertrand Lorentz]

On Thu, 2009-10-29 at 16:39 -0700, X4lldux wrote:
> Hi,
>
> any one interested in helping me finding bugs in my Moodbar extension? You
> can find source here http://github.com/X4lldux/banshee-moodbar-extension .
> Moodbar support was the biggest thing I've missed from amarok. It can show
> when something interesting happens in song. It works by analyzing
> frequencies and then displaying the results in a form of colorful stripes.
>
> Screenshot: http://twitpic.com/n4bqu/full

Hi,

I had a quick look at your extension, and here are some comments :

1/ I had to mess around with Banshee.Moodbar/Banshee.Moodbar.csproj,
because my MonoDevelop (version 2.0) wouldn't load it. Which version of
MonoDevelop are you using ?

2/ Compilation gave me the two following errors :
<path>/Banshee.Moodbar/Banshee.Moodbar/Moodbar.cs(69,30): error CS1501:
No overload for method `Dispose' takes `0' arguments
<path>/Banshee.Moodbar/Banshee.Moodbar/Moodbar.cs(111,26): error CS1501:
No overload for method `Dispose' takes `0' arguments

Those Dispose methods are called on a Cairo.ImageSurface.
I have mono 2.4. Maybe a change in the API ?
After commenting out those lines, compilation succeded.

At this point, I realized I had to install the moodbar tool for it to
work, but I didn't have time to go any further.

I noticed the extension does the analysis by starting the moodbar in a
new process. I've also read that there's a moodbar plugin for GStreamer.
Do you think it would be possible to generate the "mood" data using only
GStreamer ?
Something similar to what is done in the Banshee.Bpm extension would be
nice.


If you need some space to host tarballs, or an issue tracker, I'd be
happy to give you access to
http://code.google.com/p/banshee-unofficial-plugins/

Keep up the good work !

--
Bertrand Lorentz <bertrand.lorentz@...>


_______________________________________________
banshee-list mailing list
banshee-list@...
http://mail.gnome.org/mailman/listinfo/banshee-list

[X4lldux]

On Mon, Nov 2, 2009 at 23:35, Bertrand Lorentz
<bertrand.lorentz@...> wrote:

> I had a quick look at your extension, and here are some comments :
>
> 1/ I had to mess around with Banshee.Moodbar/Banshee.Moodbar.csproj,
> because my MonoDevelop (version 2.0) wouldn't load it. Which version of
> MonoDevelop are you using ?
>
> 2/ Compilation gave me the two following errors :
> <path>/Banshee.Moodbar/Banshee.Moodbar/Moodbar.cs(69,30): error CS1501:
> No overload for method `Dispose' takes `0' arguments
> <path>/Banshee.Moodbar/Banshee.Moodbar/Moodbar.cs(111,26): error CS1501:
> No overload for method `Dispose' takes `0' arguments
>
> Those Dispose methods are called on a Cairo.ImageSurface.
> I have mono 2.4. Maybe a change in the API ?
> After commenting out those lines, compilation succeded.
>
> At this point, I realized I had to install the moodbar tool for it to
> work, but I didn't have time to go any further.
>
> I noticed the extension does the analysis by starting the moodbar in a
> new process. I've also read that there's a moodbar plugin for GStreamer.
> Do you think it would be possible to generate the "mood" data using only
> GStreamer ?
> Something similar to what is done in the Banshee.Bpm extension would be
> nice.
>
>
> If you need some space to host tarballs, or an issue tracker, I'd be
> happy to give you access to
> http://code.google.com/p/banshee-unofficial-plugins/
>
> Keep up the good work !
>
> --
> Bertrand Lorentz <bertrand.lorentz@...>
>
> _______________________________________________
> banshee-list mailing list
> banshee-list@...
> http://mail.gnome.org/mailman/listinfo/banshee-list
>

Thanks for the insight.
1) I'm using monodevelop from svn, so that'd be the source of your
problem... although I don't really know why that happen, .csproj
should be somehow "portable".

2) I'm gonna look up into that API difference, and try to figure it
out whether I should dispose ImageSurface or not.

3) I thought too about using only GStreamer, but gst-moodbar plugin
and moodbar binary are inside the same package in every distro I've
checked. So, for now, I don't see the need for duplicating the code.

Thanks for the hosting proposition but I'm gonna stick to github.

--
With regards,
Paweł 'X4lldux' Drygas
http://x4lldux.blip.pl/
_______________________________________________
banshee-list mailing list
banshee-list@...
http://mail.gnome.org/mailman/listinfo/banshee-list

[Bertrand Lorentz]

On Tue, 2009-11-03 at 14:10 +0100, X4lldux wrote:

> On Mon, Nov 2, 2009 at 23:35, Bertrand Lorentz
> <bertrand.lorentz@...> wrote:
> > I had a quick look at your extension, and here are some comments :
> >
> > 1/ I had to mess around with Banshee.Moodbar/Banshee.Moodbar.csproj,
> > because my MonoDevelop (version 2.0) wouldn't load it. Which version of
> > MonoDevelop are you using ?
> >
> > 2/ Compilation gave me the two following errors :
> > <path>/Banshee.Moodbar/Banshee.Moodbar/Moodbar.cs(69,30): error CS1501:
> > No overload for method `Dispose' takes `0' arguments
> > <path>/Banshee.Moodbar/Banshee.Moodbar/Moodbar.cs(111,26): error CS1501:
> > No overload for method `Dispose' takes `0' arguments
> >
> > Those Dispose methods are called on a Cairo.ImageSurface.
> > I have mono 2.4. Maybe a change in the API ?
> > After commenting out those lines, compilation succeded.
> >
> > At this point, I realized I had to install the moodbar tool for it to
> > work, but I didn't have time to go any further.
> >
> > I noticed the extension does the analysis by starting the moodbar in a
> > new process. I've also read that there's a moodbar plugin for GStreamer.
> > Do you think it would be possible to generate the "mood" data using only
> > GStreamer ?
> > Something similar to what is done in the Banshee.Bpm extension would be
> > nice.
> >
> >
> > If you need some space to host tarballs, or an issue tracker, I'd be
> > happy to give you access to
> > http://code.google.com/p/banshee-unofficial-plugins/
> >
> > Keep up the good work !
> >
> > --
> > Bertrand Lorentz <bertrand.lorentz@...>
> >
> > _______________________________________________
> > banshee-list mailing list
> > banshee-list@...
> > http://mail.gnome.org/mailman/listinfo/banshee-list
> >
>
> Thanks for the insight.
> 1) I'm using monodevelop from svn, so that'd be the source of your
> problem... although I don't really know why that happen, .csproj
> should be somehow "portable".

The part of the csproj I had problem with was inside <ProjectExtensions>
and <MonoDevelop> tags, so I guess it's a MonoDevelop-specific thing
introduced since 2.0.
If I ever get around to it, I'll try to add an autotools build system.
The one generated by MonoDevelop is usually pretty good.


> 2) I'm gonna look up into that API difference, and try to figure it
> out whether I should dispose ImageSurface or not.
>
> 3) I thought too about using only GStreamer, but gst-moodbar plugin
> and moodbar binary are inside the same package in every distro I've
> checked. So, for now, I don't see the need for duplicating the code.

Using the GStreamer plugin would avoid the overhead of starting a
process, but probably at the cost of having to write some C code... ;)

--
Bertrand Lorentz <bertrand.lorentz@...>


_______________________________________________
banshee-list mailing list
banshee-list@...
http://mail.gnome.org/mailman/listinfo/banshee-list

[X4lldux]

On Tue, Nov 3, 2009 at 19:37, Bertrand Lorentz
<bertrand.lorentz@...> wrote:

> On Tue, 2009-11-03 at 14:10 +0100, X4lldux wrote:
>> On Mon, Nov 2, 2009 at 23:35, Bertrand Lorentz
>> <bertrand.lorentz@...> wrote:
>> > I had a quick look at your extension, and here are some comments :
>> >
>> > 1/ I had to mess around with Banshee.Moodbar/Banshee.Moodbar.csproj,
>> > because my MonoDevelop (version 2.0) wouldn't load it. Which version of
>> > MonoDevelop are you using ?
>> >
>> > 2/ Compilation gave me the two following errors :
>> > <path>/Banshee.Moodbar/Banshee.Moodbar/Moodbar.cs(69,30): error CS1501:
>> > No overload for method `Dispose' takes `0' arguments
>> > <path>/Banshee.Moodbar/Banshee.Moodbar/Moodbar.cs(111,26): error CS1501:
>> > No overload for method `Dispose' takes `0' arguments
>> >
>> > Those Dispose methods are called on a Cairo.ImageSurface.
>> > I have mono 2.4. Maybe a change in the API ?
>> > After commenting out those lines, compilation succeded.
>> >
>> > At this point, I realized I had to install the moodbar tool for it to
>> > work, but I didn't have time to go any further.
>> >
>> > I noticed the extension does the analysis by starting the moodbar in a
>> > new process. I've also read that there's a moodbar plugin for GStreamer.
>> > Do you think it would be possible to generate the "mood" data using only
>> > GStreamer ?
>> > Something similar to what is done in the Banshee.Bpm extension would be
>> > nice.
>> >
>> >
>> > If you need some space to host tarballs, or an issue tracker, I'd be
>> > happy to give you access to
>> > http://code.google.com/p/banshee-unofficial-plugins/
>> >
>> > Keep up the good work !
>> >
>> > --
>> > Bertrand Lorentz <bertrand.lorentz@...>
>> >
>> > _______________________________________________
>> > banshee-list mailing list
>> > banshee-list@...
>> > http://mail.gnome.org/mailman/listinfo/banshee-list
>> >
>>
>> Thanks for the insight.
>> 1) I'm using monodevelop from svn, so that'd be the source of your
>> problem... although I don't really know why that happen, .csproj
>> should be somehow "portable".
>
> The part of the csproj I had problem with was inside <ProjectExtensions>
> and <MonoDevelop> tags, so I guess it's a MonoDevelop-specific thing
> introduced since 2.0.
> If I ever get around to it, I'll try to add an autotools build system.
> The one generated by MonoDevelop is usually pretty good.
>
>
>> 2) I'm gonna look up into that API difference, and try to figure it
>> out whether I should dispose ImageSurface or not.
>>
>> 3) I thought too about using only GStreamer, but gst-moodbar plugin
>> and moodbar binary are inside the same package in every distro I've
>> checked. So, for now, I don't see the need for duplicating the code.
>
> Using the GStreamer plugin would avoid the overhead of starting a
> process, but probably at the cost of having to write some C code... ;)
>
> --
> Bertrand Lorentz <bertrand.lorentz@...>
>
> _______________________________________________
> banshee-list mailing list
> banshee-list@...
> http://mail.gnome.org/mailman/listinfo/banshee-list
>
>

> If I ever get around to it, I'll try to add an autotools build system.
> The one generated by MonoDevelop is usually pretty good.

That would be great, I don't know a ting about creating autosys build system.


> Using the GStreamer plugin would avoid the overhead of starting a
> process, but probably at the cost of having to write some C code... ;)

Plain C? Don't see the need for C, banshee uses gstreamer binding, so
can be in this case.

--
Paweł 'X4lldux' Drygas
http://flaker.pl/X4lldux
_______________________________________________
banshee-list mailing list
banshee-list@...
http://mail.gnome.org/mailman/listinfo/banshee-list

[Chris Howie]

On Wed, Nov 4, 2009 at 4:27 AM, X4lldux <x4lldux@...> wrote:
> Plain C? Don't see the need for C, banshee uses gstreamer binding, so
> can be in this case.

Wrong.  Part of Banshee is libbanshee, a C library that acts as glue
between Banshee and some C libraries, like GStreamer.

--
Chris Howie
http://www.chrishowie.com
http://en.wikipedia.org/wiki/User:Crazycomputers
_______________________________________________
banshee-list mailing list
banshee-list@...
http://mail.gnome.org/mailman/listinfo/banshee-list

[X4lldux]

On Wed, Nov 4, 2009 at 18:09, Chris Howie <cdhowie@...> wrote:

> On Wed, Nov 4, 2009 at 4:27 AM, X4lldux <x4lldux@...> wrote:
>
> Wrong.  Part of Banshee is libbanshee, a C library that acts as glue
> between Banshee and some C libraries, like GStreamer.
>
> --
> Chris Howie
> http://www.chrishowie.com
> http://en.wikipedia.org/wiki/User:Crazycomputers
> _______________________________________________
> banshee-list mailing list
> banshee-list@...
> http://mail.gnome.org/mailman/listinfo/banshee-list
>

Huh... strange.

--
Paweł 'X4lldux' Drygas
http://flaker.pl/X4lldux
_______________________________________________
banshee-list mailing list
banshee-list@...
http://mail.gnome.org/mailman/listinfo/banshee-list