More "float" problems in default branch for Mac

[Thomas Treichl]

Hi,

I've got more problems compiling the default branch on my Mac. I spent the whole
evening finding out where the problem really is, but couldn't find the place
where the function (as the linker wants it to see this way) should be needed.

I found another init definition in the files liboctave/floatAEPBAL.h and
liboctave/fCmplxAEPBAL.h, but not the one - check number of arguments - that
would be required.

I always do a maintainer-clean, autogen.sh and then configure, I also checked
this time if there are some old *o, *dylib, *def were left, but it was clean. So
the detailed error message when trying to link src/DLD-FUNCTIONS/balance.cc is

   /usr/bin/ld: Undefined symbols:
   FloatAEPBALANCE::init(FloatMatrix const&, std::basic_string<char,
   std::char_traits<char>, std::allocator<char> > const&)
   FloatComplexAEPBALANCE::init(FloatComplexMatrix const&,
   std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
   collect2: ld returned 1 exit status
   make[2]: *** [balance.oct] Error 1
   make[1]: *** [src] Error 2
   make: *** [all] Error 2

Thanks again for help,

   Thomas
_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[dbateman]

Thomas Treichl wrote:

Hi,

I've got more problems compiling the default branch on my Mac. I spent the whole
evening finding out where the problem really is, but couldn't find the place
where the function (as the linker wants it to see this way) should be needed.

I found another init definition in the files liboctave/floatAEPBAL.h and
liboctave/fCmplxAEPBAL.h, but not the one - check number of arguments - that
would be required.

I always do a maintainer-clean, autogen.sh and then configure, I also checked
this time if there are some old *o, *dylib, *def were left, but it was clean. So
the detailed error message when trying to link src/DLD-FUNCTIONS/balance.cc is

   /usr/bin/ld: Undefined symbols:
   FloatAEPBALANCE::init(FloatMatrix const&, std::basic_string<char,
   std::char_traits<char>, std::allocator<char> > const&)
   FloatComplexAEPBALANCE::init(FloatComplexMatrix const&,
   std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
   collect2: ld returned 1 exit status
   make[2]: *** [balance.oct] Error 1
   make[1]: *** [src] Error 2
   make: *** [all] Error 2

It appears that floatAEPBAL.cc and fCmplxAEPBAL.cc aren't in liboctave/Makefile.in(MATRIX_SRC) and floatAEPBAL.h and fCmplxAEPBAL.h aren't in liboctave/Makefile.in(MATRIX_INC) in the head. They are in my repository on my laptop, so I don't know what happened here. In any case this isn't MAC specific. Sorry no changeset as I have no access to my source tree.

D.

[David Bateman]

Thomas Treichl wrote:

> Hi,
>
> I've got more problems compiling the default branch on my Mac. I spent the whole
> evening finding out where the problem really is, but couldn't find the place
> where the function (as the linker wants it to see this way) should be needed.
>
> I found another init definition in the files liboctave/floatAEPBAL.h and
> liboctave/fCmplxAEPBAL.h, but not the one - check number of arguments - that
> would be required.
>
> I always do a maintainer-clean, autogen.sh and then configure, I also checked
> this time if there are some old *o, *dylib, *def were left, but it was clean. So
> the detailed error message when trying to link src/DLD-FUNCTIONS/balance.cc is
>
>    /usr/bin/ld: Undefined symbols:
>    FloatAEPBALANCE::init(FloatMatrix const&, std::basic_string<char,
>    std::char_traits<char>, std::allocator<char> > const&)
>    FloatComplexAEPBALANCE::init(FloatComplexMatrix const&,
>    std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
>    collect2: ld returned 1 exit status
>    make[2]: *** [balance.oct] Error 1
>    make[1]: *** [src] Error 2
>    make: *** [all] Error 2
>
>  

Ok, I now have a changeset to fix this issue, but there was a secondary
issue that prevented compilation.. You'll need the two changesets attached..

Sorry
David

--
David Bateman                                David.Bateman@...
Motorola Labs - Paris                        [phone] (Ph)
Parc Les Algorithmes, Commune de St Aubin    [phone] (Mob)
91193 Gif-Sur-Yvette FRANCE                  [phone] (Fax)

The information contained in this communication has been classified as:

[x] General Business Information
[ ] Motorola Internal Use Only
[ ] Motorola Confidential Proprietary



# HG changeset patch
# User David Bateman <dbateman@...>
# Date 1211528108 -7200
# Node ID 42c42bc50e4e30adec5d1bd8120047b49e421067
# Parent  0a6a2023e4b9c94b537be5a17d1a136b186d5bcd
Makefile fix for single precision

diff --git a/liboctave/ChangeLog b/liboctave/ChangeLog
--- a/liboctave/ChangeLog
+++ b/liboctave/ChangeLog
@@ -1,3 +1,8 @@ 2008-05-21  David Bateman  <dbateman@fre
[phone]  David Bateman  <dbateman@...>
+
+ * Makefile.in (MATRIX_INC): Add fCmplxAEPBAL.h and floatAEPBAL.h.
+ (MATRIX_SRC): Add fCmplxAEPBAL.cc and floatAEPBAL.cc.
+
 2008-05-21  David Bateman  <dbateman@...>
 
  * Quad-opts.in: Handle single precision tolerances.
diff --git a/liboctave/Makefile.in b/liboctave/Makefile.in
--- a/liboctave/Makefile.in
+++ b/liboctave/Makefile.in
@@ -61,8 +61,9 @@ MATRIX_INC := Array.h Array2.h Array3.h
  intNDArray.h \
  fCColVector.h fCRowVector.h fCDiagMatrix.h fCMatrix.h fCNDArray.h \
  fColVector.h fRowVector.h fDiagMatrix.h fMatrix.h fNDArray.h \
- fCmplxGEPBAL.h fCmplxHESS.h fCmplxCHOL.h fCmplxDET.h fCmplxLU.h \
- fCmplxSCHUR.h fCmplxSVD.h fCmplxQR.h fCmplxQRP.h \
+ fCmplxAEPBAL.h fCmplxGEPBAL.h fCmplxHESS.h fCmplxCHOL.h \
+ fCmplxDET.h fCmplxLU.h fCmplxSCHUR.h fCmplxSVD.h fCmplxQR.h \
+ fCmplxQRP.h floatAEPBAL.h \
  floatCHOL.h floatDET.h floatGEPBAL.h floatHESS.h floatLU.h \
  floatSCHUR.h floatSVD.h floatQR.h floatQRP.h
 
@@ -129,9 +130,10 @@ MATRIX_SRC := Array-util.cc CColVector.c
  int32NDArray.cc uint32NDArray.cc int64NDArray.cc uint64NDArray.cc \
  fCColVector.cc fCRowVector.cc fCDiagMatrix.cc fCMatrix.cc fCNDArray.cc \
  fColVector.cc fRowVector.cc fDiagMatrix.cc fMatrix.cc fNDArray.cc \
- fCmplxCHOL.cc fCmplxDET.cc fCmplxGEPBAL.cc fCmplxHESS.cc fCmplxLU.cc \
- fCmplxSCHUR.cc fCmplxSVD.cc fCmplxQR.cc fCmplxQRP.cc \
- floatCHOL.cc floatDET.cc floatGEPBAL.cc floatHESS.cc floatLU.cc \
+ fCmplxAEPBAL.cc fCmplxCHOL.cc fCmplxDET.cc fCmplxGEPBAL.cc \
+ fCmplxHESS.cc fCmplxLU.cc fCmplxSCHUR.cc fCmplxSVD.cc fCmplxQR.cc \
+ fCmplxQRP.cc floatAEPBAL.cc floatCHOL.cc floatDET.cc \
+ floatGEPBAL.cc floatHESS.cc floatLU.cc \
  floatSCHUR.cc floatSVD.cc floatQR.cc floatQRP.cc
 
 MX_OP_SRC := $(shell $(AWK) -f $(srcdir)/mk-ops.awk prefix=mx list_cc_files=1 $(srcdir)/mx-ops)


# HG changeset patch
# User David Bateman <dbateman@...>
# Date 1211532298 -7200
# Node ID 246249c3fcb794691319000d7fa956dd3ee47cda
# Parent  cf6d171ad22452d1788774463f1cf0da90529a6f
Correct initialize in FloatAEPBALANCE::init

diff --git a/liboctave/ChangeLog b/liboctave/ChangeLog
--- a/liboctave/ChangeLog
+++ b/liboctave/ChangeLog
@@ -1,5 +1,9 @@ 2008-05-23  David Bateman  <dbateman@fre
 2008-05-23  David Bateman  <dbateman@...>
 
+ * floatAEPBAL.cc (octave_idx_type FloatAEPBALANCE::init (const
+ FloatMatrix&, const std::string&)): Use FloatMatrix to initialize
+ balancing_mat.
+
  * Makefile.in (MATRIX_INC): Add fCmplxAEPBAL.h and floatAEPBAL.h.
  (MATRIX_SRC): Add fCmplxAEPBAL.cc and floatAEPBAL.cc.
 
diff --git a/liboctave/floatAEPBAL.cc b/liboctave/floatAEPBAL.cc
--- a/liboctave/floatAEPBAL.cc
+++ b/liboctave/floatAEPBAL.cc
@@ -74,7 +74,7 @@ FloatAEPBALANCE::init (const FloatMatrix
      n, p_balanced_mat, n, ilo, ihi, pscale, info
      F77_CHAR_ARG_LEN (1)));
 
-  balancing_mat = Matrix (n, n, 0.0);
+  balancing_mat = FloatMatrix (n, n, 0.0);
   for (octave_idx_type i = 0; i < n; i++)
     balancing_mat.elem (i ,i) = 1.0;
 


_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[Thomas Treichl]

David Bateman schrieb:
> Thomas Treichl wrote:
> Ok, I now have a changeset to fix this issue, but there was a secondary
> issue that prevented compilation.. You'll need the two changesets attached..
>
> Sorry
> David

No problem, now it's me who must say that I'm sorry for being annoying: Your
patches brought me through balance.cc but now I'm failing at lu.cc, ideas?

   /usr/bin/ld: Undefined symbols:
   base_lu<FloatComplexMatrix, std::complex<float>, Matrix, double>::L() const
   base_lu<FloatComplexMatrix, std::complex<float>, Matrix, double>::P() const
   base_lu<FloatComplexMatrix, std::complex<float>, Matrix, double>::U() const
   base_lu<FloatComplexMatrix, std::complex<float>, Matrix, double>::P_vec()
     const
   collect2: ld returned 1 exit status
   make[2]: *** [lu.oct] Error 1
   make[1]: *** [src] Error 2
   make: *** [all] Error 2

I've commented out compilation of lu.cc, then I succeeded, so what I mean is
that this seems to be the last problem that still is there. I can now work on
the test fails on Mac for the default branch, hopefully solving some on my own ;)

   Thomas
_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[David Bateman]

Thomas Treichl wrote:

> David Bateman schrieb:
>> Thomas Treichl wrote:
>> Ok, I now have a changeset to fix this issue, but there was a secondary
>> issue that prevented compilation.. You'll need the two changesets
>> attached..
>>
>> Sorry
>> David
>
> No problem, now it's me who must say that I'm sorry for being
> annoying: Your patches brought me through balance.cc but now I'm
> failing at lu.cc, ideas?
>
>   /usr/bin/ld: Undefined symbols:
>   base_lu<FloatComplexMatrix, std::complex<float>, Matrix,
> double>::L() const
>   base_lu<FloatComplexMatrix, std::complex<float>, Matrix,
> double>::P() const
>   base_lu<FloatComplexMatrix, std::complex<float>, Matrix,
> double>::U() const
>   base_lu<FloatComplexMatrix, std::complex<float>, Matrix,
> double>::P_vec()
>     const
>   collect2: ld returned 1 exit status
>   make[2]: *** [lu.oct] Error 1
>   make[1]: *** [src] Error 2
>   make: *** [all] Error 2
>
> I've commented out compilation of lu.cc, then I succeeded, so what I
> mean is that this seems to be the last problem that still is there. I
> can now work on the test fails on Mac for the default branch,
> hopefully solving some on my own ;)
>
>   Thomas
>

Opps, again my fault.. It shows that I haven't gotten the test code for

this written yet, and you are turning up a number of bugs.. Try the
attached changeset

D.


--
David Bateman                                David.Bateman@...
Motorola Labs - Paris                        [phone] (Ph)
Parc Les Algorithmes, Commune de St Aubin    [phone] (Mob)
91193 Gif-Sur-Yvette FRANCE                  [phone] (Fax)

The information contained in this communication has been classified as:

[x] General Business Information
[ ] Motorola Internal Use Only
[ ] Motorola Confidential Proprietary


# HG changeset patch
# User David Bateman <dbateman@...>
# Date 1211557224 -7200
# Node ID 05855defdd6dbc548a4d058e3e3d230086a7bb33
# Parent  246249c3fcb794691319000d7fa956dd3ee47cda
Error in FloatComplexLU instantiation

diff --git a/liboctave/ChangeLog b/liboctave/ChangeLog
--- a/liboctave/ChangeLog
+++ b/liboctave/ChangeLog
@@ -1,5 +1,7 @@ 2008-05-23  David Bateman  <dbateman@fre
 2008-05-23  David Bateman  <dbateman@...>
 
+ * fCmplxLU.h (class FloatComplexLU): Correct error in instantiation.
+
  * floatAEPBAL.cc (octave_idx_type FloatAEPBALANCE::init (const
  FloatMatrix&, const std::string&)): Use FloatMatrix to initialize
  balancing_mat.
diff --git a/liboctave/fCmplxLU.h b/liboctave/fCmplxLU.h
--- a/liboctave/fCmplxLU.h
+++ b/liboctave/fCmplxLU.h
@@ -30,22 +30,22 @@ along with Octave; see the file COPYING.
 
 class
 OCTAVE_API
-FloatComplexLU : public base_lu <FloatComplexMatrix, FloatComplex, Matrix, double>
+FloatComplexLU : public base_lu <FloatComplexMatrix, FloatComplex, FloatMatrix, float>
 {
 public:
 
   FloatComplexLU (void)
-    : base_lu <FloatComplexMatrix, FloatComplex, Matrix, double> () { }
+    : base_lu <FloatComplexMatrix, FloatComplex, FloatMatrix, float> () { }
 
   FloatComplexLU (const FloatComplexMatrix& a);
 
   FloatComplexLU (const FloatComplexLU& a)
-    : base_lu <FloatComplexMatrix, FloatComplex, Matrix, double> (a) { }
+    : base_lu <FloatComplexMatrix, FloatComplex, FloatMatrix, float> (a) { }
 
   FloatComplexLU& operator = (const FloatComplexLU& a)
     {
       if (this != &a)
- base_lu <FloatComplexMatrix, FloatComplex, Matrix, double> :: operator = (a);
+ base_lu <FloatComplexMatrix, FloatComplex, FloatMatrix, float> :: operator = (a);
 
       return *this;
     }

_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[David Bateman]

David Bateman wrote:

> Thomas Treichl wrote:
>  
>> David Bateman schrieb:
>>    
>>> Thomas Treichl wrote:
>>> Ok, I now have a changeset to fix this issue, but there was a secondary
>>> issue that prevented compilation.. You'll need the two changesets
>>> attached..
>>>
>>> Sorry
>>> David
>>>      
>> No problem, now it's me who must say that I'm sorry for being
>> annoying: Your patches brought me through balance.cc but now I'm
>> failing at lu.cc, ideas?
>>
>>   /usr/bin/ld: Undefined symbols:
>>   base_lu<FloatComplexMatrix, std::complex<float>, Matrix,
>> double>::L() const
>>   base_lu<FloatComplexMatrix, std::complex<float>, Matrix,
>> double>::P() const
>>   base_lu<FloatComplexMatrix, std::complex<float>, Matrix,
>> double>::U() const
>>   base_lu<FloatComplexMatrix, std::complex<float>, Matrix,
>> double>::P_vec()
>>     const
>>   collect2: ld returned 1 exit status
>>   make[2]: *** [lu.oct] Error 1
>>   make[1]: *** [src] Error 2
>>   make: *** [all] Error 2
>>
>> I've commented out compilation of lu.cc, then I succeeded, so what I
>> mean is that this seems to be the last problem that still is there. I
>> can now work on the test fails on Mac for the default branch,
>> hopefully solving some on my own ;)
>>
>>   Thomas
>>
>>    
> Opps, again my fault.. It shows that I haven't gotten the test code for
> this written yet, and you are turning up a number of bugs.. Try the
> attached changeset
>
> D.
>
>  
>

Humm, too fast.. The permutation vector should always be of double type
even for the single precision LU, as its effectively storing the
octave_idx_type values. So the attached is more correct.

D.


--
David Bateman                                David.Bateman@...
Motorola Labs - Paris                        [phone] (Ph)
Parc Les Algorithmes, Commune de St Aubin    [phone] (Mob)
91193 Gif-Sur-Yvette FRANCE                  [phone] (Fax)

The information contained in this communication has been classified as:

[x] General Business Information
[ ] Motorola Internal Use Only
[ ] Motorola Confidential Proprietary


# HG changeset patch
# User David Bateman <dbateman@...>
# Date 1211558170 -7200
# Node ID 0703193da42919d4c6659403a1ffd005c62782d9
# Parent  246249c3fcb794691319000d7fa956dd3ee47cda
Error in FloatComplexLU instantiation

diff --git a/liboctave/ChangeLog b/liboctave/ChangeLog
--- a/liboctave/ChangeLog
+++ b/liboctave/ChangeLog
@@ -1,5 +1,9 @@ 2008-05-23  David Bateman  <dbateman@fre
 2008-05-23  David Bateman  <dbateman@...>
 
+ * fCmplxLU.cc (class FloatComplexLU): Correct error in instantiation.
+ * floatLU.cc (class FloatLU): ditto.
+ * floatLU.h (class FloatLU): ditto.
+
  * floatAEPBAL.cc (octave_idx_type FloatAEPBALANCE::init (const
  FloatMatrix&, const std::string&)): Use FloatMatrix to initialize
  balancing_mat.
diff --git a/liboctave/fCmplxLU.cc b/liboctave/fCmplxLU.cc
--- a/liboctave/fCmplxLU.cc
+++ b/liboctave/fCmplxLU.cc
@@ -34,7 +34,7 @@ along with Octave; see the file COPYING.
 #include <base-lu.h>
 #include <base-lu.cc>
 
-template class base_lu <FloatComplexMatrix, FloatComplex, FloatMatrix, float>;
+template class base_lu <FloatComplexMatrix, FloatComplex, Matrix, double>;
 
 // Define the constructor for this particular derivation.
 
diff --git a/liboctave/floatLU.cc b/liboctave/floatLU.cc
--- a/liboctave/floatLU.cc
+++ b/liboctave/floatLU.cc
@@ -34,7 +34,7 @@ along with Octave; see the file COPYING.
 #include <base-lu.h>
 #include <base-lu.cc>
 
-template class base_lu <FloatMatrix, float, FloatMatrix, float>;
+template class base_lu <FloatMatrix, float, Matrix, double>;
 
 // Define the constructor for this particular derivation.
 
diff --git a/liboctave/floatLU.h b/liboctave/floatLU.h
--- a/liboctave/floatLU.h
+++ b/liboctave/floatLU.h
@@ -25,24 +25,25 @@ along with Octave; see the file COPYING.
 #define octave_FloatLU_h 1
 
 #include "base-lu.h"
+#include "dMatrix.h"
 #include "fMatrix.h"
 
 class
 OCTAVE_API
-FloatLU : public base_lu <FloatMatrix, float, FloatMatrix, float>
+FloatLU : public base_lu <FloatMatrix, float, Matrix, double>
 {
 public:
 
-  FloatLU (void) : base_lu <FloatMatrix, float, FloatMatrix, float> () { }
+  FloatLU (void) : base_lu <FloatMatrix, float, Matrix, double> () { }
 
   FloatLU (const FloatMatrix& a);
 
-  FloatLU (const FloatLU& a) : base_lu <FloatMatrix, float, FloatMatrix, float> (a) { }
+  FloatLU (const FloatLU& a) : base_lu <FloatMatrix, float, Matrix, double> (a) { }
 
   FloatLU& operator = (const FloatLU& a)
     {
       if (this != &a)
- base_lu <FloatMatrix, float, FloatMatrix, float> :: operator = (a);
+ base_lu <FloatMatrix, float, Matrix, double> :: operator = (a);
 
       return *this;
     }

_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[David Bateman]

David Bateman wrote:
> Humm, too fast.. The permutation vector should always be of double type
> even for the single precision LU, as its effectively storing the
> octave_idx_type values. So the attached is more correct.
>
> D.
>
>
>  
and you'll need this as well.

D.

--
David Bateman                                David.Bateman@...
Motorola Labs - Paris                        [phone] (Ph)
Parc Les Algorithmes, Commune de St Aubin    [phone] (Mob)
91193 Gif-Sur-Yvette FRANCE                  [phone] (Fax)

The information contained in this communication has been classified as:

[x] General Business Information
[ ] Motorola Internal Use Only
[ ] Motorola Confidential Proprietary


# HG changeset patch
# User David Bateman <dbateman@...>
# Date 1211558404 -7200
# Node ID 0a4a6667a2cd85eecc6bba0ebef8c20583131f7c
# Parent  0703193da42919d4c6659403a1ffd005c62782d9
minor additional fix

diff --git a/liboctave/fCmplxLU.h b/liboctave/fCmplxLU.h
--- a/liboctave/fCmplxLU.h
+++ b/liboctave/fCmplxLU.h
@@ -25,7 +25,7 @@ along with Octave; see the file COPYING.
 #define octave_FloatComplex_LU_h 1
 
 #include "base-lu.h"
-#include "fMatrix.h"
+#include "dMatrix.h"
 #include "fCMatrix.h"
 
 class

_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[Thomas Treichl]

David Bateman schrieb:

> David Bateman wrote:
>> Humm, too fast.. The permutation vector should always be of double type
>> even for the single precision LU, as its effectively storing the
>> octave_idx_type values. So the attached is more correct.
>>
>> D.
>>  
> and you'll need this as well.
>
> D.

Yes ok, now it works. I had some troubles applying your patches (maybe I did
something wrong or so) but for info I applied your patches 8134 (your second)
then 8135 and finally 8134 (your first), then it worked... Without 8134 (your
first) I got the same linking error?!

Thanks for the updates,

   Thomas
_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[John W. Eaton]

On 23-May-2008, David Bateman wrote:

| Thomas Treichl wrote:
| > Hi,
| >
| > I've got more problems compiling the default branch on my Mac. I spent the whole
| > evening finding out where the problem really is, but couldn't find the place
| > where the function (as the linker wants it to see this way) should be needed.
| >
| > I found another init definition in the files liboctave/floatAEPBAL.h and
| > liboctave/fCmplxAEPBAL.h, but not the one - check number of arguments - that
| > would be required.
| >
| > I always do a maintainer-clean, autogen.sh and then configure, I also checked
| > this time if there are some old *o, *dylib, *def were left, but it was clean. So
| > the detailed error message when trying to link src/DLD-FUNCTIONS/balance.cc is
| >
| >    /usr/bin/ld: Undefined symbols:
| >    FloatAEPBALANCE::init(FloatMatrix const&, std::basic_string<char,
| >    std::char_traits<char>, std::allocator<char> > const&)
| >    FloatComplexAEPBALANCE::init(FloatComplexMatrix const&,
| >    std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
| >    collect2: ld returned 1 exit status
| >    make[2]: *** [balance.oct] Error 1
| >    make[1]: *** [src] Error 2
| >    make: *** [all] Error 2
| >
| >  
|
| Ok, I now have a changeset to fix this issue, but there was a secondary
| issue that prevented compilation.. You'll need the two changesets attached..

I applied these changes.

Thanks,

jwe
_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[John W. Eaton]

On 23-May-2008, David Bateman wrote:

| David Bateman wrote:
| > Thomas Treichl wrote:
| >  
| >> David Bateman schrieb:
| >>    
| >>> Thomas Treichl wrote:
| >>> Ok, I now have a changeset to fix this issue, but there was a secondary
| >>> issue that prevented compilation.. You'll need the two changesets
| >>> attached..
| >>>
| >>> Sorry
| >>> David
| >>>      
| >> No problem, now it's me who must say that I'm sorry for being
| >> annoying: Your patches brought me through balance.cc but now I'm
| >> failing at lu.cc, ideas?
| >>
| >>   /usr/bin/ld: Undefined symbols:
| >>   base_lu<FloatComplexMatrix, std::complex<float>, Matrix,
| >> double>::L() const
| >>   base_lu<FloatComplexMatrix, std::complex<float>, Matrix,
| >> double>::P() const
| >>   base_lu<FloatComplexMatrix, std::complex<float>, Matrix,
| >> double>::U() const
| >>   base_lu<FloatComplexMatrix, std::complex<float>, Matrix,
| >> double>::P_vec()
| >>     const
| >>   collect2: ld returned 1 exit status
| >>   make[2]: *** [lu.oct] Error 1
| >>   make[1]: *** [src] Error 2
| >>   make: *** [all] Error 2
| >>
| >> I've commented out compilation of lu.cc, then I succeeded, so what I
| >> mean is that this seems to be the last problem that still is there. I
| >> can now work on the test fails on Mac for the default branch,
| >> hopefully solving some on my own ;)
| >>
| >>   Thomas
| >>
| >>    
| > Opps, again my fault.. It shows that I haven't gotten the test code for
| > this written yet, and you are turning up a number of bugs.. Try the
| > attached changeset
| >
| > D.
| >
| >  
| >
|
| Humm, too fast.. The permutation vector should always be of double type
| even for the single precision LU, as its effectively storing the
| octave_idx_type values. So the attached is more correct.

I applied this changeset.

Thanks,

jwe
_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[John W. Eaton]

On 23-May-2008, David Bateman wrote:

| David Bateman wrote:
| > Humm, too fast.. The permutation vector should always be of double type
| > even for the single precision LU, as its effectively storing the
| > octave_idx_type values. So the attached is more correct.
| >
| > D.
| >
| >
| >  
| and you'll need this as well.

Applied.

Thanks,

jwe
_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave