Nabble - MozDev - conkeror

Re: Error messages Was: [PATCH] Let completion functions set the match_required state.

2009-11-25T08:17:28Z

On Wed, Nov 25, 2009 at 11:04:32PM +1030, David Kettler wrote:

> >Those errors are dumped to the console by conkeror, not xulrunner. See
> >utils.js, console_service.registerListener...
>
> Okay, thanks.
>
> >I find it helpful to see
> >content javascript errors on the console. Do you have another idea?
>
> I'm mostly interested in errors from conkeror, but usually not from
> content over which I have no control. Mainly I don't want to miss
> seeing a conkeror error because I'm ignoring other crap.
>
> Usually I run conkeror from the command line so that errors just end
> up in my terminal. Simply redirecting output to a file that I
> occasionally inspect will probably fix the problem for me. Two
> other suggestions:
>
> Put content errors in a log file, separate from conkeror errors.
>
> Have much terser errors on the output. Put details in a log file.
>
> But if others aren't bothered, I'll just change my habits.
>
> regards, David

Please open a thread about this on bugs.conkeror.org and we can collect
ideas for better ways to deal with errors, warnings and messages. This is
the kind of thing that could easily turn into a huge project involving the
creation of a *Messages* buffer, user-configurable streams for different
log levels, et cetera.

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Error messages Was: [PATCH] Let completion functions set the match_required state.

2009-11-25T04:34:32Z

> Those errors are dumped to the console by conkeror, not xulrunner. See
> utils.js, console_service.registerListener...

Okay, thanks.

> I find it helpful to see
> content javascript errors on the console. Do you have another idea?

I'm mostly interested in errors from conkeror, but usually not from
content over which I have no control. Mainly I don't want to miss
seeing a conkeror error because I'm ignoring other crap.

Usually I run conkeror from the command line so that errors just end up
in my terminal. Simply redirecting output to a file that I occasionally
inspect will probably fix the problem for me. Two other suggestions:

Put content errors in a log file, separate from conkeror errors.

Have much terser errors on the output. Put details in a log file.

But if others aren't bothered, I'll just change my habits.

regards, David
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Spellcheck?

2009-11-23T09:09:42Z

I couldn't find anything, but is there a spell check module available?

'Mash
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Let completion functions set the match_required state.

2009-11-22T18:51:54Z

On Mon, Nov 23, 2009 at 08:09:43AM +1030, David Kettler wrote:

> >>>Lots of errors on the console.
>
> I was surprised that I had missed this problem, especially as I've
> been using this code for about six months. I think there's two
> reasons. Firstly, while I had tested various cases, I didn't realise
> there was this difference with the wikipedia webjump and had not
> specifically tested that case. Secondly, xulrunner reports many
> javascript errors from various webpages. So conkeror errors can be
> lost in the garbage.
>
> I wonder if there's a way to direct the errors from webpages
> separately from conkeror errors.
>
> regards, David.

Those errors are dumped to the console by conkeror, not xulrunner. See
utils.js, console_service.registerListener... I find it helpful to see
content javascript errors on the console. Do you have another idea?

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Let completion functions set the match_required state.

2009-11-22T13:39:43Z

>>> Lots of errors on the console.

I was surprised that I had missed this problem, especially as I've been
using this code for about six months. I think there's two reasons.
Firstly, while I had tested various cases, I didn't realise there was
this difference with the wikipedia webjump and had not specifically
tested that case. Secondly, xulrunner reports many javascript errors
from various webpages. So conkeror errors can be lost in the garbage.

I wonder if there's a way to direct the errors from webpages separately
from conkeror errors.

regards, David.
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Let completion functions set the match_required state.

2009-11-22T07:04:50Z

On Sun, Nov 22, 2009 at 09:49:33PM +1030, David Kettler wrote:

> >Lots of errors on the console. Can you look into this?
>
> Thanks. I pushed the following fix.
>
> Subject: [PATCH] Properly merge completers with null elements
>
> When a completer does not support an element it was possible for merge
> completers to erroneously call the next completer with a negative
> index. For instance, this occurred with the wikipedia webjump, for
> which the search engine does not provide descriptions for its
> completions.
>
> This latent bug was exposed by 2005f2e (Let completion functions set
> the match_required state) because more completers can now be on the
> completion list, even if they have no results.

Thank you

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Let completion functions set the match_required state.

2009-11-22T03:19:33Z

> Lots of errors on the console. Can you look into this?

Thanks. I pushed the following fix.

Subject: [PATCH] Properly merge completers with null elements

When a completer does not support an element it was possible for merge
completers to erroneously call the next completer with a negative
index. For instance, this occurred with the wikipedia webjump, for
which the search engine does not provide descriptions for its
completions.

This latent bug was exposed by 2005f2e (Let completion functions set
the match_required state) because more completers can now be on the
completion list, even if they have no results.
---
modules/minibuffer-completion.js | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/modules/minibuffer-completion.js
b/modules/minibuffer-completion.js
index e221bc4..ff453de 100644
--- a/modules/minibuffer-completion.js
+++ b/modules/minibuffer-completion.js
@@ -283,6 +283,8 @@ function merge_completers (completers) {
if (name in r && r[name] != null) {
args.unshift(i);
return r[name].apply(this, args);
+ } else {
+ return null;
}
}
i -= r.count;

_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Let completion functions set the match_required state.

2009-11-21T20:08:00Z

On Thu, Nov 19, 2009 at 12:07:39AM +1030, David Kettler wrote:

> >Cool feature. Okay
>
> Pushed. There's a remaining case though that should be covered. If
> the completer fails (say because it couldn't load a file and it threw
> an error), then the match_required doesn't get passed through. So,
> for instance the new xpath webjumps will report errors properly when
> you try to complete, but when you press enter it will follow a bogus
> url.
>
> regards, David

Found another problem with this patch.. To reproduce:

* start conkeror -q
* g wikipedia tag

Lots of errors on the console. Can you look into this?

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: Page mode keymaps

2009-11-20T08:11:59Z

On Fri, Nov 20, 2009 at 05:49:01PM +1030, David Kettler wrote:
> >In emacs, unmodified alphanumerics are bound to self-insert, which is more
> >or less equivalent to Conkeror's concept of a fallthrough. Conkeror's use
> >of unmodified alphanumeric bindings is not only very un-emacsy, ...
>
> But many emacs modes that are "applications" in themselves do use
> plain alphabetic keys extensively; e.g. dired, gnus. Conkeror's
> bindings are consistent with emacs usage in that sense.

I think the analogy to emacs applications was definitely an important
principle early on in the development of Conkeror, but experience has
taught us that the analogy quickly breaks down because of the sheer
complexity of dealing with DOM documents on the web, as compared to the
relative simplicity of working with plain text. DOM documents can be
applications in their own right with key bindings that need to be
respected, etc.

>
> >Our concept of modality is really a lot more like vi's UI than emacs's.
>
> Yeah, bummer.
>

Haha, I don't see it as a bummer at all. I think it's a gift that a nice
program like vi exists, from which we can gain ideas for ways to solve
problems for which the emacs UI style is insufficient.

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: Page mode keymaps

2009-11-19T23:19:01Z

> In emacs, unmodified alphanumerics are bound to self-insert, which is more
> or less equivalent to Conkeror's concept of a fallthrough. Conkeror's use
> of unmodified alphanumeric bindings is not only very un-emacsy, ...

But many emacs modes that are "applications" in themselves do use plain
alphabetic keys extensively; e.g. dired, gnus. Conkeror's bindings are
consistent with emacs usage in that sense.

> Our concept of modality is really a lot more like vi's UI than emacs's.

Yeah, bummer.

_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: Questions about history

2009-11-19T14:18:14Z

Silvio Levy <levy@...> writes:

> Dear Conkeror Wizards,
> Two questions about history:

> 1. How can I find out when a URL that I see on the history buffer was
> visited?

> 2. How can I dump the history buffer somewhere? Often the information
> I want from the history is a URL string, but I'm unable to cut and
> paste it. In fact I generally can't even see it in full, unless I make
> the window very wide and the font size smaller than is comfortable for
> me.

C-x C-v is useful for getting the current URL.

--
Jeremy Maitin-Shepard
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: Page mode keymaps

2009-11-19T11:40:17Z

On Thu, Nov 19, 2009 at 10:45:35PM +1030, David Kettler wrote:

> Thanks for the explanation, John. Sounds good.
>
> > The last piece of the puzzle will be
> >providing a UI by which the user can interactively toggle optional
> >keymaps, though I'm not sure exactly what form that UI will take at the
> >moment.
>
> It's be nice if it were possible to have both sets of keys
> available without collision, to avoid the need to toggle. That
> works in emacs because there are strong conventions to avoid
> modes stomping on general keys. Whereas keys assigned by sites
> are very likely to collide with conkeror key assignments. And
> the standard conkeror keystrokes are too convenient to change for
> this purpose.
>
> Just musing, David

In emacs, unmodified alphanumerics are bound to self-insert, which is more
or less equivalent to Conkeror's concept of a fallthrough. Conkeror's use
of unmodified alphanumeric bindings is not only very un-emacsy, but also
very much in conflict with the assumptions of most web designers, because
there seems to be an implicit convention that those keys should be
available for web pages to use.

That said, having those bindings is so convenient, and so fundamental to
Conkeror's UI, that it's not really an option to give them up. Thus, we
must muddle along and deal with the conflicts as best we can.

Our concept of modality is really a lot more like vi's UI than emacs's.

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Show errors from completers, etc.

2009-11-19T04:29:55Z

> Oh okay, sounds like a good thing then.

Thanks. Pushed.

_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [RFC] index-webjump: test suite

2009-11-19T04:24:56Z

I could have the text of the two xml files literally in the test suite
and modify the index-webjump to parse that text. Is that what you
mean? Maybe that's the best solution, but it will mean a little less
of the code is exercised by the test.

You suggested chrome://conkeror-contrib elsewhere. How about also
having a chrome://conkeror-test something like the following. Then I
don't need conkeror_source_code_path. (I'd chop this into 2 or 3
commits to push.)

Subject: [PATCH] Make chrome URLs for contrib and tests. Use in
index-webjump test.

---
chrome/chrome.manifest | 3 +++
modules/utils.js | 5 +++++
tests/simple/index-webjump.js | 11 ++---------
3 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/chrome/chrome.manifest b/chrome/chrome.manifest
index 2b49211..db7a844 100644
--- a/chrome/chrome.manifest
+++ b/chrome/chrome.manifest
@@ -6,6 +6,9 @@ locale conkeror-gui en-US file:../locale/en-US/

content conkeror-help file:../help/

+content conkeror-contrib file:../contrib/modules/
+content conkeror-test file:../tests/
+
locale branding en-US file:../branding/

override chrome://global/locale/netErrorApp.dtd
chrome://conkeror-gui/locale/netError.dtd
diff --git a/modules/utils.js b/modules/utils.js
index e2dd6d3..3d724f3 100644
--- a/modules/utils.js
+++ b/modules/utils.js
@@ -144,6 +144,11 @@ function make_uri (uri, charset, base_uri) {
return io_service.newURI(uri, charset, base_uri);
}

+function make_file_from_chrome (url) {
+ var crs = Cc['@mozilla.org/chrome/chrome-registry;1']
+ .getService(Ci.nsIChromeRegistry);
+ return crs.convertChromeURL(make_uri(url));
+}

function get_document_content_disposition (document_o) {
var content_disposition = null;
diff --git a/tests/simple/index-webjump.js b/tests/simple/index-webjump.js
index 8df10fe..aff8a76 100644
--- a/tests/simple/index-webjump.js
+++ b/tests/simple/index-webjump.js
@@ -12,7 +12,7 @@ require('index-webjump.js');
conkeror.webjumps = this.real_webjumps;
conkeror.index_webjumps = this.real_index_webjumps;
},
- path: conkeror_source_code_path + "/tests/simple",
+ path:
make_file_from_chrome("chrome://conkeror-test/content/simple").path,
test_xpath_webjump: function () {
define_xpath_webjump(
"xpath", "http://dummy/xpath", '//xhtml:a[@class="index"]',
@@ -41,12 +41,5 @@ require('index-webjump.js');
assert_equals(w.completions[1][0], "foo");
},
};
- if (conkeror_source_code_path)
- walnut_run(suite);
- else
- dumpln('Suite setup failed; conkeror_source_code_path not set.' +
- ' Try:\n' +
- ' conkeror -q -batch' +
- ' -e "conkeror_source_code_path=\\"$PWD\\";"' +
- ' -l tests/simple/index-webjump.js');
+ walnut_run(suite);
}
--
1.6.5
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: Page mode keymaps

2009-11-19T04:15:35Z

Thanks for the explanation, John. Sounds good.

> The last piece of the puzzle will be
> providing a UI by which the user can interactively toggle optional
> keymaps, though I'm not sure exactly what form that UI will take at the
> moment.

It's be nice if it were possible to have both sets of keys
available without collision, to avoid the need to toggle. That
works in emacs because there are strong conventions to avoid
modes stomping on general keys. Whereas keys assigned by sites
are very likely to collide with conkeror key assignments. And
the standard conkeror keystrokes are too convenient to change for
this purpose.

Just musing, David
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Provide buttons on the mode-line for basic browser control.

2009-11-19T04:02:42Z

> We'll need to make a chrome domain for conkeror-contrib, so that people
> can opt in with:
>
> load_paths.unshift("chrome://conkeror-contrib/content/");

Okay, sounds good.

It'd also be nice to be able to directly require() such a chrome: url.
And load it from the command line with -l.

regards, David
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Show errors from completers, etc.

2009-11-18T12:18:29Z

On Thu, Nov 19, 2009 at 12:12:07AM +1030, David Kettler wrote:

> >Can you tell me steps to reproduce the problem, to help me understand the
> >situation being addressed here?
>
> With the new index-webjump mode, the xpath webjumps are unusable
> without completions being available, so the index webjump completer
> will throw an error in that case. Without this patch, the error will
> be discarded, so the user won't see the explanation and won't know why
> there are no completions.
>
> You can see the problem by defining such a webjump, e.g.:
>
> define_xpath_webjump(
> "gitdoc",
> "http://www.kernel.org/pub/software/scm/git/docs/",
> '//xhtml:dt/xhtml:a',
> $description = "Git documentation");
>
> Do not call webjump-get-index. Now press "g gitdoc g". The last "g"
> will try to load the completions, which will fail. Without this patch
> the user won't know why.
>
> But see also my reply to [PATCH] Let completion functions set the
> match_required state.
>
> There may be other ways to currently trigger such an error, and future
> changes might introduce more. It's a good general principle to give
> the user info about what failed.

Oh okay, sounds like a good thing then.

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Provide buttons on the mode-line for basic browser control.

2009-11-18T10:57:55Z

On Wed, Nov 18, 2009 at 10:38:37AM -0800, Brian Edmonds wrote:
> I'm generally not that excited about browser bling, but having a tablet, I've
> given thought a number of times to adding buttons for at least switching and
> closing buffers.

See new-tabs.

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: Page mode keymaps

2009-11-18T10:49:02Z

On Thu, Nov 19, 2009 at 12:12:51AM +1030, David Kettler wrote:
> John, I'm interested in hearing about your intentions regarding the
> new keymap and input system with page modes. The present overriding
> of keystrokes is certainly awkward to use. Do you intend that there
> simply be a convenient way to toggle modes between the page mode
> keymap and content_buffer_normal_keymap?

I want to split up page-modes, and remove the restriction of "there can be
only one". Instead of each existing "monolithic" page-mode, there would
be a group of additive modes, each of which is responsible for one
feature. In emacs terminology, page-modes will be more like a collection
of minor-modes than like a major-mode. In mozilla terminology, page-modes
will be more like greasemonkey scripts.

Some of these modes will provide keymaps, but there will be nothing
special about those keymaps.. they would just be optional keymaps as could
be installed by any module. The last piece of the puzzle will be
providing a UI by which the user can interactively toggle optional
keymaps, though I'm not sure exactly what form that UI will take at the
moment.

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Provide buttons on the mode-line for basic browser control.

2009-11-18T10:38:37Z

I'm generally not that excited about browser bling, but having a tablet, I've given thought a number of times to adding buttons for at least switching and closing buffers.

Brian.

On Nov 18, 2009 10:25 AM, "John J. Foerch" <jjfoerch@...> wrote:

On Thu, Nov 19, 2009 at 12:10:56AM +1030, David Kettler wrote: > > I like the feature, but I don't t...
We'll need to make a chrome domain for conkeror-contrib, so that people
can opt in with:

load_paths.unshift("chrome://conkeror-contrib/content/");

--
John Foerch

_______________________________________________ Conkeror mailing list Conkeror@... https://ww...

_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Provide buttons on the mode-line for basic browser control.

2009-11-18T10:24:17Z

On Thu, Nov 19, 2009 at 12:10:56AM +1030, David Kettler wrote:

> > I like the feature, but I don't think the framework is in place to do it
> > robustly yet.
>
> Yes, it's just a quick hack. Also, the text and generic widgets could
> do with some refactoring.
>
> > No objections to something like this going into contrib/ or the wiki,
> > though, so people who would find it convenient can use it in the
> meantime.
>
> If I put it in contrib, what's the best way to suggest that people use
> it:
> - require(conkeror_source_code_path +
> "/contrib/modules/mode-line-buttons.js");
> - or symlink into ~/.conkerorrc (or whatever) and use an explicit path?
>
> The patch also included a minor change to mode-line. I can make that
> a separate patch.

We'll need to make a chrome domain for conkeror-contrib, so that people
can opt in with:

load_paths.unshift("chrome://conkeror-contrib/content/");

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [RFC] index-webjump: test suite

2009-11-18T09:55:21Z

On Thu, Nov 19, 2009 at 12:09:45AM +1030, David Kettler wrote:
> >Is there a way that this suite could fail when conkeror_source_code_path
> >is not set, and provide instructions to the user for how to set it from
> >the command line?
>
> I kludged that in and pushed it. Maybe it would be better for walnut
> to check for failure in suite_setup().
>
> regards, David

What about using a mock object instead? Haven't read the code in detail,
so maybe I misunderstand.

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Page mode keymaps

2009-11-18T05:42:51Z

John, I'm interested in hearing about your intentions regarding the
new keymap and input system with page modes. The present overriding
of keystrokes is certainly awkward to use. Do you intend that there
simply be a convenient way to toggle modes between the page mode
keymap and content_buffer_normal_keymap?

regards, David
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Show errors from completers, etc.

2009-11-18T05:42:07Z

> Can you tell me steps to reproduce the problem, to help me understand the
> situation being addressed here?

With the new index-webjump mode, the xpath webjumps are unusable
without completions being available, so the index webjump completer
will throw an error in that case. Without this patch, the error will
be discarded, so the user won't see the explanation and won't know why
there are no completions.

You can see the problem by defining such a webjump, e.g.:

define_xpath_webjump(
"gitdoc",
"http://www.kernel.org/pub/software/scm/git/docs/",
'//xhtml:dt/xhtml:a',
$description = "Git documentation");

Do not call webjump-get-index. Now press "g gitdoc g". The last "g"
will try to load the completions, which will fail. Without this patch
the user won't know why.

But see also my reply to [PATCH] Let completion functions set the
match_required state.

There may be other ways to currently trigger such an error, and future
changes might introduce more. It's a good general principle to give
the user info about what failed.

regards, David
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Provide buttons on the mode-line for basic browser control.

2009-11-18T05:40:56Z

> I like the feature, but I don't think the framework is in place to do it
> robustly yet.

Yes, it's just a quick hack. Also, the text and generic widgets could
do with some refactoring.

> No objections to something like this going into contrib/ or the wiki,
> though, so people who would find it convenient can use it in the
meantime.

If I put it in contrib, what's the best way to suggest that people use
it:
- require(conkeror_source_code_path +
"/contrib/modules/mode-line-buttons.js");
- or symlink into ~/.conkerorrc (or whatever) and use an explicit path?

The patch also included a minor change to mode-line. I can make that
a separate patch.

regards, David
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [RFC] index-webjump: test suite

2009-11-18T05:39:45Z

> Is there a way that this suite could fail when conkeror_source_code_path
> is not set, and provide instructions to the user for how to set it from
> the command line?

I kludged that in and pushed it. Maybe it would be better for walnut
to check for failure in suite_setup().

regards, David
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Enable URL completion for both bookmarks and history (workaround).

2009-11-18T05:38:53Z

> Is there a way to filter the duplicates out?

Not easily. I suppose a modified merge_completers() could extract all
the completions, sort and uniquify them, then return the survivors to
pre-sorted order. I'm not particularly motivated to do so, for
several reasons.

Firstly, I no longer personally care for having both bookmark and
history completion. I have only webjump and history completion
enabled and I access bookmarks (with completion) via the "bookmark"
webjump.

Secondly, it's possible to have duplicates in any case, simply by
having multiple bookmarks of the same page. That tends to happen for
me, mostly because I don't cull the bookmarks (as there's currently no
convenient way to do so). Having many bookmarks isn't really an
issue, because the completion mechanism is superb.

Thirdly, this is in any case just a workaround for a mozilla bug;
maybe it will be fixed one day. But probably not; I can't access the
bug server now, but I seem to recall the bug has been known for many
years.
https://bugzilla.mozilla.org/show_bug.cgi?id=425726

In any case, I think the present patch is an incremental improvement
that's worth having for now.

regards, David
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Let completion functions set the match_required state.

2009-11-18T05:37:39Z

> Cool feature. Okay

Pushed. There's a remaining case though that should be covered. If
the completer fails (say because it couldn't load a file and it threw
an error), then the match_required doesn't get passed through. So,
for instance the new xpath webjumps will report errors properly when
you try to complete, but when you press enter it will follow a bogus
url.

regards, David
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] index-webjump: New module to define webjumps for index pages.

2009-11-18T05:36:32Z

Pushed with some additions:
- Check that there are a non-zero number of completions.
- Have tidy do more cleanup.
- index_webjumps_directory must be an nsILocalFile.

regards, David
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Fix command line +u

2009-11-18T05:35:30Z

Thanks for your reviews, John. I've pushed six patches, including this one.
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: Questions about history

2009-11-17T10:27:51Z

On Tue, Nov 17, 2009 at 10:10:27AM -0800, Silvio Levy wrote:

>
> Dear Conkeror Wizards,
>
> Two questions about history:
>
> 1. How can I find out when a URL that I see on the history buffer was
> visited?
>
> 2. How can I dump the history buffer somewhere? Often the information
> I want from the history is a URL string, but I'm unable to cut and
> paste it. In fact I generally can't even see it in full, unless I make
> the window very wide and the font size smaller than is comfortable for me.
>
> Thanks,
>
> Silvio

You'll have to do this through the mozilla api. Conkeror doesn't have
either of these features.

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Questions about history

2009-11-17T10:10:27Z

Dear Conkeror Wizards,

Two questions about history:

1. How can I find out when a URL that I see on the history buffer was
visited?

2. How can I dump the history buffer somewhere? Often the information
I want from the history is a URL string, but I'm unable to cut and
paste it. In fact I generally can't even see it in full, unless I make
the window very wide and the font size smaller than is comfortable for me.

Thanks,

Silvio

_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [RFC] index-webjump: test suite

2009-11-17T09:03:52Z

On Tue, Nov 17, 2009 at 10:14:29PM +1030, David Kettler wrote:
> This depends on [[PATCH] index-webjump: New module to define webjumps
> for index pages].
>
> The test is partially broken; it makes use of
> conkeror_source_code_path to find auxiliary test files, which fails
> when that variable is undefined. For command line use ctx.local.cwd
> would work, but the test suite doesn't have access to the context.

Is there a way that this suite could fail when conkeror_source_code_path
is not set, and provide instructions to the user for how to set it from
the command line?

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] Provide buttons on the mode-line for basic browser control.

2009-11-17T08:58:56Z

On Tue, Nov 17, 2009 at 10:14:30PM +1030, David Kettler wrote:

> Simple GUI buttons are provided for controlling conkeror. They are
> intended to be unobtrusive and to steal as little screen space as
> possible. Clicking on them executes a conkeror command. Hovering
> over them tells you the command and the corresponding keystroke.
>
> The buttons are intended to make conkeror usable for a casual user and
> also to aid the novice user while they become familiar with conkeror's
> interface.
>
> They can be enabled with:
> require("mode-line-buttons.js");
> add_mode_line_buttons(standard_mode_line_buttons, true);
> ---
>
> Problems:
> - The icons used do not clearly indicate their function.
> - The names of the commands are also probably unclear for novices.
> - There are probably too many buttons. It might be better to have
> just a few, together with a popup menu.

I like the feature, but I don't think the framework is in place to do it
robustly yet. What I have in mind is a more general Menu subsystem that
handles menus in the abstract, rather than in terms of particular UI
representations of them. I also think there are problems in the
interactive system that need to be addressed first, like a way to disable
commands, and gray-out buttons that run those commands, when they should
not be called.

No objections to something like this going into contrib/ or the wiki,
though, so people who would find it convenient can use it in the meantime.

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

Re: [PATCH] index-webjump: New module to define webjumps for index pages.

2009-11-17T08:43:24Z

On Tue, Nov 17, 2009 at 10:14:28PM +1030, David Kettler wrote:

> Index webjumps provide convenient access, with completion, to a set of
> web pages that are indexed (referenced) from another page. For
> instance, webjumps for documentation (e.g., git, ImageMagick) are easy
> to define.
>
> A webjump to access URLs referenced from an index page is defined
> using define_xpath_webjump. An xpath expression is used to extract
> the indexed URLs and the anchor text; this provides completion for the
> webjump. The completion must be enabled using webjump-get-index once
> for each index webjump.
>
> This module also subsumes define_gitweb_summary_webjump, which results
> in changes to how gitweb webjumps are set up.
> ---
>
> This patch only shows the new index-webjumps.js module. The eventual
> commit will also remove the existing gitweb-webjumps.js module.
>
> This makes use of functionality provided by [[PATCH] Let completion
> functions set the match_required state], but that is not vital. It's
> also helped by [[PATCH] Show errors from completers, etc].
>
> Conkeror wiki pages will also be updated as follows.

Sounds good

--
John Foerch

_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror