NET-API-BECOMEDC test broken by tsocket

[Andrew Bartlett]

Metze,

I was over the past few days been trying to debug issues around DRSUAPI,
and it seem that the tsocket changes have broken the NET-API-BECOMEDC
test.

tsocket does not allow the getaddrinfo() call to do DNS lookups, and
this is required by the way this code is called by smbtorture.

For some reason the net/vampire got manages to do the address resolution
at the right point.  

Should we keep the torture variant of this code (and keep trying to fix
things like this), or is the code in libnet_vampire. enough for the
testing now?

Andrew Bartlett
--
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

[Stefan (metze) Metzmacher]

Andrew Bartlett schrieb:

> Metze,
>
> I was over the past few days been trying to debug issues around DRSUAPI,
> and it seem that the tsocket changes have broken the NET-API-BECOMEDC
> test.
>
> tsocket does not allow the getaddrinfo() call to do DNS lookups, and
> this is required by the way this code is called by smbtorture.
>
> For some reason the net/vampire got manages to do the address resolution
> at the right point.  
>
> Should we keep the torture variant of this code (and keep trying to fix
> things like this), or is the code in libnet_vampire. enough for the
> testing now?

I think we should keep it.
This patch should easily fix it:

http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=d04f113b21e71ef5b044007fce806a1681d9a7fd

metze