Need reviewer - Fixing demo/jvmti tests and correcting problem list

View: New views
3 Messages — Rating Filter:   Alert me  

Need reviewer - Fixing demo/jvmti tests and correcting problem list

by Kelly O'Hair :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Need reviewer:

6899444: Fix demo/jvmti tests so they can run in jtreg samevm mode, cleanup problemlist
http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-samevm-6899444/webrev/

Fixed the demo/jvmti tests so they work in samevm mode (samevm
mode changes the current directory setting), and removed them from
the problem list.

Also removed some jdi tests from the problem list (Tim fixed them earlier).

-kto


Re: Need reviewer - Fixing demo/jvmti tests and correcting problem list

by tim.bell :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Kelly O'Hair wrote:
> Need reviewer:
>
> 6899444: Fix demo/jvmti tests so they can run in jtreg samevm mode, cleanup problemlist
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-samevm-6899444/webrev/

Looks good to me.

> Fixed the demo/jvmti tests so they work in samevm mode (samevm
> mode changes the current directory setting), and removed them from
> the problem list.
>
> Also removed some jdi tests from the problem list (Tim fixed them earlier).

Thanks - the jdk/test/com/sun/jdi/ShellScaffold.sh issue was fixed in 6787605
and later fixed for good in 6893426.  Both are already in TL for b77.

Tim

Re: Need reviewer - Fixing demo/jvmti tests and correcting problem list

by alan.bateman :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Kelly O'Hair wrote:

>
> Need reviewer:
>
> 6899444: Fix demo/jvmti tests so they can run in jtreg samevm mode,
> cleanup problemlist
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-samevm-6899444/webrev/
>
> Fixed the demo/jvmti tests so they work in samevm mode (samevm
> mode changes the current directory setting), and removed them from
> the problem list.
>
> Also removed some jdi tests from the problem list (Tim fixed them
> earlier).
>
> -kto
>
Looks good to me.

-Alan