Need reviewer for 6894633: NetHooks hould not require provider to be present (sol)

[Alan Bateman]

I need a reviewer for a small fix to sun.net.NetHooks. On Solaris, the
code incorrectly assumes that the sdp provider is always present. The
loadProvider method should return null if not present. The diffs are
attached.

Thanks,
Alan.


--- a/src/solaris/classes/sun/net/NetHooks.java
+++ b/src/solaris/classes/sun/net/NetHooks.java
@@ -81,7 +81,7 @@ public final class NetHooks {
                     try {
                         c = (Class<Provider>)Class.forName(cn, true, null);
                     } catch (ClassNotFoundException x) {
-                        throw new AssertionError(x);
+                        return null;
                     }
                     try {
                         return c.newInstance();

[Christopher Hegarty -Sun Microsystems Ireland]

The changes look fine.

-Chris.

On 23/10/2009 14:57, Alan Bateman wrote:

>
> I need a reviewer for a small fix to sun.net.NetHooks. On Solaris, the
> code incorrectly assumes that the sdp provider is always present. The
> loadProvider method should return null if not present. The diffs are
> attached.
>
> Thanks,
> Alan.
>
>
> --- a/src/solaris/classes/sun/net/NetHooks.java
> +++ b/src/solaris/classes/sun/net/NetHooks.java
> @@ -81,7 +81,7 @@ public final class NetHooks {
>                     try {
>                         c = (Class<Provider>)Class.forName(cn, true, null);
>                     } catch (ClassNotFoundException x) {
> -                        throw new AssertionError(x);
> +                        return null;
>                     }
>                     try {
>                         return c.newInstance();
>

[Jean-Christophe Collet]

Christopher Hegarty - Sun Microsystems Ireland wrote:
> The changes look fine.
>

Same here. Looks fine.

> -Chris.
>
> On 23/10/2009 14:57, Alan Bateman wrote:
>>
>> I need a reviewer for a small fix to sun.net.NetHooks. On Solaris,
>> the code incorrectly assumes that the sdp provider is always present.
>> The loadProvider method should return null if not present. The diffs
>> are attached.
>>
>> Thanks,
>> Alan.
>>
>>
>> --- a/src/solaris/classes/sun/net/NetHooks.java
>> +++ b/src/solaris/classes/sun/net/NetHooks.java
>> @@ -81,7 +81,7 @@ public final class NetHooks {
>>                     try {
>>                         c = (Class<Provider>)Class.forName(cn, true,
>> null);
>>                     } catch (ClassNotFoundException x) {
>> -                        throw new AssertionError(x);
>> +                        return null;
>>                     }
>>                     try {
>>                         return c.newInstance();
>>