Need reviewer for 6896829: test/sun/util/logging/PlatformLoggerTest.java needs @compile tag to be compiled by jtreg

[alan.bateman]

I need a reviewer for a tiny change to a test that fails to compile as
it uses sun.* APIs. The fix is to replace the @build tag with the
@compile tag and specify that the symbol file used by javac be ignored.
Diffs attached.

Thanks,
Alan.

diff -r 84ae559f7129 test/sun/util/logging/PlatformLoggerTest.java
--- a/test/sun/util/logging/PlatformLoggerTest.java     Fri Oct 30
15:06:24 2009 +0000
+++ b/test/sun/util/logging/PlatformLoggerTest.java     Fri Oct 30
21:19:50 2009 +0000
@@ -28,7 +28,7 @@
  *          logging is enabled.  Also validate some basic PlatformLogger
  *          operations.
  *
- * @build PlatformLoggerTest
+ * @compile -XDignore.symbol.file PlatformLoggerTest.java
  * @run main PlatformLoggerTest
  */

[mandy.chung]

Looks good.  Thanks for taking care of this fix.
Mandy

Alan Bateman wrote:

> I need a reviewer for a tiny change to a test that fails to compile as
> it uses sun.* APIs. The fix is to replace the @build tag with the
> @compile tag and specify that the symbol file used by javac be
> ignored. Diffs attached.
>
> Thanks,
> Alan.
>
> diff -r 84ae559f7129 test/sun/util/logging/PlatformLoggerTest.java
> --- a/test/sun/util/logging/PlatformLoggerTest.java     Fri Oct 30
> 15:06:24 2009 +0000
> +++ b/test/sun/util/logging/PlatformLoggerTest.java     Fri Oct 30
> 21:19:50 2009 +0000
> @@ -28,7 +28,7 @@
>  *          logging is enabled.  Also validate some basic PlatformLogger
>  *          operations.
>  *
> - * @build PlatformLoggerTest
> + * @compile -XDignore.symbol.file PlatformLoggerTest.java
>  * @run main PlatformLoggerTest
>  */
>
>
>
>

[tim.bell]

Alan Bateman wrote:
> I need a reviewer for a tiny change to a test that fails to compile as
> it uses sun.* APIs. The fix is to replace the @build tag with the
> @compile tag and specify that the symbol file used by javac be ignored.

Looks good to me.  Approved!

Quite a few tests under jdk/test are already using this.

Tim

> Diffs attached.
>
> Thanks,
> Alan.
>
> diff -r 84ae559f7129 test/sun/util/logging/PlatformLoggerTest.java
> --- a/test/sun/util/logging/PlatformLoggerTest.java     Fri Oct 30
> 15:06:24 2009 +0000
> +++ b/test/sun/util/logging/PlatformLoggerTest.java     Fri Oct 30
> 21:19:50 2009 +0000
> @@ -28,7 +28,7 @@
>   *          logging is enabled.  Also validate some basic PlatformLogger
>   *          operations.
>   *
> - * @build PlatformLoggerTest
> + * @compile -XDignore.symbol.file PlatformLoggerTest.java
>   * @run main PlatformLoggerTest
>   */