New Test class detection broken

[Steve Appling]

The new JUnit test class detection doesn't handle classes that extend a helper
class that extend TestCase.  Also, it uses the new test class detection by
default even if you explicitly specify includes.  You have to add
"scanForTestClasses=false" to get tests working again.

I added a Jira for this (GRADLE-493), but thought I would bring it up here too
so it could be addressed quickly.  This seemed like a 0.6.1 bug to me.  The
title of this Jira issue needs to be fixed, but I couldn't see how to edit it
after submission - sorry :(

BTW, do you not typically have release candidate builds to catch these types of
issues before you make a release?  While I am happy that 0.6 is out, I was a
little surprised that there wasn't a release candidate where people could
exercise some of the new features some before it was officially released.

--
Steve Appling
Automated Logic Research Team

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[Tom Eyckmans]

Hi Steve,

2009/5/21 Steve Appling <sajakarta@...>

The new JUnit test class detection doesn't handle classes that extend a helper class that extend TestCase.  

This should work, the only limitation here is that the test class detection doesn't scan into jar files, so if your test classes inherit from a class that is available in a jar file it will not be scanned. We do plan to add this in an upcoming release. I didn't mention this limitation in the documentation yet, so I've added it.
 

Also, it uses the new test class detection by default even if you explicitly specify includes.  You have to add "scanForTestClasses=false" to get tests working again.

 

That is indeed the way that it is supposed to work. Otherwise you can't execute a subset of the tests if you don't depend on test class naming conventions.
 

I added a Jira for this (GRADLE-493), but thought I would bring it up here too so it could be addressed quickly.     

This seemed like a 0.6.1 bug to me.  The title of this Jira issue needs to be fixed, but I couldn't see how to edit it after submission - sorry :( 

Depending on the source of the parent class I'll update the jira issue.

BTW, do you not typically have release candidate builds to catch these types of issues before you make a release?  

Normally features are indeed available in trunk for a while before we release.
 

While I am happy that 0.6 is out, I was a little surprised that there wasn't a release candidate where people could exercise some of the new features some before it was officially released.

Sorry for the inconvenience, we will pay more attention to this in the future.

--
Steve Appling
Automated Logic Research Team

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

  http://xircles.codehaus.org/manage_email

[Steve Appling]

Tom Eyckmans wrote:

> Hi Steve,
>
> 2009/5/21 Steve Appling <sajakarta@...
> <mailto:sajakarta@...>>
>
>     The new JUnit test class detection doesn't handle classes that
>     extend a helper class that extend TestCase.  
>
>
> This should work, the only limitation here is that the test class
> detection doesn't scan into jar files, so if your test classes inherit
> from a class that is available in a jar file it will not be scanned. We
> do plan to add this in an upcoming release. I didn't mention this
> limitation in the documentation yet, so I've added it.
>  

Thanks for clearing this up for me Tom.  This probably won't be much of an issue
for people with a single project, but in multi-project builds, I think it may be
common to have a testing library that is shared across multiple projects.  We
would love to be able to use this new feature when this issues is resolved.

--
Steve Appling
Automated Logic Research Team

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[Tom Eyckmans]

2009/5/22 Steve Appling <sajakarta@...>

Tom Eyckmans wrote:

Hi Steve,

2009/5/21 Steve Appling <sajakarta@... <mailto:sajakarta@...>>

   The new JUnit test class detection doesn't handle classes that
   extend a helper class that extend TestCase.  

This should work, the only limitation here is that the test class detection doesn't scan into jar files, so if your test classes inherit from a class that is available in a jar file it will not be scanned. We do plan to add this in an upcoming release. I didn't mention this limitation in the documentation yet, so I've added it.
 

Thanks for clearing this up for me Tom.  This probably won't be much of an issue for people with a single project, but in multi-project builds, I think it may be common to have a testing library that is shared across multiple projects.  We would love to be able to use this new feature when this issues is resolved.

I've added some logic to the test class detection so it scans in jar files, it is available in trunk, if you can please give it a try.

--
Steve Appling
Automated Logic Research Team

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

  http://xircles.codehaus.org/manage_email

[Steve Appling]

Tom Eyckmans wrote:
>
> I've added some logic to the test class detection so it scans in jar
> files, it is available in trunk, if you can please give it a try.

That seems to work well.  Thanks for a quick fix!

--
Steve Appling
Automated Logic Research Team

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email