OGLGraphicsConfig

[Mario Torre-4]

Hi all!

Is there any reason why sun.java2d.OGLGraphicsConfig is not public?

I would like to make it public so that I can have some more ways to
reuse the code in the OpenGL pipeline, for example by having an EGL
based implementation that doesn't depend on X11 at all.

Of course, I could use a sun.java2d package name but I guess it would be
nicer/more legal to have this interface public in the first place.

The sun.java2d package is internal anyway, so compatibilty/public API
preservation should not matter here. Should I propose the patch or just
fix my package naming conventions to use sun.java2d?

Cheers,
Mario
--
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: [phone]
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Geschäftsführer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/

[Chris Campbell-5]

It's package-private because it's only accessed within the  
sun.java2d.opengl package, and in general we strive to reduce the  
visibility of classes/interfaces.  The concrete GLX/WGL  
implementations also live in that package, so there was no reason to  
make it public.

There's probably no harm in making that interface public.  If you want  
to submit a patch, feel free.

Thanks,
Chris


On Oct 7, 2009, at 8:19 AM, Mario Torre wrote:

> Hi all!
>
> Is there any reason why sun.java2d.OGLGraphicsConfig is not public?
>
> I would like to make it public so that I can have some more ways to  
> reuse the code in the OpenGL pipeline, for example by having an EGL  
> based implementation that doesn't depend on X11 at all.
>
> Of course, I could use a sun.java2d package name but I guess it  
> would be nicer/more legal to have this interface public in the first  
> place.
>
> The sun.java2d package is internal anyway, so compatibilty/public  
> API preservation should not matter here. Should I propose the patch  
> or just fix my package naming conventions to use sun.java2d?
>
> Cheers,
> Mario
> --
> Mario Torre, Software Developer, http://www.jroller.com/neugens/
> aicas Allerton Interworks Computer Automated Systems GmbH
> Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
> http://www.aicas.com   * Tel: [phone]
> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
> Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF
>
> USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
> Geschäftsführer: Dr. James J. Hunt
>
> Please, support open standards:
> http://endsoftpatents.org/
>

[Mario Torre-4]

Il 07/10/2009 19:07, Chris Campbell ha scritto:

> It's package-private because it's only accessed within the
> sun.java2d.opengl package, and in general we strive to reduce the
> visibility of classes/interfaces. The concrete GLX/WGL implementations
> also live in that package, so there was no reason to make it public.
>
> There's probably no harm in making that interface public. If you want to
> submit a patch, feel free.
>
> Thanks,
> Chris

Hi Chris,

Very simple one:

http://cr.openjdk.java.net/~neugens/oglpipeline/webrev.00/

Cheers,
Mario
--
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: [phone]
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Geschäftsführer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/