Outdated quartz page on grails.org

View: New views
6 Messages — Rating Filter:   Alert me  

Outdated quartz page on grails.org

by TTop-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Google's first hit for "grails quartz" is an outdated page (http://www.grails.org/Quartz+plugin) which contains bad information (Quartz doesn't work using the triggers example on that page). It'd be great if the site maintainer could redirect this to the current correct plugin page. Which might be http://www.grails.org/plugin/quartz or http://grails.org/Job+Scheduling+%28Quartz%29 -- it's hard to say.


Re: Outdated quartz page on grails.org

by j pimmel :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Yeah, i had to look at the quartz plugin source to figure out that the 'simple' has become 'simpleTrigger', 'cron' -> 'cronTrigger' etc..

On Wed, Nov 4, 2009 at 9:55 AM, Todd Wells <ttopwells@...> wrote:
Google's first hit for "grails quartz" is an outdated page (http://www.grails.org/Quartz+plugin) which contains bad information (Quartz doesn't work using the triggers example on that page). It'd be great if the site maintainer could redirect this to the current correct plugin page. Which might be http://www.grails.org/plugin/quartz or http://grails.org/Job+Scheduling+%28Quartz%29 -- it's hard to say.




--
"We are all agreed that your theory is crazy. The question that divides us is whether it is crazy enough to have a chance of being correct."  -  Dr. Niels Bohr

### Craft @ http://www.linkedin.com/in/jpimmel
###  Vox @ http://act.ualise.com/blogs/continuous-innovation
###  Twit @ http://twitter.com/franklywatson

Re: Outdated quartz page on grails.org

by John Fletcher-12 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I'm not so sure.

I was wondering why my jobs weren't working, I thought this might be the reason so I updated the page you mentioned with a notice at the top and a link to the newer page, specially constructed with some nice keywords to encourage Skynet to put the newer page at the top of the search results in future.

However having done that, I tested your suggestions with version 0.4.1 and when I try using "cronTrigger" I get deprecated warnings.

2009-11-05 11:21:44,394 [main] WARN  util.GrailsUtil  - [DEPRECATED] You're using deprecated 'cronTrigger' construction in the test.MyJob, use 'cron' instead.

2009-11-05 11:09:34,201 [Thread-1] WARN  util.GrailsUtil  - [DEPRECATED] You're using deprecated 'def cronExpression = ...' parameter in the test.MyJob, use 'static triggers = { cron cronExpression: ...} instead.

What were your problems with the "cron" syntax? If it threw exceptions you probably experienced the problem detailed here http://jira.codehaus.org/browse/GRAILSPLUGINS-1281 and could use the workaround described in the comments (worked for me).

John

2009/11/4 j pimmel <frankly.watson@...>
Yeah, i had to look at the quartz plugin source to figure out that the 'simple' has become 'simpleTrigger', 'cron' -> 'cronTrigger' etc..

On Wed, Nov 4, 2009 at 9:55 AM, Todd Wells <ttopwells@...> wrote:
Google's first hit for "grails quartz" is an outdated page (http://www.grails.org/Quartz+plugin) which contains bad information (Quartz doesn't work using the triggers example on that page). It'd be great if the site maintainer could redirect this to the current correct plugin page. Which might be http://www.grails.org/plugin/quartz or http://grails.org/Job+Scheduling+%28Quartz%29 -- it's hard to say.




Re: Outdated quartz page on grails.org

by HansB :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi All,

> Yeah, i had to look at the quartz plugin source to figure out that the
> 'simple' has become 'simpleTrigger', 'cron' -> 'cronTrigger' etc..

When I look at the source code, I come to a different conclusion.
In org.codehaus.groovy.grails.plugins.quartz.config.TriggersConfigBuilder (under src/groovy), the lines 81-90 show that the '.*Trigger' versions are the deprecated form.

The examples don't work due to http://jira.codehaus.org/browse/GRAILSPLUGINS-1281  (or http://jira.codehaus.org/browse/GRAILSPLUGINS-1461 which is the duplicate of the first).
I have updated #1461 with a commentary with a partial fix.

The real problem is in the java code of the plugin:
In org.codehaus.groovy.grails.plugins.quartz.CustomTriggerFactoryBean.afterPropertiesSet(CustomTriggerFactoryBean.java:42) there is the line:
customTriggerWrapper.setPropertyValues(triggerAttributes);

triggerAttributes is filled by Groovy code and may contain GString objects. Spring can't handle those, so they should be converted.

This leads me to a question for the Grails/Groovy guru's:
Is there something available to plugins to do this conversion or should the plugin writer create something for it?
I would expect something to be available (DRY, CoC, etc), but I haven't found anything so far...

--
Regards
Hans Bogaards
TA Team
The Netherlands



---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email



Re: Outdated quartz page on grails.org

by j pimmel :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Maybe you are right, though I am using the 0.4.1 snapshot which seems not to complain.

The TriggersConfigBuilder source for the version in question reflects what my experience was

http://plugins.grails.org/grails-quartz/tags/RELEASE_0_4_1-SNAPSHOT/src/groovy/org/codehaus/groovy/grails/plugins/quartz/config/TriggersConfigBuilder.groovy

I couldnt get it working without the Trigger suffix .. i ended up break-pointing in the debugger right into the plugin code and saw that i needed to add nnnnTrigger..  I was getting exception Invalid Format without the trigger suffix

who knows, i dont mind.. it works for what i need.. just seems a bit confusing

On Thu, Nov 5, 2009 at 2:30 AM, John Fletcher <fletchgqc@...> wrote:
I'm not so sure.

I was wondering why my jobs weren't working, I thought this might be the reason so I updated the page you mentioned with a notice at the top and a link to the newer page, specially constructed with some nice keywords to encourage Skynet to put the newer page at the top of the search results in future.

However having done that, I tested your suggestions with version 0.4.1 and when I try using "cronTrigger" I get deprecated warnings.

2009-11-05 11:21:44,394 [main] WARN  util.GrailsUtil  - [DEPRECATED] You're using deprecated 'cronTrigger' construction in the test.MyJob, use 'cron' instead.

2009-11-05 11:09:34,201 [Thread-1] WARN  util.GrailsUtil  - [DEPRECATED] You're using deprecated 'def cronExpression = ...' parameter in the test.MyJob, use 'static triggers = { cron cronExpression: ...} instead.

What were your problems with the "cron" syntax? If it threw exceptions you probably experienced the problem detailed here http://jira.codehaus.org/browse/GRAILSPLUGINS-1281 and could use the workaround described in the comments (worked for me).

John

2009/11/4 j pimmel <frankly.watson@...>

Yeah, i had to look at the quartz plugin source to figure out that the 'simple' has become 'simpleTrigger', 'cron' -> 'cronTrigger' etc..

On Wed, Nov 4, 2009 at 9:55 AM, Todd Wells <ttopwells@...> wrote:
Google's first hit for "grails quartz" is an outdated page (http://www.grails.org/Quartz+plugin) which contains bad information (Quartz doesn't work using the triggers example on that page). It'd be great if the site maintainer could redirect this to the current correct plugin page. Which might be http://www.grails.org/plugin/quartz or http://grails.org/Job+Scheduling+%28Quartz%29 -- it's hard to say.






--
"We are all agreed that your theory is crazy. The question that divides us is whether it is crazy enough to have a chance of being correct."  -  Dr. Niels Bohr

### Craft @ http://www.linkedin.com/in/jpimmel
###  Vox @ http://act.ualise.com/blogs/continuous-innovation
###  Twit @ http://twitter.com/franklywatson

Re: Outdated quartz page on grails.org

by j pimmel :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Looking here I can see what you guys are saying

http://plugins.grails.org/grails-quartz/tags/LATEST_RELEASE/src/groovy/org/codehaus/groovy/grails/plugins/quartz/config/TriggersConfigBuilder.groovy

and that the latest release is 0.4.1

so i guess snapshot is some older past dated version - some google search yielded some info about the 0.4.1-SNAPSHOT being latest, so obviously that result was dated.. sometimes these thing aren't totally obvious

On Sat, Nov 7, 2009 at 6:44 PM, j pimmel <frankly.watson@...> wrote:
Maybe you are right, though I am using the 0.4.1 snapshot which seems not to complain.

The TriggersConfigBuilder source for the version in question reflects what my experience was

http://plugins.grails.org/grails-quartz/tags/RELEASE_0_4_1-SNAPSHOT/src/groovy/org/codehaus/groovy/grails/plugins/quartz/config/TriggersConfigBuilder.groovy

I couldnt get it working without the Trigger suffix .. i ended up break-pointing in the debugger right into the plugin code and saw that i needed to add nnnnTrigger..  I was getting exception Invalid Format without the trigger suffix

who knows, i dont mind.. it works for what i need.. just seems a bit confusing


On Thu, Nov 5, 2009 at 2:30 AM, John Fletcher <fletchgqc@...> wrote:
I'm not so sure.

I was wondering why my jobs weren't working, I thought this might be the reason so I updated the page you mentioned with a notice at the top and a link to the newer page, specially constructed with some nice keywords to encourage Skynet to put the newer page at the top of the search results in future.

However having done that, I tested your suggestions with version 0.4.1 and when I try using "cronTrigger" I get deprecated warnings.

2009-11-05 11:21:44,394 [main] WARN  util.GrailsUtil  - [DEPRECATED] You're using deprecated 'cronTrigger' construction in the test.MyJob, use 'cron' instead.

2009-11-05 11:09:34,201 [Thread-1] WARN  util.GrailsUtil  - [DEPRECATED] You're using deprecated 'def cronExpression = ...' parameter in the test.MyJob, use 'static triggers = { cron cronExpression: ...} instead.

What were your problems with the "cron" syntax? If it threw exceptions you probably experienced the problem detailed here http://jira.codehaus.org/browse/GRAILSPLUGINS-1281 and could use the workaround described in the comments (worked for me).

John

2009/11/4 j pimmel <frankly.watson@...>

Yeah, i had to look at the quartz plugin source to figure out that the 'simple' has become 'simpleTrigger', 'cron' -> 'cronTrigger' etc..

On Wed, Nov 4, 2009 at 9:55 AM, Todd Wells <ttopwells@...> wrote:
Google's first hit for "grails quartz" is an outdated page (http://www.grails.org/Quartz+plugin) which contains bad information (Quartz doesn't work using the triggers example on that page). It'd be great if the site maintainer could redirect this to the current correct plugin page. Which might be http://www.grails.org/plugin/quartz or http://grails.org/Job+Scheduling+%28Quartz%29 -- it's hard to say.






--
"We are all agreed that your theory is crazy. The question that divides us is whether it is crazy enough to have a chance of being correct."  -  Dr. Niels Bohr

### Craft @ http://www.linkedin.com/in/jpimmel
###  Vox @ http://act.ualise.com/blogs/continuous-innovation
###  Twit @ http://twitter.com/franklywatson



--
"We are all agreed that your theory is crazy. The question that divides us is whether it is crazy enough to have a chance of being correct."  -  Dr. Niels Bohr

### Craft @ http://www.linkedin.com/in/jpimmel
###  Vox @ http://act.ualise.com/blogs/continuous-innovation
###  Twit @ http://twitter.com/franklywatson