WARNING: This server is unstable and will be retired in the next days. If you want to keep this forum available, please request immediately a migration on the Nabble Support forum. Forums that don't receive any migration request will be deleted forever.

 « Return to Thread: PATCH: PR ld/14272: Mark the plugin symbol undefined

PATCH: PR ld/14272: Mark the plugin symbol undefined

by H.J. Lu :: Rate this Message:

| View in Thread

Hi,

LTO may optimize out a plugin symbol, which is also referenced by a
non-IR file.  When that happens, we should mark the plugin symbol
undefined.  It isn't the problem since LTO already determined the
symbols in the non-IR file aren't used.  OK to install?

Thanks.


H.J.
---
2012-06-28  H.J. Lu  <hongjiu.lu@...>

        PR ld/14272
        * elflink.c (_bfd_elf_fix_symbol_flags): Mark the plugin symbol
        undefined if it is referenced from a non-IR file.

diff --git a/bfd/elflink.c b/bfd/elflink.c
index 8fb2ae3..4a0f858 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -2451,6 +2451,18 @@ _bfd_elf_fix_symbol_flags (struct elf_link_hash_entry *h,
     }
   else
     {
+      /* If a plugin symbol is referenced from a non-IR file, mark
+ the symbol as undefined.  */        
+      if (h->root.non_ir_ref
+  && (h->root.type == bfd_link_hash_defined
+      || h->root.type == bfd_link_hash_defweak)
+  && h->root.u.def.section->owner != NULL
+  && (h->root.u.def.section->owner->flags & BFD_PLUGIN) != 0)
+ {
+  h->root.type = bfd_link_hash_undefined;
+  h->root.u.undef.abfd = h->root.u.def.section->owner;
+ }
+
       /* Unfortunately, NON_ELF is only correct if the symbol
  was first seen in a non-ELF file.  Fortunately, if the symbol
  was first seen in an ELF file, we're probably OK unless the

 « Return to Thread: PATCH: PR ld/14272: Mark the plugin symbol undefined