Patch: Export

View: New views
4 Messages — Rating Filter:   Alert me  

Patch: Export

by Uwe Bonnes :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello,

to allow fine-grained Can Filter/Mask settings, AtCanEnableMsgObj() needs to
be exported. A note that more then RX_MOB MOBs can be set up is added.

Bye
--
Uwe Bonnes                bon@...

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
Index: nut/include/dev/atcan.h
===================================================================
--- nut/include/dev/atcan.h (Revision 2740)
+++ nut/include/dev/atcan.h (Arbeitskopie)
@@ -73,6 +73,10 @@
 
 int8_t AtCanGetBusState(void);
 
+int8_t AtCanEnableMsgObj(uint8_t mob,
+                         uint32_t id, int8_t idIsExt, int8_t idRemTag,
+                         uint32_t mask, int8_t maskIsExt, int8_t maskRemTag);
+
 int8_t AtCanEnableRx(uint8_t noOfMsgObjs,
                      uint32_t id, int8_t idIsExt, int8_t idRemTag,
                      uint32_t mask, int8_t maskIsExt, int8_t maskRemTag);
Index: nut/arch/avr/dev/atcan.c
===================================================================
--- nut/arch/avr/dev/atcan.c (Revision 2740)
+++ nut/arch/avr/dev/atcan.c (Arbeitskopie)
@@ -302,6 +302,8 @@
 /**
  * Configure a single message object for receiption.
  *
+ * All 15 MOBS can be set up for reception,  not only RX_MOB MOBs
+ *
  * @param mob        Message object index (0-14)
  * @param id         Acceptance code
  * @param idIsExt    Flag if acceptance code is extended (0 = standard, 1 = extended)
_______________________________________________
http://lists.egnite.de/mailman/listinfo/en-nut-discussion

Re: Patch: Export

by Uwe Bonnes :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

>>>>> "Uwe" == Uwe Bonnes <bon@...> writes:

    Uwe> Hello, to allow fine-grained Can Filter/Mask settings,
    Uwe> AtCanEnableMsgObj() needs to be exported. A note that more then
    Uwe> RX_MOB MOBs can be set up is added.

Is this patch invalid?

I don't find it applied to current SVN.
--
Uwe Bonnes                bon@...

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
_______________________________________________
http://lists.egnite.de/mailman/listinfo/en-nut-discussion

Re: Patch: Export

by Ethernut :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Uwe Bonnes wrote:

> Is this patch invalid?
>
> I don't find it applied to current SVN.

To all:

While the missing patch to lanc111.c was my fault, I'm wondering, why
nothing happened on this one. We have a quite large number of people
with SVN write access, right?

I've no idea what your patch actually does, because I don't know much
about CAN. Anyway, I'll commit it.

Harald
_______________________________________________
http://lists.egnite.de/mailman/listinfo/en-nut-discussion

Re: Patch: Export

by Ole Reinhardt-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Harald,

> To all:
>
> While the missing patch to lanc111.c was my fault, I'm wondering, why
> nothing happened on this one. We have a quite large number of people
> with SVN write access, right?

Right. Indeed, I've read this patch, bus as I don't use the AT90CAN I
did not know what this patch does either... so I left this patch open
for Henrik who wrote this driver... At least it seems that this patch
won't hurd as it's just a function prototype to be exported...

Bye,

Ole

--
 _____________________________________________________________
|                                                             |
| Embedded-IT                                                 |
|                                                             |
| Ole Reinhardt        Tel. / Fax:        +49 (0)271  7420433 |
| Luisenstraße 29      Mobil:             +49 (0)177  7420433 |
| 57076 Siegen         eMail:    ole.reinhardt@... |
| Germany              Web:         http://www.embedded-it.de |
|_____________________________________________________________|

_______________________________________________
http://lists.egnite.de/mailman/listinfo/en-nut-discussion