Patch: smsc_smpp.c

[Nikos Balkanas]

Some parts of this message have been removed. Learn more about Nabble's security policy.

Hi,

 

This is another one in my series of trivial patches. This part of the configuration has caused a lot of confusion in manual configuring dest-addr-ton over the years, with users prefixing their numbers with '+' instead of using the configuration.

 

BR,

Nikos

[Alexander Malysh]

Hi,

I don't see reason to apply this patch. User can just define ton and npi settings. Maybe userguide patch

would be more helpful?

Thanks,

Alexander Malysh

Am 02.11.2009 um 12:31 schrieb Nikos Balkanas:

Hi,

 

This is another one in my series of trivial patches. This part of the configuration has caused a lot of confusion in manual configuring dest-addr-ton over the years, with users prefixing their numbers with '+' instead of using the configuration.

 

BR,

Nikos

<smsc_smpp.diff>

[Nikos Balkanas-2]

Some parts of this message have been removed. Learn more about Nabble's security policy.

Hi,

 

I don't see a reason to keep these variables bundled. ton is more frequently changed. npi almost never does. They mean different things, and are independent of each other. Why not give user the choice to set whatever they need in configuration? Same holds for source-addr-ton & npi.

 

I think it makes more sense to patch the source. In either case if you decide to go with the guide, I can submit that as well. One of the two has to be patche, though.

 

BR,

Nikos

----- Original Message -----

From: amalysh@...

To: nbalkanas@...

Cc: devel@...

Sent: Monday, November 09, 2009 11:32 AM

Subject: Re: Patch: smsc_smpp.c

Hi,

I don't see reason to apply this patch. User can just define ton and npi settings. Maybe userguide patch

would be more helpful?

Thanks,

Alexander Malysh

Am 02.11.2009 um 12:31 schrieb Nikos Balkanas:

Hi,

 

This is another one in my series of trivial patches. This part of the configuration has caused a lot of confusion in manual configuring dest-addr-ton over the years, with users prefixing their numbers with '+' instead of using the configuration.

 

BR,

Nikos

<smsc_smpp.diff>

[Alexander Malysh]

Hi,

AFAIK ton and npi always bundled together. Therefore I don't see reason to define only one value...

Thanks,

Alexander Malysh

Am 09.11.2009 um 10:54 schrieb Nikos Balkanas:

Hi,

 

I don't see a reason to keep these variables bundled. ton is more frequently changed. npi almost never does. They mean different things, and are independent of each other. Why not give user the choice to set whatever they need in configuration? Same holds for source-addr-ton & npi.

 

I think it makes more sense to patch the source. In either case if you decide to go with the guide, I can submit that as well. One of the two has to be patche, though.

 

BR,

Nikos

----- Original Message -----

From: amalysh@...

To: nbalkanas@...

Cc: devel@...

Sent: Monday, November 09, 2009 11:32 AM

Subject: Re: Patch: smsc_smpp.c

Hi,

I don't see reason to apply this patch. User can just define ton and npi settings. Maybe userguide patch

would be more helpful?

Thanks,

Alexander Malysh

Am 02.11.2009 um 12:31 schrieb Nikos Balkanas:

Hi,

 

This is another one in my series of trivial patches. This part of the configuration has caused a lot of confusion in manual configuring dest-addr-ton over the years, with users prefixing their numbers with '+' instead of using the configuration.

 

BR,

Nikos

<smsc_smpp.diff>

[Nikos Balkanas-2]

Some parts of this message have been removed. Learn more about Nabble's security policy.

Hi,

 

Actually they are not. bind-addr-ton & bind-addr-npi in smpp are set indepedently. dest-addr-ton & source-addr-ton in smasi (the only other smsc using them) are also set independently. Lastly whether the phone number is international, national, or subscriber (ton) seems to me bears little relation to whether to circuit is ISDN, Hermes or Telex (npi).

 

I attach also userguide patch. Now you have both patches. Please apply whichever you consider most appropriate.

 

BR,

Nikos

----- Original Message -----

From: amalysh@...

To: nbal@...

Cc: devel@...

Sent: Monday, November 09, 2009 12:21 PM

Subject: Re: Patch: smsc_smpp.c

Hi,

AFAIK ton and npi always bundled together. Therefore I don't see reason to define only one value...

Thanks,

Alexander Malysh

Am 09.11.2009 um 10:54 schrieb Nikos Balkanas:

Hi,

 

I don't see a reason to keep these variables bundled. ton is more frequently changed. npi almost never does. They mean different things, and are independent of each other. Why not give user the choice to set whatever they need in configuration? Same holds for source-addr-ton & npi.

 

I think it makes more sense to patch the source. In either case if you decide to go with the guide, I can submit that as well. One of the two has to be patche, though.

 

BR,

Nikos

----- Original Message -----

From: amalysh@...

To: nbalkanas@...

Cc: devel@...

Sent: Monday, November 09, 2009 11:32 AM

Subject: Re: Patch: smsc_smpp.c

Hi,

I don't see reason to apply this patch. User can just define ton and npi settings. Maybe userguide patch

would be more helpful?

Thanks,

Alexander Malysh

Am 02.11.2009 um 12:31 schrieb Nikos Balkanas:

Hi,

 

This is another one in my series of trivial patches. This part of the configuration has caused a lot of confusion in manual configuring dest-addr-ton over the years, with users prefixing their numbers with '+' instead of using the configuration.

 

BR,

Nikos

<smsc_smpp.diff>