Patch for #include <> to ""

View: New views
2 Messages — Rating Filter:   Alert me  

Patch for #include <> to ""

by Stephen F. Booth :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

In the taglib headers, the #include directives are mixed between using
#include <XXX> and #include "XXX". This should be standardized to use
"" for non-system headers. I've included a patch for the headers in
the taglib/ directory and friends, but not for those in the include/
directory since I believe that is auto-generated from the files in
taglib/.

Apologies for sending the patch to this list, but I wasn't sure with
the continued discussion of moving to git, etc, if the KDE bug tracker
was still applicable.

Stephen


_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel

includediff (16K) Download Attachment

Re: Patch for #include <> to ""

by Bugzilla from lalinsky@gmail.com :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, Oct 9, 2009 at 10:51 PM, Stephen F. Booth <me@...> wrote:
> In the taglib headers, the #include directives are mixed between using
> #include <XXX> and #include "XXX". This should be standardized to use
> "" for non-system headers. I've included a patch for the headers in
> the taglib/ directory and friends, but not for those in the include/
> directory since I believe that is auto-generated from the files in
> taglib/.

Thank you! The patch is committed in svn now.

> Apologies for sending the patch to this list, but I wasn't sure with
> the continued discussion of moving to git, etc, if the KDE bug tracker
> was still applicable.

Yes, it is.

--
Lukas Lalinsky
lalinsky@...
_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel