Patch to EBookBackendCache

[Jörgen Scheibengruber]

Hi,

here comes a patch for e-book-backend-cache.c. The method
e_book_backend_cache_set_time () currently allows you to set the
time exactly once, and will return failure later on. I don't
think this is intended behaviour --- at least it is not what
I would need in the google contacts backend. So this patch will
overwrite the old time-stamp when a new one is set instead.

PS: I'm not suscribed to the list ;-)

Br,
Jörgen

[e-book-backend-cache.diff]

---

Index: libedata-book/e-book-backend-cache.c
===================================================================
--- libedata-book/e-book-backend-cache.c (Revision 9341)
+++ libedata-book/e-book-backend-cache.c (Arbeitskopie)
@@ -499,7 +499,10 @@
 e_book_backend_cache_set_time (EBookBackendCache *cache, const char *t)
 {
  g_return_if_fail (E_IS_BOOK_BACKEND_CACHE (cache));
- e_file_cache_add_object (E_FILE_CACHE (cache), "last_update_time", t);
+ if (e_file_cache_get_object (E_FILE_CACHE (cache), "last_update_time"))
+ e_file_cache_replace_object (E_FILE_CACHE (cache), "last_update_time", t);
+ else
+ e_file_cache_add_object (E_FILE_CACHE (cache), "last_update_time", t);
 }
 
 char *

---

_______________________________________________
Evolution-patches mailing list
Evolution-patches@...
http://mail.gnome.org/mailman/listinfo/evolution-patches

[Srinivasa Ragavan]

Looks fine to commit.

Some how, it feels to me that e-file-cache (_replace) should be
intelligent to do all this. Since it already does, get_object. It can be
more efficient.

-Srini.

On Wed, 2008-08-13 at 23:12 +0300, Jörgen Scheibengruber wrote:

> Hi,
>
> here comes a patch for e-book-backend-cache.c. The method
> e_book_backend_cache_set_time () currently allows you to set the
> time exactly once, and will return failure later on. I don't
> think this is intended behaviour --- at least it is not what
> I would need in the google contacts backend. So this patch will
> overwrite the old time-stamp when a new one is set instead.
>
> PS: I'm not suscribed to the list ;-)
>
> Br,
> Jörgen
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches@...
> http://mail.gnome.org/mailman/listinfo/evolution-patches

_______________________________________________
Evolution-patches mailing list
Evolution-patches@...
http://mail.gnome.org/mailman/listinfo/evolution-patches

[Jörgen Scheibengruber]

Am Donnerstag, den 14.08.2008, 08:21 +0530 schrieb Srinivasa Ragavan:
> Looks fine to commit.
> Some how, it feels to me that e-file-cache (_replace) should be
> intelligent to do all this. Since it already does, get_object. It can be
> more efficient.

Indeed. I can also add "e_file_cache_add_or_replace_object"[1]?

Br,
Jörgen

[1] Better name welcome...

> -Srini.
>
> On Wed, 2008-08-13 at 23:12 +0300, Jörgen Scheibengruber wrote:
> > Hi,
> >
> > here comes a patch for e-book-backend-cache.c. The method
> > e_book_backend_cache_set_time () currently allows you to set the
> > time exactly once, and will return failure later on. I don't
> > think this is intended behaviour --- at least it is not what
> > I would need in the google contacts backend. So this patch will
> > overwrite the old time-stamp when a new one is set instead.
> >
> > PS: I'm not suscribed to the list ;-)
> >
> > Br,
> > Jörgen
> > _______________________________________________
> > Evolution-patches mailing list
> > Evolution-patches@...
> > http://mail.gnome.org/mailman/listinfo/evolution-patches
>
>

_______________________________________________
Evolution-patches mailing list
Evolution-patches@...
http://mail.gnome.org/mailman/listinfo/evolution-patches