Nabble - Php - Pear

[ANNOUNCEMENT] File_MARC-0.4.4 (beta) Released.

2009-12-17T12:29:44Z

The new PEAR package File_MARC-0.4.4 (beta) has been released at http://pear.php.net/.

Release notes
-------------
0.4.4-beta
* Enable MARCXML to handle bad tags, to match MARC
* Handle corner case where only one indicator might have been provided

Package Info
------------
The standard for machine-readable cataloging (MARC) records is documented at http://loc.gov/marc/. This package enables you to read existing MARC records from a file, string, or (using the YAZ extension), from a Z39.50 source. You can also use this package to create new MARC records.

This package is based on the PHP MARC package, originally called "php-marc", that is part of the Emilda Project (http://www.emilda.org). Christoffer Landtman generously agreed to make the "php-marc" code available under the GNU LGPL so it could be used as the basis of this PEAR package.

Related Links
-------------
Package home: http://pear.php.net/package/File_MARC
Changelog: http://pear.php.net/package/File_MARC/download/0.4.4
Download: http://download.pear.php.net/package/File_MARC-0.4.4.tgz

Authors
-------
Dan Scott <denials@...> (lead)

--
PEAR General Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - General

[PEPr] +1 for Web Services::Services_Digg2

2009-12-17T11:47:20Z

Matthew Fonda (http://pear.php.net/user/mfonda) has voted +1 on the proposal for Web Services::Services_Digg2.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=622
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=622&handle=mfonda

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

[PEPr] +1 for Authentication::OpenID

2009-12-17T11:47:14Z

Matthew Fonda (http://pear.php.net/user/mfonda) has voted +1 on the proposal for Authentication::OpenID.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=603
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=603&handle=mfonda

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

[PEAR-BUG] Doc #16920 [NEW]: Bad code sample for rethrowing exceptions in PEAR coding guide

2009-12-17T09:06:56Z

From: #186ac180883d4301c54
Operating system:
Package version:
PHP version: Irrelevant
Package: Documentation
Bug Type: Documentation Problem
Bug description: Bad code sample for rethrowing exceptions in PEAR coding guide

Description:
------------
On the page:

http://pear.php.net/manual/en/standards.errors.php

Section: "Rethrowing an exception"

The example code is missing the dollar sign in "catch (... e)"

and "throw new

...(..., e);", resulting in a parse error.

Also, these custom exceptions apparently support chaining, in

a way

incompatible with PHP 5.3's native support. This should

probably be noted,

or the sample updated.

P.S. Not that it matters, but the PHP version dropdown on the

bug report

form ends at 5.2.5, although the official release is up to 5.2.12

by now.

Expected result:
----------------
No errors (under E_STRICT|E_ALL as specified elsewhere in the

PEAR coding standards).

Actual result:
--------------
PHP Parse error: syntax error, unexpected T_STRING, expecting

T_VARIABLE in ...

--
Edit bug report at http://pear.php.net/bugs/bug.php?id=16920&edit=1
--

--
PEAR Documentation List Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Doc

Re: Re: [PEAR-QA] Re: [PEAR-DEV] Mail_Mime patches

2009-12-17T06:37:20Z

Daniel O'Connor wrote:

>> karma ahoy
> alec, give it a shot now

Some fixes commited. Maybe someone would like to give me karma in
bugtracker - tickets edition and roadmap assignments.

--
Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252
LAN Management System Developer http://lms.org.pl
Roundcube Webmail Developer http://roundcube.net

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: [PEAR-QA] Re: [PEAR-DEV] Mail_Mime patches

2009-12-16T22:27:46Z

On Thu, Dec 17, 2009 at 4:53 PM, Daniel O'Connor
<daniel.oconnor@...>wrote:

>
>
> On Thu, Dec 17, 2009 at 12:01 AM, Brett Bieber <brett.bieber@...>wrote:
>
>> On Wed, Dec 16, 2009 at 7:04 AM, till <klimpong@...> wrote:
>> > +1 from my side, hope someone adds your karma and we can move forward
>> > on this package.
>> >
>>
>> Have we heard anything yet from walter/cipri? Did I miss a +1 message from
>> them?
>>
>> The package is not marked as unmaintained, but we have patches waiting.
>>
>> Walter, Cipriano - how do these patches look, can we grant alec karma?
>>
>>
> http://marc.info/?l=pear-dev&m=126098478010870&w=2
>
> karma ahoy
>

alec, give it a shot now

From forum: Pear - Dev

Re: [PEAR-QA] Re: [PEAR-DEV] Mail_Mime patches

2009-12-16T22:23:38Z

On Thu, Dec 17, 2009 at 12:01 AM, Brett Bieber <brett.bieber@...>wrote:

> On Wed, Dec 16, 2009 at 7:04 AM, till <klimpong@...> wrote:
> > +1 from my side, hope someone adds your karma and we can move forward
> > on this package.
> >
>
> Have we heard anything yet from walter/cipri? Did I miss a +1 message from
> them?
>
> The package is not marked as unmaintained, but we have patches waiting.
>
> Walter, Cipriano - how do these patches look, can we grant alec karma?
>
>

http://marc.info/?l=pear-dev&m=126098478010870&w=2

karma ahoy

From forum: Pear - Dev

[PEPr] +1 for Web Services::Services_Digg2

2009-12-16T16:08:05Z

Ken Guest (http://pear.php.net/user/kguest) has voted +1 on the proposal for Web Services::Services_Digg2.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=622
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=622&handle=kguest

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

[PEPr] +1 for Authentication::OpenID

2009-12-16T16:07:42Z

Ken Guest (http://pear.php.net/user/kguest) has voted +1 on the proposal for Authentication::OpenID.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=603
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=603&handle=kguest

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

[PEPr] Changes in proposal for Images::Image_QRCode

2009-12-16T13:32:39Z

Rich Sage (http://pear.php.net/user/richsage) has edited the proposal for Images::Image_QRCode.

Change comment:

Package file updated with correct paths plus other changes as suggested on
pear-dev (thanks Brett!)

Please review the proposal:
http://pear.php.net/pepr/pepr-proposal-show.php?id=623

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: [PEPr] Comment on Images::Image_QRCode

2009-12-16T12:09:32Z

Hi Brett,

On Wed, Dec 16, 2009 at 8:59 PM, Brett Bieber <brett.bieber@...>wrote:

>
> A few suggestions:
> * I would declare the private variables as such, and use protected if
> possible.
> * The constructor should be named __construct since you're requiring PHP
> 5.
> * The first release should not be 1.0.0, maybe 0.1.0?
> * Have you tried installing the package and running it? The data files
> will not be placed into the same directory as the php files unless their
> role is php. Just be aware of this and either use an install-time
> replacement or find some other way to reference the files.
> * I'm not sure if some of the $options passed to makeCode could be made
> into constructor config options or not, for example, you can only set the
> image type in the makeCode() and not in the constructor which seems a bit
> odd since it's a member var of the class.
>
>
> Also note - I've no clue if the implementation works as I have no need for
> something like this yet. :-)
>
> There are a few methods which are pretty large, but overall the code looks
> pretty good with helpful inline comments and a lot of phpdoc declarations.
>

Thanks for the above comments, much appreciated. I'll make the changes you
suggest, including the versioning change which does make more sense :-)

Re. the $options and in particular the image type, the thinking was that you
could generate multiple codes using a single instantiation of the class with
a) different data and b) different image types. But maybe it does make more
sense to shift the options into the constructor configuration options, and
keep makeCode's parameters to just the data. Thoughts welcome :-)

Cheers,

Rich
--
Rich Sage
Oxford, UK
rich.sage@...

From forum: Pear - Dev

[PEPr] Comment on Images::Image_QRCode

2009-12-16T12:05:52Z

A few suggestions:

* I would declare the private variables as such, and use protected if
possible.

* The constructor should be named __construct since you're requiring PHP
5.

* The first release should not be 1.0.0, maybe 0.1.0?

* Have you tried installing the package and running it? The data files
will not be placed into the same directory as the php files unless their
role is php. Just be aware of this and either use an install-time
replacement or find some other way to reference the files.

* I'm not sure if some of the $options passed to makeCode could be made
into constructor config options or not, for example, you can only set the
image type in the makeCode() and not in the constructor which seems a bit
odd since it's a member var of the class.

Also note - I've no clue if the implementation works as I have no need for
something like this yet. :-)

There are a few methods which are pretty large, but overall the code looks
pretty good with helpful inline comments and a lot of phpdoc declarations.

--
http://pear.php.net/pepr/pepr-proposal-show.php?id=623

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: [PEPr] +1 for Web Services::Services_Digg2

2009-12-16T10:31:12Z

On Dec 16, 2009, at 11:25 AM, David Jean Louis wrote:

>
> David Jean Louis (http://pear.php.net/user/izi) has voted +1 on the proposal for Web Services::Services_Digg2.
>
> Proposal information:
> http://pear.php.net/pepr/pepr-proposal-show.php?id=622
> Vote information:
> http://pear.php.net/pepr/pepr-vote-show.php?id=622&handle=izi
>
> Comment:
>
> Great work Bill. 100% coverage, cool :)

Thanks! This is our requirement here at Digg. We're not messing around anymore. :) (OpenID has 100% as well, with a few ignore annotations for un-mockable cases).

Cheers,

Bill
--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

[PEPr] +1 for Authentication::OpenID

2009-12-16T10:27:10Z

David Jean Louis (http://pear.php.net/user/izi) has voted +1 on the proposal for Authentication::OpenID.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=603
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=603&handle=izi

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

[PEPr] +1 for Web Services::Services_Digg2

2009-12-16T10:26:27Z

David Jean Louis (http://pear.php.net/user/izi) has voted +1 on the proposal for Web Services::Services_Digg2.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=622
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=622&handle=izi

Comment:

Great work Bill. 100% coverage, cool :)

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

[PEPr] +1 for Web Services::Services_Digg2

2009-12-16T10:01:21Z

Rich Schumacher (http://pear.php.net/user/richid) has voted +1 on the proposal for Web Services::Services_Digg2.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=622
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=622&handle=richid

Comment:

Looks good. I like the lightweight design and the ability to get an
HTTP_Request2_Response object back if needed.

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: [PEPr] +1 for Authentication::OpenID

2009-12-16T09:57:03Z

On Dec 16, 2009, at 7:35 AM, Brett Bieber wrote:

>
> Brett Bieber (http://pear.php.net/user/saltybeagle) has voted +1 on the proposal for Authentication::OpenID.
>
> Proposal information:
> http://pear.php.net/pepr/pepr-proposal-show.php?id=603
> Vote information:
> http://pear.php.net/pepr/pepr-vote-show.php?id=603&handle=saltybeagle
>
> Comment:
>
> Agree on dropping the older dependencies and some documentation in peardoc
> that can be translated.
>

Yeah, the peardoc stuff will be good to have.

> Great work.

Thanks!

Bill
--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: [PEPr] +1 for Authentication::OpenID

2009-12-16T09:56:13Z

On Dec 16, 2009, at 6:11 AM, Till Klampaeckel wrote:

>
> Till Klampaeckel (http://pear.php.net/user/till) has voted +1 on the proposal for Authentication::OpenID.
>
> Proposal information:
> http://pear.php.net/pepr/pepr-proposal-show.php?id=603
> Vote information:
> http://pear.php.net/pepr/pepr-vote-show.php?id=603&handle=till
>
> Comment:
>
> Thanks, Bill!
>
> I already look forward to converting a lot of my own code to use this. :)
>

Excellent!

> Last but not least, it would be awesome to get your examples wrapped into
> a blog post, or better yet, peardoc. So people have no issues adopting the
> package right away!
>

Indeed, good idea!

> Thanks again!

You're welcome, thanks for voting and your comments.

Cheers,

Bill
--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: [PEPr] +1 for Authentication::OpenID

2009-12-16T09:55:09Z

On Dec 16, 2009, at 3:36 AM, Alexey Borzov wrote:

>
> Alexey Borzov (http://pear.php.net/user/avb) has voted +1 on the proposal for Authentication::OpenID.
>
> Proposal information:
> http://pear.php.net/pepr/pepr-proposal-show.php?id=603
> Vote information:
> http://pear.php.net/pepr/pepr-vote-show.php?id=603&handle=avb
>
> Comment:
>
> Thanks for converting to HTTP_Request2, I'd very much like to see other
> PHP4 dependencies dropped as well, but think this can be achieved after the
> package is accepted.
>

Indeed. Cache_Lite and Log (which I neglected to list in the proposal) are the hard ones to replace. Date not so much. I'll also be removing Validate in favor of the filter extension.

> Also you have an MDB2 storage driver with MySQL specific syntax, consider
> either dropping MDB2 dependency and working with MySQL directly, or
> updating SQL to be usable with other RDBMSes.

Good call. I wonder if anyone else has an interest in helping with this. I don't use this driver, it's here more as a courtesy/example to help people get up and running quickly.

Thanks for voting and your feedback.

Cheers,

Bill
--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

[PEPr] +1 for Authentication::OpenID

2009-12-16T09:52:52Z

Kurt Wilms (http://pear.php.net/user/kwilms) has voted +1 on the proposal for Authentication::OpenID.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=603
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=603&handle=kwilms

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

[PEPr] +1 for Web Services::Services_Digg2

2009-12-16T09:52:33Z

Kurt Wilms (http://pear.php.net/user/kwilms) has voted +1 on the proposal for Web Services::Services_Digg2.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=622
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=622&handle=kwilms

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: new maintainer/developer on Mail_Mime

2009-12-16T09:32:41Z

[in reply to till@..., 16-12-2009]

> Hey Walter, Cipri,

> do you guys have any objections to Alec helping on Mail_Mime? Please
> let us know if you have any objections.

> Till

Hi Till,

I have no problem at all. I have been extremely swamped with work + study in the past year, and this will likely not change in the next 6 months, so I will remain inactive for some time to come.

In fact I have never been really active on Mail_mime; the code needs refactoring to make it modern and while I had big plans last year, this would really require consistent effort over weeks/months. So maybe it will be better to no longer mark me as a lead. As it stands, I don't even have time for small fixes...

Kind regards,
WH

From forum: Pear - Dev

new maintainer/developer on Mail_Mime

2009-12-16T09:27:01Z

Hey Walter, Cipri,

do you guys have any objections to Alec helping on Mail_Mime? Please
let us know if you have any objections.

Till

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: MDB2 for PHP5 (Re: [PEAR-DEV] [PEPr] +1 for Authentication::OpenID)

2009-12-16T09:20:48Z

On Wed, Dec 16, 2009 at 4:34 PM, Brett Bieber <brett.bieber@...> wrote:

> On Wed, Dec 16, 2009 at 7:07 AM, till <klimpong@...> wrote:
>> On Wed, Dec 16, 2009 at 12:36 PM, Alexey Borzov <borz_off@...> wrote:
>>> (...)
>>> Also you have an MDB2 storage driver with MySQL specific syntax, consider
>>> either dropping MDB2 dependency and working with MySQL directly, or
>>> updating SQL to be usable with other RDBMSes.
>>
>> I guess this is one of -the- things in PEAR/PEAR2 to provide.
>>
>> Or is PEAR gonna drop this and support a project like doctrine?
>
> I would move towards Doctrine.
>
> They have a stable PEAR channel so you can declare it as an optional
> dependency, and it's a very robust DBAL & ORM descended from MDB2.
>

I sometimes wish there was something more lightweight, but I generally agree.

Till

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: MDB2 for PHP5 (Re: [PEAR-DEV] [PEPr] +1 for Authentication::OpenID)

2009-12-16T07:34:22Z

On Wed, Dec 16, 2009 at 7:07 AM, till <klimpong@...> wrote:
> On Wed, Dec 16, 2009 at 12:36 PM, Alexey Borzov <borz_off@...> wrote:
>> (...)
>> Also you have an MDB2 storage driver with MySQL specific syntax, consider
>> either dropping MDB2 dependency and working with MySQL directly, or
>> updating SQL to be usable with other RDBMSes.
>
> I guess this is one of -the- things in PEAR/PEAR2 to provide.
>
> Or is PEAR gonna drop this and support a project like doctrine?

I would move towards Doctrine.

They have a stable PEAR channel so you can declare it as an optional
dependency, and it's a very robust DBAL & ORM descended from MDB2.

--
Brett Bieber

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

[PEPr] +1 for Authentication::OpenID

2009-12-16T06:36:02Z

Brett Bieber (http://pear.php.net/user/saltybeagle) has voted +1 on the proposal for Authentication::OpenID.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=603
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=603&handle=saltybeagle

Comment:

Agree on dropping the older dependencies and some documentation in peardoc
that can be translated.

Great work.

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

[PEPr] +1 for Web Services::Services_Digg2

2009-12-16T06:32:30Z

Brett Bieber (http://pear.php.net/user/saltybeagle) has voted +1 on the proposal for Web Services::Services_Digg2.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=622
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=622&handle=saltybeagle

Comment:

Some docs would be great, as well as a transition guide from Services_Digg
(if necessary).

Nice work.

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: Mail_Mime patches

2009-12-16T05:31:32Z

On Wed, Dec 16, 2009 at 7:04 AM, till <klimpong@...> wrote:
> +1 from my side, hope someone adds your karma and we can move forward
> on this package.
>

Have we heard anything yet from walter/cipri? Did I miss a +1 message from them?

The package is not marked as unmaintained, but we have patches waiting.

Walter, Cipriano - how do these patches look, can we grant alec karma?

--
Brett Bieber

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

[PEPr] +1 for Authentication::OpenID

2009-12-16T05:12:14Z

Till Klampaeckel (http://pear.php.net/user/till) has voted +1 on the proposal for Authentication::OpenID.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=603
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=603&handle=till

Comment:

Thanks, Bill!

I already look forward to converting a lot of my own code to use this. :)

Last but not least, it would be awesome to get your examples wrapped into
a blog post, or better yet, peardoc. So people have no issues adopting the
package right away!

Thanks again!

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

MDB2 for PHP5 (Re: [PEAR-DEV] [PEPr] +1 for Authentication::OpenID)

2009-12-16T05:07:30Z

On Wed, Dec 16, 2009 at 12:36 PM, Alexey Borzov <borz_off@...> wrote:
> (...)
> Also you have an MDB2 storage driver with MySQL specific syntax, consider
> either dropping MDB2 dependency and working with MySQL directly, or
> updating SQL to be usable with other RDBMSes.

I guess this is one of -the- things in PEAR/PEAR2 to provide.

Or is PEAR gonna drop this and support a project like doctrine?

Till

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: Mail_Mime patches

2009-12-16T05:04:47Z

On Wed, Dec 16, 2009 at 11:45 AM, A.L.E.C <alec@...> wrote:
> till wrote:
>>
>> Alec,
>>
>> just wondering, did anyone tell you to open an account?
>
> What you mean "to open"? I've got an account.

Yeah, cause I nudged people on IRC. ;-)

Generally, the procedure for a new contributor/maintainer is to attach
patches to bugs so we can see what you are up to.

> "Your SVN account (alec) was created.
>
> You should be able to log into the SVN server within the hour, and
> your alec@... forward to alec@... should
> be active within the next 24 hours."
>
>> Usually, you need to contribute patches before karma is granted.
>
> There are some of my patches in bugtracker. I should sent them here?
> Attached a diff for change that I was trying to commit first.
>
> --
> Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252
> LAN Management System Developer http://lms.org.pl
> Roundcube Webmail Developer http://roundcube.net
>
> Index: tests/test_Bug_14529.phpt
> ===================================================================
> --- tests/test_Bug_14529.phpt (wersja 0)
> +++ tests/test_Bug_14529.phpt (wersja 0)
> @@ -0,0 +1,15 @@
> +--TEST--
> +Bug #14529: basename() workaround
> +--SKIPIF--
> +--FILE--
> +<?php
> +error_reporting(E_ALL); // ignore E_STRICT
> +include "Mail/mime.php";
> +$m = new Mail_mime();
> +// some text with polish Unicode letter at the beginning
> +$path = "/path/";
> +$filename = $path . base64_decode("xZtjaWVtYQ==");
> +print_r(base64_encode($m->_basename($filename)));
> +?>
> +--EXPECT--
> +xZtjaWVtYQ==
> Index: mime.php
> ===================================================================
> --- mime.php (wersja 292187)
> +++ mime.php (kopia robocza)
> @@ -350,7 +350,7 @@
> $err = PEAR::raiseError($msg);
> return $err;
> }
> - $filename = basename($filename);
> + $filename = $this->_basename($filename);
> if (PEAR::isError($filedata)) {
> return $filedata;
> }
> @@ -391,16 +391,16 @@
> $err = PEAR::raiseError('File is not readable: ' . $file_name);
> return $err;
> }
> -
> +
> //Temporarily reset magic_quotes_runtime and read file contents
> if ($magic_quote_setting = get_magic_quotes_runtime()) {
> set_magic_quotes_runtime(0);
> }
> - $cont = file_get_contents($file_name);
> + $cont = file_get_contents($file_name);
> if ($magic_quote_setting) {
> set_magic_quotes_runtime($magic_quote_setting);
> }
> -
> +
> return $cont;
> }
>
> @@ -465,7 +465,7 @@
> {
> $params = array();
> $params['content_type'] = 'multipart/mixed';
> -
> +
> //Create empty multipart/mixed Mail_mimePart object to return
> $ret = new Mail_mimePart('', $params);
> return $ret;
> @@ -587,9 +587,9 @@
> * @access public
> */
> function getMessage(
> - $separation = null,
> - $build_params = null,
> - $xtra_headers = null,
> + $separation = null,
> + $build_params = null,
> + $xtra_headers = null,
> $overwrite = false
> )
> {
> @@ -640,7 +640,7 @@
> $this->_build_params[$key] = $value;
> }
> }
> -
> +
> if (isset($this->_headers['From'])){
> //Bug #11381: Illegal characters in domain ID
> if (preg_match("|(@[0-9a-zA-Z\-\.]+)|", $this->_headers['From'],
> $matches)){
> @@ -652,7 +652,7 @@
> $this->_html_images[$i]['cid'] =
> $this->_html_images[$i]['cid'] . $domainID;
> }
> }
> -
> +
> if (count($this->_html_images) AND isset($this->_htmlbody)) {
> foreach ($this->_html_images as $key => $value) {
> $regex = array();
> @@ -666,8 +666,8 @@
> $rep[] = 'url(\1cid:' . $value['cid'] . '\1)';
>
> $this->_htmlbody = preg_replace($regex, $rep,
> $this->_htmlbody);
> - $this->_html_images[$key]['name'] =
> - basename($this->_html_images[$key]['name']);
> + $this->_html_images[$key]['name'] =
> + $this->_basename($this->_html_images[$key]['name']);
> }
> }
>
> @@ -757,7 +757,7 @@
>
> if (isset($message)) {
> $output = $message->encode();
> -
> +
> $this->_headers = array_merge($this->_headers,
> $output['headers']);
> $body = $output['body'];
> @@ -813,7 +813,7 @@
> function txtHeaders($xtra_headers = null, $overwrite = false)
> {
> $headers = $this->headers($xtra_headers, $overwrite);
> -
> +
> $ret = '';
> foreach ($headers as $key => $val) {
> $ret .= "$key: $val" . MAIL_MIME_CRLF;
> @@ -914,7 +914,6 @@
> */
> function _encodeHeaders($input, $params = array())
> {
> -
> $build_params = $this->_build_params;
> while (list($key, $value) = each($params)) {
> $build_params[$key] = $value;
> @@ -926,11 +925,11 @@
> //$hdr_value_out: The recombined $hdr_val-atoms, or the encoded
> string.
> //Note: Atom as specified here is not exactly the same as an RFC822
> atom,
> //as $atom's may contain just a single space.
> -
> - $useIconv = true;
> +
> + $useIconv = true;
> if (isset($build_params['ignore-iconv'])) {
> $useIconv = !$build_params['ignore-iconv'];
> - }
> + }
> foreach ($input as $hdr_name => $hdr_value) {
> /*
> $parts = preg_split('/([ ])/', $hdr_value, -1,
> PREG_SPLIT_DELIM_CAPTURE);
> @@ -960,14 +959,14 @@
> $imePrefs['output-charset'] =
> $build_params['head_charset'];
> $imePrefs['line-length'] = 74;
> $imePrefs['line-break-chars'] = "\r\n"; //Specified in
> RFC2047
> -
> +
> $hdr_value = iconv_mime_encode($hdr_name, $hdr_value,
> $imePrefs);
> $hdr_value = preg_replace("#^{$hdr_name}\:\ #", "",
> $hdr_value);
> } elseif ($build_params['head_encoding'] == 'base64') {
> //Base64 encoding has been selected.
> //Base64 encode the entire string
> $hdr_value = base64_encode($hdr_value);
> -
> +
> //Generate the header using the specified params and
> dynamicly
> //determine the maximum length of such strings.
> //75 is the value specified in the RFC. The first -2 is
> there so
> @@ -983,7 +982,7 @@
> //we can get must be rounded down.
> $maxLength = $maxLength - ($maxLength % 4);
> $maxLength1stLine = $maxLength1stLine -
> ($maxLength1stLine % 4);
> -
> +
> $cutpoint = $maxLength1stLine;
> $hdr_value_out = $hdr_value;
> $output = "";
> @@ -992,10 +991,10 @@
> $part = substr($hdr_value_out, 0, $cutpoint);
> $hdr_value_out = substr($hdr_value_out, $cutpoint);
> $cutpoint = $maxLength;
> - //RFC 2047 specifies that any split header should
> + //RFC 2047 specifies that any split header should
> //be seperated by a CRLF SPACE.
> if ($output) {
> - $output .= "\r\n ";
> + $output .= "\r\n ";
> }
> $output .= $prefix . $part . $suffix;
> }
> @@ -1019,7 +1018,7 @@
> $hdr_value = substr($hdr_value, 0, -1);
> $quoteSuffix = '"';
> }
> -
> +
> //Generate the header using the specified params and
> dynamicly
> //determine the maximum length of such strings.
> //75 is the value specified in the RFC. The -2 is there
> so
> @@ -1031,12 +1030,12 @@
> $maxLength = 75 - strlen($prefix . $suffix) - 2 - 1;
> $maxLength1stLine = $maxLength - strlen($hdr_name) - 2;
> $maxLength = $maxLength - 1;
> -
> +
> //Replace all special characters used by the encoder.
> $search = array('=', '_', '?', ' ');
> $replace = array('=3D', '=5F', '=3F', '_');
> $hdr_value = str_replace($search, $replace, $hdr_value);
> -
> +
> //Replace all extended characters (\x80-xFF) with their
> //ASCII values.
> $hdr_value = preg_replace('#([\x80-\xFF])#e',
> @@ -1050,7 +1049,6 @@
> //Fix for Bug #10298, Ota Mares <om@...>
> //Concat the double quotes and encoded string together
> $hdr_value = $quotePrefix . $hdr_value . $quoteSuffix;
> -
>
> $hdr_value_out = $hdr_value;
> $realMax = $maxLength1stLine + strlen($prefix .
> $suffix);
> @@ -1062,11 +1060,11 @@
> //Split translated string at every $maxLength
> //But make sure not to break any translated
> chars.
> $found = preg_match($reg, $hdr_value_out,
> $matches);
> -
> +
> //After this first line, we need to use a
> different
> //regexp for the first line.
> $reg = $reg2nd;
> -
> +
> //Save the found part and encapsulate it in the
> //prefix & suffix. Then remove the part from the
> //$hdr_value_out variable.
> @@ -1078,11 +1076,11 @@
> $part = $hdr_value_out;
> $hdr_value_out = "";
> }
> -
> +
> //RFC 2047 specifies that any split header
> should
> //be seperated by a CRLF SPACE
> if ($output) {
> - $output .= "\r\n ";
> + $output .= "\r\n ";
> }
> $output .= $prefix . $part . $suffix;
> }
> @@ -1114,6 +1112,21 @@
> }
> }
>
> -
> + /**
> + * Get file's basename (locale independent)
> + *
> + * @param string Filename
> + *
> + * @return string Basename
> + * @access private
> + */
> + function _basename($filename)
> + {
> + // basename() is not unicode safe and locale dependent
> + if (stristr(PHP_OS, 'win') || stristr(PHP_OS, 'netware'))
> + return preg_replace('/^.*[\\\\\\/]/', '', $filename);
> + else
> + return preg_replace('/^.*[\/]/', '', $filename);
> + }
>
> } // End of class
>

Generally, looks good. I especially like that you added a test case for this.

Make sure to briefly review the PEAR coding standards -- they are
different from RoundCube. ;-) I can help/assist if you have questions.

+1 from my side, hope someone adds your karma and we can move forward
on this package.

Till

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: Mail_Mime patches

2009-12-16T02:44:53Z

till wrote:
> Alec,
>
> just wondering, did anyone tell you to open an account?

What you mean "to open"? I've got an account.

"Your SVN account (alec) was created.

You should be able to log into the SVN server within the hour, and
your alec@... forward to alec@... should
be active within the next 24 hours."

> Usually, you need to contribute patches before karma is granted.

There are some of my patches in bugtracker. I should sent them here?
Attached a diff for change that I was trying to commit first.

--
Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252
LAN Management System Developer http://lms.org.pl
Roundcube Webmail Developer http://roundcube.net

Index: tests/test_Bug_14529.phpt
===================================================================
--- tests/test_Bug_14529.phpt (wersja 0)
+++ tests/test_Bug_14529.phpt (wersja 0)
@@ -0,0 +1,15 @@
+--TEST--
+Bug #14529: basename() workaround
+--SKIPIF--
+--FILE--
+<?php
+error_reporting(E_ALL); // ignore E_STRICT
+include "Mail/mime.php";
+$m = new Mail_mime();
+// some text with polish Unicode letter at the beginning
+$path = "/path/";
+$filename = $path . base64_decode("xZtjaWVtYQ==");
+print_r(base64_encode($m->_basename($filename)));
+?>
+--EXPECT--
+xZtjaWVtYQ==
Index: mime.php
===================================================================
--- mime.php (wersja 292187)
+++ mime.php (kopia robocza)
@@ -350,7 +350,7 @@
$err = PEAR::raiseError($msg);
return $err;
}
- $filename = basename($filename);
+ $filename = $this->_basename($filename);
if (PEAR::isError($filedata)) {
return $filedata;
}
@@ -391,16 +391,16 @@
$err = PEAR::raiseError('File is not readable: ' . $file_name);
return $err;
}
-
+
//Temporarily reset magic_quotes_runtime and read file contents
if ($magic_quote_setting = get_magic_quotes_runtime()) {
set_magic_quotes_runtime(0);
}
- $cont = file_get_contents($file_name);
+ $cont = file_get_contents($file_name);
if ($magic_quote_setting) {
set_magic_quotes_runtime($magic_quote_setting);
}
-
+
return $cont;
}

@@ -465,7 +465,7 @@
{
$params = array();
$params['content_type'] = 'multipart/mixed';
-
+
//Create empty multipart/mixed Mail_mimePart object to return
$ret = new Mail_mimePart('', $params);
return $ret;
@@ -587,9 +587,9 @@
* @access public
*/
function getMessage(
- $separation = null,
- $build_params = null,
- $xtra_headers = null,
+ $separation = null,
+ $build_params = null,
+ $xtra_headers = null,
$overwrite = false
)
{
@@ -640,7 +640,7 @@
$this->_build_params[$key] = $value;
}
}
-
+
if (isset($this->_headers['From'])){
//Bug #11381: Illegal characters in domain ID
if (preg_match("|(@[0-9a-zA-Z\-\.]+)|", $this->_headers['From'], $matches)){
@@ -652,7 +652,7 @@
$this->_html_images[$i]['cid'] = $this->_html_images[$i]['cid'] . $domainID;
}
}
-
+
if (count($this->_html_images) AND isset($this->_htmlbody)) {
foreach ($this->_html_images as $key => $value) {
$regex = array();
@@ -666,8 +666,8 @@
$rep[] = 'url(\1cid:' . $value['cid'] . '\1)';

$this->_htmlbody = preg_replace($regex, $rep, $this->_htmlbody);
- $this->_html_images[$key]['name'] =
- basename($this->_html_images[$key]['name']);
+ $this->_html_images[$key]['name'] =
+ $this->_basename($this->_html_images[$key]['name']);
}
}

@@ -757,7 +757,7 @@

if (isset($message)) {
$output = $message->encode();
-
+
$this->_headers = array_merge($this->_headers,
$output['headers']);
$body = $output['body'];
@@ -813,7 +813,7 @@
function txtHeaders($xtra_headers = null, $overwrite = false)
{
$headers = $this->headers($xtra_headers, $overwrite);
-
+
$ret = '';
foreach ($headers as $key => $val) {
$ret .= "$key: $val" . MAIL_MIME_CRLF;
@@ -914,7 +914,6 @@
*/
function _encodeHeaders($input, $params = array())
{
-
$build_params = $this->_build_params;
while (list($key, $value) = each($params)) {
$build_params[$key] = $value;
@@ -926,11 +925,11 @@
//$hdr_value_out: The recombined $hdr_val-atoms, or the encoded string.
//Note: Atom as specified here is not exactly the same as an RFC822 atom,
//as $atom's may contain just a single space.
-
- $useIconv = true;
+
+ $useIconv = true;
if (isset($build_params['ignore-iconv'])) {
$useIconv = !$build_params['ignore-iconv'];
- }
+ }
foreach ($input as $hdr_name => $hdr_value) {
/*
$parts = preg_split('/([ ])/', $hdr_value, -1, PREG_SPLIT_DELIM_CAPTURE);
@@ -960,14 +959,14 @@
$imePrefs['output-charset'] = $build_params['head_charset'];
$imePrefs['line-length'] = 74;
$imePrefs['line-break-chars'] = "\r\n"; //Specified in RFC2047
-
+
$hdr_value = iconv_mime_encode($hdr_name, $hdr_value, $imePrefs);
$hdr_value = preg_replace("#^{$hdr_name}\:\ #", "", $hdr_value);
} elseif ($build_params['head_encoding'] == 'base64') {
//Base64 encoding has been selected.
//Base64 encode the entire string
$hdr_value = base64_encode($hdr_value);
-
+
//Generate the header using the specified params and dynamicly
//determine the maximum length of such strings.
//75 is the value specified in the RFC. The first -2 is there so
@@ -983,7 +982,7 @@
//we can get must be rounded down.
$maxLength = $maxLength - ($maxLength % 4);
$maxLength1stLine = $maxLength1stLine - ($maxLength1stLine % 4);
-
+
$cutpoint = $maxLength1stLine;
$hdr_value_out = $hdr_value;
$output = "";
@@ -992,10 +991,10 @@
$part = substr($hdr_value_out, 0, $cutpoint);
$hdr_value_out = substr($hdr_value_out, $cutpoint);
$cutpoint = $maxLength;
- //RFC 2047 specifies that any split header should
+ //RFC 2047 specifies that any split header should
//be seperated by a CRLF SPACE.
if ($output) {
- $output .= "\r\n ";
+ $output .= "\r\n ";
}
$output .= $prefix . $part . $suffix;
}
@@ -1019,7 +1018,7 @@
$hdr_value = substr($hdr_value, 0, -1);
$quoteSuffix = '"';
}
-
+
//Generate the header using the specified params and dynamicly
//determine the maximum length of such strings.
//75 is the value specified in the RFC. The -2 is there so
@@ -1031,12 +1030,12 @@
$maxLength = 75 - strlen($prefix . $suffix) - 2 - 1;
$maxLength1stLine = $maxLength - strlen($hdr_name) - 2;
$maxLength = $maxLength - 1;
-
+
//Replace all special characters used by the encoder.
$search = array('=', '_', '?', ' ');
$replace = array('=3D', '=5F', '=3F', '_');
$hdr_value = str_replace($search, $replace, $hdr_value);
-
+
//Replace all extended characters (\x80-xFF) with their
//ASCII values.
$hdr_value = preg_replace('#([\x80-\xFF])#e',
@@ -1050,7 +1049,6 @@
//Fix for Bug #10298, Ota Mares <om@...>
//Concat the double quotes and encoded string together
$hdr_value = $quotePrefix . $hdr_value . $quoteSuffix;
-

$hdr_value_out = $hdr_value;
$realMax = $maxLength1stLine + strlen($prefix . $suffix);
@@ -1062,11 +1060,11 @@
//Split translated string at every $maxLength
//But make sure not to break any translated chars.
$found = preg_match($reg, $hdr_value_out, $matches);
-
+
//After this first line, we need to use a different
//regexp for the first line.
$reg = $reg2nd;
-
+
//Save the found part and encapsulate it in the
//prefix & suffix. Then remove the part from the
//$hdr_value_out variable.
@@ -1078,11 +1076,11 @@
$part = $hdr_value_out;
$hdr_value_out = "";
}
-
+
//RFC 2047 specifies that any split header should
//be seperated by a CRLF SPACE
if ($output) {
- $output .= "\r\n ";
+ $output .= "\r\n ";
}
$output .= $prefix . $part . $suffix;
}
@@ -1114,6 +1112,21 @@
}
}

-
+ /**
+ * Get file's basename (locale independent)
+ *
+ * @param string Filename
+ *
+ * @return string Basename
+ * @access private
+ */
+ function _basename($filename)
+ {
+ // basename() is not unicode safe and locale dependent
+ if (stristr(PHP_OS, 'win') || stristr(PHP_OS, 'netware'))
+ return preg_replace('/^.*[\\\\\\/]/', '', $filename);
+ else
+ return preg_replace('/^.*[\/]/', '', $filename);
+ }

} // End of class

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

[PEPr] +1 for Authentication::OpenID

2009-12-16T02:37:31Z

Alexey Borzov (http://pear.php.net/user/avb) has voted +1 on the proposal for Authentication::OpenID.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=603
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=603&handle=avb

Comment:

Thanks for converting to HTTP_Request2, I'd very much like to see other
PHP4 dependencies dropped as well, but think this can be achieved after the
package is accepted.

Also you have an MDB2 storage driver with MySQL specific syntax, consider
either dropping MDB2 dependency and working with MySQL directly, or
updating SQL to be usable with other RDBMSes.

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: Mail_Mime patches

2009-12-16T02:15:40Z

Alec,

just wondering, did anyone tell you to open an account?

Usually, you need to contribute patches before karma is granted.

I may have jumped the gun here.

Till

On Wed, Dec 16, 2009 at 10:50 AM, A.L.E.C <alec@...> wrote:

> till wrote:
>
>> Which username/ID did you request when you filled out the form?
>
> Account created, looks I need some karma.
>
> svn: Commit blocked by pre-commit hook (exit code 1) with output:
> *******
> Access denied: Insufficient karma for alec to
> pear/packages/Mail_Mime/trunk/mime.php.
> Contact pear-group@... for access.
>
> --
> Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252
> LAN Management System Developer http://lms.org.pl
> Roundcube Webmail Developer http://roundcube.net
>
> --
> PEAR Development Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev

Re: Mail_Mime patches

2009-12-16T01:49:56Z

till wrote:

> Which username/ID did you request when you filled out the form?

Account created, looks I need some karma.

svn: Commit blocked by pre-commit hook (exit code 1) with output:
*******
Access denied: Insufficient karma for alec to
pear/packages/Mail_Mime/trunk/mime.php.
Contact pear-group@... for access.

--
Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252
LAN Management System Developer http://lms.org.pl
Roundcube Webmail Developer http://roundcube.net

--
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

From forum: Pear - Dev