Possible patch, and question

View: New views
2 Messages — Rating Filter:   Alert me  

Possible patch, and question

by Esteban Manchado Velázquez-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

    I'm using CruiseControl.rb, and I wrote a dirty patch to add basic  
support for some result "statistics" (fixes, regressions and test failures  
in a build).

    I was going to clean it up and send, and then I saw the functionality  
that is there already for reporting test failures (as a list, not  
"statistics", but most of the code could be used for the same). I mean  
get_test_failures_and_errors_if_any and friends.

    Are you interested in such a patch? My idea is making the test failure  
reporting functionality generic, so you can define your own classes, with  
their own regular expressions and such, to support other kinds of projects  
(not just Ruby). I'll also add those "statistics" about fixes and  
regressions for each build, but I can prepare a separate patch for that.

    Also, a question related to the patch: for the projects to be able to  
configure the test result "parser", I need to access the project  
configuration (duh!), but it seems it's not possible because Project.read  
is called with load_config = false in app/models/projects.rb (load_project  
method). When I changed to "true", everything worked as (I) expected. Is  
loading the project configuration on startup a problem? Is there some  
other, better way to read the configuration for the projects?

--
Esteban Manchado Velázquez <estebanm@...>, who kind of hates current  
internal Opera builds
_______________________________________________
Cruisecontrolrb-developers mailing list
Cruisecontrolrb-developers@...
http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers

Re: Possible patch, and question

by Chad Woolley :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, Oct 19, 2007 at 8:06 AM, Esteban Manchado
Velázquez<estebanm@...> wrote:
>    Are you interested in such a patch?

Yes!  Can you please create a ticket on LightHouse, and attach your patch?

https://cruisecontrolrb.lighthouseapp.com/projects/9150-cruise-control-rb

Thanks...
_______________________________________________
Cruisecontrolrb-developers mailing list
Cruisecontrolrb-developers@...
http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers