Nabble - PostgreSQL - pgadmin hackers

Re: Some questions on the backup window

2009-12-17T14:23:47Z

On Thu, Dec 17, 2009 at 10:16 PM, yasirhantoush
<yasirhantoush@...> wrote:
> Hello Guys,
> Would you please unsubscribe me from this mailing list?
> My email is yasirhantoush@...
>

http://www.pgadmin.org/development/list.php explains how to unsubscribe.

Regards, Dave.

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: Some questions on the backup window

2009-12-17T14:16:26Z

Hello Guys,
Would you please unsubscribe me from this mailing list?
My email is yasirhantoush@...

-----Original Message-----
From: pgadmin-hackers-owner@...
[mailto:pgadmin-hackers-owner@...] On Behalf Of Guillaume Lelarge
Sent: Thursday, December 17, 2009 8:33 PM
To: pgadmin-hackers@...
Cc: Dave Page
Subject: Re: [pgadmin-hackers] Some questions on the backup window

Le jeudi 17 décembre 2009 à 09:34:04, Dave Page a écrit :

> On Wed, Dec 16, 2009 at 10:44 PM, Guillaume Lelarge
>
> <guillaume@...> wrote:
> > Le mercredi 16 décembre 2009 à 13:26:00, Guillaume Lelarge a écrit :
> >> Le mercredi 16 décembre 2009 à 00:19:38, Guillaume Lelarge a écrit :
> >> [...]
> >>
> >> > * Check the UI on Mac and Windows.
> >>
> >> I'll do that tonight.
> >
> > Done. Works great on both.
> >
> > Any tests or comments before I apply it? (patch attached)
>
> Go ahead - I don't have spare cycles to look now, but I'm sure the
> code is up to your normal standard.
>

Done. Thanks.

Now, the Restore window.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: Some questions on the backup window

2009-12-17T12:32:47Z

Le jeudi 17 décembre 2009 à 09:34:04, Dave Page a écrit :

Re: [pgAdmin III] #113: Backup dialog review

2009-12-17T12:31:24Z

#113: Backup dialog review
----------------------+-----------------------------------------------------
Reporter: gleu | Owner: gleu
Type: feature | Status: closed
Priority: minor | Milestone: 1.12
Component: pgadmin | Version: 1.10
Resolution: fixed | Keywords: backup
Platform: all |
----------------------+-----------------------------------------------------
Changes (by gleu):

* status: assigned => closed
* resolution: => fixed

Comment:

Done in r8136.

--
Ticket URL: <http://code.pgadmin.org/trac/ticket/113#comment:2>
pgAdmin III <http://code.pgadmin.org/trac/>
pgAdmin III

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

SVN Commit by guillaume: r8136 - in trunk/pgadmin3: . pgadmin pgadmin/ctl pgadmin/frm pgadmin/include pgadmin/include/ctl pgadmin/include/frm pgadmin/include/utils pgadmin/ui

2009-12-17T12:30:30Z

Author: guillaume

Date: 2009-12-17 20:30:28 +0000 (Thu, 17 Dec 2009)

New Revision: 8136

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8136&view=rev

Log:
Complete review of the backup window. Add the remaining options.

Modified:
trunk/pgadmin3/CHANGELOG
trunk/pgadmin3/pgadmin/ctl/module.mk
trunk/pgadmin3/pgadmin/frm/frmBackup.cpp
trunk/pgadmin3/pgadmin/include/ctl/module.mk
trunk/pgadmin3/pgadmin/include/frm/frmBackup.h
trunk/pgadmin3/pgadmin/include/pgAdmin3.h
trunk/pgadmin3/pgadmin/include/precomp.h
trunk/pgadmin3/pgadmin/include/utils/misc.h
trunk/pgadmin3/pgadmin/pgAdmin3.cpp
trunk/pgadmin3/pgadmin/pgAdmin3.vcproj
trunk/pgadmin3/pgadmin/ui/frmBackup.xrc
trunk/pgadmin3/pgadmin/ui/xrcDialogs.cpp

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgAdmin III] #113: Backup dialog review

2009-12-17T12:29:39Z

#113: Backup dialog review
---------------------+------------------------------------------------------
Reporter: gleu | Owner: gleu
Type: feature | Status: assigned
Priority: minor | Milestone: 1.12
Component: pgadmin | Version: 1.10
Keywords: backup | Platform: all
---------------------+------------------------------------------------------
Changes (by gleu):

* owner: dpage => gleu
* status: new => assigned

--
Ticket URL: <http://code.pgadmin.org/trac/ticket/113#comment:1>
pgAdmin III <http://code.pgadmin.org/trac/>
pgAdmin III

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

SVN Commit by guillaume: r8135 - trunk/www/translation

2009-12-17T02:41:59Z

Author: guillaume

Date: 2009-12-17 10:41:59 +0000 (Thu, 17 Dec 2009)

New Revision: 8135

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8135&view=rev

Log:
Diego has a new email address.

Modified:
trunk/www/translation/config.php

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: Some questions on the backup window

2009-12-17T00:34:04Z

On Wed, Dec 16, 2009 at 10:44 PM, Guillaume Lelarge
<guillaume@...> wrote:

> Le mercredi 16 décembre 2009 à 13:26:00, Guillaume Lelarge a écrit :
>> Le mercredi 16 décembre 2009 à 00:19:38, Guillaume Lelarge a écrit :
>> [...]
>> > * Check the UI on Mac and Windows.
>>
>> I'll do that tonight.
>>
>
> Done. Works great on both.
>
> Any tests or comments before I apply it? (patch attached)

Go ahead - I don't have spare cycles to look now, but I'm sure the
code is up to your normal standard.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: Some questions on the backup window

2009-12-16T14:44:42Z

Le mercredi 16 décembre 2009 à 13:26:00, Guillaume Lelarge a écrit :
> Le mercredi 16 décembre 2009 à 00:19:38, Guillaume Lelarge a écrit :
> [...]
> > * Check the UI on Mac and Windows.
>
> I'll do that tonight.
>

Done. Works great on both.

Any tests or comments before I apply it? (patch attached)

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

pgdump.patch.bz2 (15K) Download Attachment

[pgAdmin III] #113: Backup dialog review

2009-12-16T14:42:21Z

#113: Backup dialog review
---------------------+------------------------------------------------------
Reporter: gleu | Owner: dpage
Type: feature | Status: new
Priority: minor | Milestone: 1.12
Component: pgadmin | Version: 1.10
Keywords: backup | Platform: all
---------------------+------------------------------------------------------

--
Ticket URL: <http://code.pgadmin.org/trac/ticket/113>
pgAdmin III <http://code.pgadmin.org/trac/>
pgAdmin III

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: wxWidgets 2.9?

2009-12-16T10:17:52Z

On 13.12.2009, at 23.39, Guillaume Lelarge wrote:

> Le dimanche 13 décembre 2009 à 19:04:06, Jyrki Wahlstedt a écrit :
>> [...]
>> I just wonder, has anyone tried to get pgAdmin3 to work with wxWidgets
>> 2.9.0 yet? My concern is that on OS X 10.6 wxWidgets is not happy with
>> 64-bit world (depending on Carbon interfaces) on 2.8 level, 2.9 should
>> behave better, but it is not stable and not complete. If pgAdmin3 works
>> with 2.9 at all, how well does it work, any missing main features?
>>
>
> wxWidgets 2.9 changed quite a lot of things, which makes it incompatible with
> pgAdmin.

No doubt about that...
> We need to work on that. I hope to find some time to do that.
> Unfortunately, it's really not a nice and interesting work, so it's definitely
> pretty low in my priority list.
>
Well, 2.9 is the future anyway, and on OS X 2.8 has the said difficulties (I've had a lot of grief still ahead to get it build clean via MacPorts), so I hope two things:
1) 2.9 + OS X gets more mature
2) you find some time
>
> --
> Guillaume.
> http://www.postgresqlfr.org
> http://dalibo.com
>
Thanks anyway, I appreciate the work of all of you!

!
! Jyrki Wahlstedt
! http://www.wahlstedt.fi/jyrki/
!
! Our life is no dream; but it ought to become one and perhaps will.
! PGP key ID: 0x139CC386 fingerprint: F355 B46F 026C B8C1 89C0 A780 6366 EFD9 139C C386

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgAdmin III] #112: Copy from the statistics, dependencies, and dependents panel

2009-12-16T08:08:13Z

So ? can you help me witah that program?

Reply me asap , I will pay when the program is done

--- On Tue, 12/15/09, pgAdmin Trac <trac@...> wrote:

From: pgAdmin Trac <trac@...>
Subject: [pgadmin-hackers] [pgAdmin III] #112: Copy from the statistics, dependencies, and dependents panel
To:
Cc: pgadmin-hackers@...
Date: Tuesday, December 15, 2009, 3:36 PM

#112: Copy from the statistics, dependencies, and dependents panel
-----------------------------+----------------------------------------------
Reporter: Little, Douglas |    Owner: dpage
   Type: feature | Status: new
Priority: minor |   Milestone:
Component: pgadmin |    Version: 1.10
Keywords: browser | Platform: all
-----------------------------+----------------------------------------------

--
Ticket URL: <http://code.pgadmin.org/trac/ticket/112>
pgAdmin III <http://code.pgadmin.org/trac/>
pgAdmin III

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: Some questions on the backup window

2009-12-16T04:26:00Z

Le mercredi 16 décembre 2009 à 00:19:38, Guillaume Lelarge a écrit :

> Le mardi 15 décembre 2009 à 13:01:01, Dave Page a écrit :
> > On Tue, Dec 15, 2009 at 11:59 AM, Guillaume Lelarge
> >
> > <guillaume@...> wrote:
> > > Le mardi 15 décembre 2009 à 12:32:37, Dave Page a écrit :
> > >> On Tue, Dec 15, 2009 at 10:34 AM, Guillaume Lelarge
> > >>
> > >> <guillaume@...> wrote:
> > >> > I can add a Checkbox on the Database node. A click on it would act
> > >> > as a "Check all"/"Uncheck All" items. I don't see the use of a
> > >> > "Toggle selection" button.
> > >>
> > >> I find them pretty handy when I need to check > 50% of a large number
> > >> of items. You can check the ones you don't want, and then toggle.
> > >> Depending on the total number of items, and ratio of checked to
> > >> un-checked, it can be quite a timesaver.
> > >
> > > OK, will do that. Not sure on the UI. A simple button would be enough?
> >
> > Yeah, but lets see how it works with the checkboxes only first.
>
> Tonight's work:
> * Change some strings according to Dave's advice.
> * Add checkbox on the Database node.
> * Honour the schema restriction in the treeview.
> * Re-accept schema only and table only dump.
> * Enable/Disable options depending on pg_dump release.
>
> I tried the whole new layout (Database / Schemas / each schema / Tables
> /each table), but it doesn't feel right. I think the old layout with the
> new checkbox on the Database node is much better.
>
> TODO:
> * Only the click on the checkbox should change the state of the objects

This is now fixed. I also fixed two tiny issues (bigger window and first tab
selected at startup).

> * Use icons with the checkbox?
> * Toggle Selection button?

Not sure we need to do this right now. I can probably commit a first patch
with the most important code, and, if all find it better to have those two,
write a second patch.

> * Check the UI on Mac and Windows.
>

I'll do that tonight.

My next patch will be on the restore dialog.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: Some questions on the backup window

2009-12-15T15:19:38Z

Le mardi 15 décembre 2009 à 13:01:01, Dave Page a écrit :

> On Tue, Dec 15, 2009 at 11:59 AM, Guillaume Lelarge
>
> <guillaume@...> wrote:
> > Le mardi 15 décembre 2009 à 12:32:37, Dave Page a écrit :
> >> On Tue, Dec 15, 2009 at 10:34 AM, Guillaume Lelarge
> >>
> >> <guillaume@...> wrote:
> >> > I can add a Checkbox on the Database node. A click on it would act as
> >> > a "Check all"/"Uncheck All" items. I don't see the use of a "Toggle
> >> > selection" button.
> >>
> >> I find them pretty handy when I need to check > 50% of a large number
> >> of items. You can check the ones you don't want, and then toggle.
> >> Depending on the total number of items, and ratio of checked to
> >> un-checked, it can be quite a timesaver.
> >
> > OK, will do that. Not sure on the UI. A simple button would be enough?
>
> Yeah, but lets see how it works with the checkboxes only first.
>

Tonight's work:
* Change some strings according to Dave's advice.
* Add checkbox on the Database node.
* Honour the schema restriction in the treeview.
* Re-accept schema only and table only dump.
* Enable/Disable options depending on pg_dump release.

I tried the whole new layout (Database / Schemas / each schema / Tables /each
table), but it doesn't feel right. I think the old layout with the new
checkbox on the Database node is much better.

TODO:
* Only the click on the checkbox should change the state of the object
* Use icons with the checkbox?
* Toggle Selection button?
* Check the UI on Mac and Windows.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgAdmin III] #112: Copy from the statistics, dependencies, and dependents panel

2009-12-15T12:36:19Z

#112: Copy from the statistics, dependencies, and dependents panel
-----------------------------+----------------------------------------------
Reporter: Little, Douglas | Owner: dpage
Type: feature | Status: new
Priority: minor | Milestone:
Component: pgadmin | Version: 1.10
Keywords: browser | Platform: all
-----------------------------+----------------------------------------------

--
Ticket URL: <http://code.pgadmin.org/trac/ticket/112>
pgAdmin III <http://code.pgadmin.org/trac/>
pgAdmin III

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: Some questions on the backup window

2009-12-15T04:01:01Z

On Tue, Dec 15, 2009 at 11:59 AM, Guillaume Lelarge
<guillaume@...> wrote:

> Le mardi 15 décembre 2009 à 12:32:37, Dave Page a écrit :
>> On Tue, Dec 15, 2009 at 10:34 AM, Guillaume Lelarge
>>
>> <guillaume@...> wrote:
>> > I can add a Checkbox on the Database node. A click on it would act as a
>> > "Check all"/"Uncheck All" items. I don't see the use of a "Toggle
>> > selection" button.
>>
>> I find them pretty handy when I need to check > 50% of a large number
>> of items. You can check the ones you don't want, and then toggle.
>> Depending on the total number of items, and ratio of checked to
>> un-checked, it can be quite a timesaver.
>>
>
> OK, will do that. Not sure on the UI. A simple button would be enough?

Yeah, but lets see how it works with the checkboxes only first.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: Some questions on the backup window

2009-12-15T03:59:55Z

Le mardi 15 décembre 2009 à 12:32:37, Dave Page a écrit :

> On Tue, Dec 15, 2009 at 10:34 AM, Guillaume Lelarge
>
> <guillaume@...> wrote:
> > I can add a Checkbox on the Database node. A click on it would act as a
> > "Check all"/"Uncheck All" items. I don't see the use of a "Toggle
> > selection" button.
>
> I find them pretty handy when I need to check > 50% of a large number
> of items. You can check the ones you don't want, and then toggle.
> Depending on the total number of items, and ratio of checked to
> un-checked, it can be quite a timesaver.
>

OK, will do that. Not sure on the UI. A simple button would be enough?

> It's not essential though - your idea will also work nicely.Would you
> make toggling of a schema work the same way?
>

It already works this way for schemas. You click on a schema checkbox to
select it, and all tables in this schema are selected too. You click once
again and all tables are de-selected.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: Some questions on the backup window

2009-12-15T03:32:37Z

On Tue, Dec 15, 2009 at 10:34 AM, Guillaume Lelarge
<guillaume@...> wrote:

> I can add a Checkbox on the Database node. A click on it would act as a "Check
> all"/"Uncheck All" items. I don't see the use of a "Toggle selection" button.

I find them pretty handy when I need to check > 50% of a large number
of items. You can check the ones you don't want, and then toggle.
Depending on the total number of items, and ratio of checked to
un-checked, it can be quite a timesaver.

It's not essential though - your idea will also work nicely.Would you
make toggling of a schema work the same way?

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: Some questions on the backup window

2009-12-15T02:34:33Z

Le mardi 15 décembre 2009 à 10:21:33, Dave Page a écrit :

> On Tue, Dec 15, 2009 at 9:06 AM, Guillaume Lelarge
>
> <guillaume@...> wrote:
> > And so did I. I now have a new tab with the list of objects one can save.
> > You'll find attached a screenshot showing this.
>
> Cool :-)
>
> > I still have a few questions:
> >
> > * Do you have any ideas for a better name on the tabs?
>
> Maybe just 'Objects'?

Done.

> Not sure about the others. I assume every thing
> is selected by default?

Yes.

> It would probably be good to add a 'Toggle
> selections' button, or 'Check all'/'Uncheck All' (or all three)
>

I can add a Checkbox on the Database node. A click on it would act as a "Check
all"/"Uncheck All" items. I don't see the use of a "Toggle selection" button.

> > * Instead of "Database x", "Schema y", or "Table z", I can probably add
> > the icon with the checkbox. Not sure if it's really interesting, but
> > it'll help me to get ride of a dirty hack to get back the object's name.
>
> Not sure how well it'll work to have checkboxes and icons, but it'll
> probably look nicer.

Well, the icon will be bigger, but I don't think it'll be an issue. I'll try
tonight.

> The other option would be to have something like:
>
> Database
> - Schemas
> - Foo
> - Bar
> - Tables
> - foo_table
> - bar_table
>

That's a really great idea. It'll also mimic the object's browser.

> > * A user can set schema's restriction on a database. Should a user see
> > (and so backup) only the allowed schemas or should the backup bypass this
> > specific configuration? (I mean, if he tries to backup the whole
> > database, this configuration is already bypassed)
>
> Good question. I don't think there's much we can do about dumping the
> whole database, except to warn the user if there's a restriction in
> place that will be ignored.
>
> I think we should honour the restriction in the treeview though.
>

OK.

> > This patch is in the git repository, but still needs some work, for
> > example to allow the use of some 8.4 specific options. Moreover the
> > schema and table backup are actually broken. But it will be quite easy to
> > fix. Expect a complete patch tonight.
>
> Cool. Couple of other thoughts from the earlier screenshots:
>
> - On Options #1, change the frame title to 'Type of objects'
>

Done.

> - On Options #1, change 'Create DB' 'Include CREATE DATABASE
> statement', 'Drop DB' to 'Include DROP DATABASE statement' and prefix
> the other two Query options with 'Use'. Oh, and the I on Inserts
> should be in lower case.
>

Done.

BTW, I think the drop db option is really a drop objects option. It is the
option that add drop statements for all objects before creating them. Or am I
wrong?

> - On Options #2, remove 'Disable' from 'Disable $ quoting' (it's
> already in the frame title)
>

Already done.

> - On Options #2, SET SESSION AUTHORIZATION should be in upper case.
>

Done.

Thanks.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: Some questions on the backup window

2009-12-15T01:21:33Z

On Tue, Dec 15, 2009 at 9:06 AM, Guillaume Lelarge
<guillaume@...> wrote:

> And so did I. I now have a new tab with the list of objects one can save.
> You'll find attached a screenshot showing this.

Cool :-)

> I still have a few questions:
>
> * Do you have any ideas for a better name on the tabs?

Maybe just 'Objects'? Not sure about the others. I assume every thing
is selected by default? It would probably be good to add a 'Toggle
selections' button, or 'Check all'/'Uncheck All' (or all three)

> * Instead of "Database x", "Schema y", or "Table z", I can probably add the
> icon with the checkbox. Not sure if it's really interesting, but it'll help
> me to get ride of a dirty hack to get back the object's name.

Not sure how well it'll work to have checkboxes and icons, but it'll
probably look nicer. The other option would be to have something like:

Database
- Schemas
- Foo
- Bar
- Tables
- foo_table
- bar_table

> * A user can set schema's restriction on a database. Should a user see (and
> so backup) only the allowed schemas or should the backup bypass this
> specific configuration? (I mean, if he tries to backup the whole database,
> this configuration is already bypassed)

Good question. I don't think there's much we can do about dumping the
whole database, except to warn the user if there's a restriction in
place that will be ignored.

I think we should honour the restriction in the treeview though.

> This patch is in the git repository, but still needs some work, for example to
> allow the use of some 8.4 specific options. Moreover the schema and table
> backup are actually broken. But it will be quite easy to fix. Expect a
> complete patch tonight.

Cool. Couple of other thoughts from the earlier screenshots:

- On Options #1, change the frame title to 'Type of objects'

- On Options #1, change 'Create DB' 'Include CREATE DATABASE
statement', 'Drop DB' to 'Include DROP DATABASE statement' and prefix
the other two Query options with 'Use'. Oh, and the I on Inserts
should be in lower case.

- On Options #2, remove 'Disable' from 'Disable $ quoting' (it's
already in the frame title)

- On Options #2, SET SESSION AUTHORIZATION should be in upper case.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: Some questions on the backup window

2009-12-15T01:06:00Z

Le jeudi 10 décembre 2009 à 17:05:44, Guillaume Lelarge a écrit :

> Le jeudi 10 décembre 2009 à 16:40:32, Dave Page a écrit :
> > On Thu, Dec 10, 2009 at 3:34 PM, Guillaume Lelarge
> >
> > <guillaume@...> wrote:
> [...]
> > If you want a treeview with checkboxes, you could look at what I
> > did for StackBuilder - for example the AppTreeCtrl in
> > http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/stackbuilder/wizard/AppSelect
> >io nPage.cpp?rev=1.10&content-type=text/x-cvsweb-markup. It's pretty
> > simple - we just toggle the node image as the user clicks.
>
> Didn't know you already did it, in another project. I will get a look at
> it. Thanks.
>

And so did I. I now have a new tab with the list of objects one can save.
You'll find attached a screenshot showing this.

I still have a few questions:

* Do you have any ideas for a better name on the tabs?
* Instead of "Database x", "Schema y", or "Table z", I can probably add the
icon with the checkbox. Not sure if it's really interesting, but it'll help
me to get ride of a dirty hack to get back the object's name.
* A user can set schema's restriction on a database. Should a user see (and
so backup) only the allowed schemas or should the backup bypass this
specific configuration? (I mean, if he tries to backup the whole database,
this configuration is already bypassed)

This patch is in the git repository, but still needs some work, for example to
allow the use of some 8.4 specific options. Moreover the schema and table
backup are actually broken. But it will be quite easy to fix. Expect a
complete patch tonight.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

frmBackup4.png (55K) Download Attachment

Re: pgAdmin3 icon

2009-12-15T00:40:53Z

Le lundi 14 décembre 2009 à 22:21 +0100, Guillaume Lelarge a écrit :
> I'll ask my cousin. I refrained him to just get a better look for the
> 16x16
> icon.

Dear Guillaume and Dave,

It seems a reasonable approach. Scale down the SVG icon to 16x16 and
optimize colors. I really believe that the SVG icon is perfect.

Kind regards,
Jean-Michel

signature.asc (205 bytes) Download Attachment

SVN Commit by guillaume: r8134 - trunk/www/translation

2009-12-15T00:32:33Z

Author: guillaume

Date: 2009-12-15 08:32:33 +0000 (Tue, 15 Dec 2009)

New Revision: 8134

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8134&view=rev

Log:
Fix bad list.

Modified:
trunk/www/translation/status.php

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: pgAdmin3 icon

2009-12-14T13:21:08Z

Le lundi 14 décembre 2009 à 22:18:16, Dave Page a écrit :
> 2009/12/14 Guillaume Lelarge <guillaume@...>:
> > What do you mean with "update the icon"? re-design it?
>
> Yeah, something new and interesting (but still elephant related). The
> current icon is over a decade old. The splash screen could use an
> update too.
>

I'll ask my cousin. I refrained him to just get a better look for the 16x16
icon.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: pgAdmin3 icon

2009-12-14T13:18:16Z

2009/12/14 Guillaume Lelarge <guillaume@...>:

> What do you mean with "update the icon"? re-design it?

Yeah, something new and interesting (but still elephant related). The
current icon is over a decade old. The splash screen could use an
update too.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: pgAdmin3 icon

2009-12-14T13:07:57Z

Le lundi 14 décembre 2009 à 21:10:37, Dave Page a écrit :

> 2009/12/14 Jean-Michel Pouré <jmpoure@...>:
> > Le lundi 14 décembre 2009 à 16:25 +0000, Dave Page a écrit :
> >> BTW, the second screenshot attached shows Guillaumes version of the
> >> original 16x16 next to the simplified one.
> >
> > I uploaded a new proposal for the x16 icon:
> > http://www.poure.com/images/
>
> That's certainly an improvement.
>
> > Modern OSes (Windows 7, Mac OS and GNU/Linux) support large icons. The
> > x16 icon should not stop you from publishing the original SVG icon,
> > which is superb.
>
> Assuming that all the old versions of Gnome/XFCE/KDE that we try to
> support can handle svg, I don't have a problem with including that
> icon.
>
> What you proposal doesn't resolve though, is the fact that I'd like to
> update the icon while we're at it. Admittedly I haven't made much
> noise about that yet, but that's largely 'cos everyone seemed to like
> the proposed new one.
>

What do you mean with "update the icon"? re-design it?

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: pgAdmin3 icon

2009-12-14T12:10:37Z

2009/12/14 Jean-Michel Pouré <jmpoure@...>:
> Le lundi 14 décembre 2009 à 16:25 +0000, Dave Page a écrit :
>>
>> BTW, the second screenshot attached shows Guillaumes version of the
>> original 16x16 next to the simplified one.
>
> I uploaded a new proposal for the x16 icon:
> http://www.poure.com/images/

That's certainly an improvement.

> Modern OSes (Windows 7, Mac OS and GNU/Linux) support large icons. The
> x16 icon should not stop you from publishing the original SVG icon,
> which is superb.

Assuming that all the old versions of Gnome/XFCE/KDE that we try to
support can handle svg, I don't have a problem with including that
icon.

What you proposal doesn't resolve though, is the fact that I'd like to
update the icon while we're at it. Admittedly I haven't made much
noise about that yet, but that's largely 'cos everyone seemed to like
the proposed new one.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: pgAdmin3 icon

2009-12-14T08:58:24Z

Le lundi 14 décembre 2009 à 16:25 +0000, Dave Page a écrit :
>
> BTW, the second screenshot attached shows Guillaumes version of the
> original 16x16 next to the simplified one.

I uploaded a new proposal for the x16 icon:
http://www.poure.com/images/

Modern OSes (Windows 7, Mac OS and GNU/Linux) support large icons. The
x16 icon should not stop you from publishing the original SVG icon,
which is superb.

Kind regards,
Jean-Michel

signature.asc (205 bytes) Download Attachment

Re: unpleasant characters

2009-12-14T08:27:57Z

On Mon, Dec 14, 2009 at 3:07 PM, Ian Barwick <barwick@...> wrote:

> Hi
>
> A long-time lurker writes:
>
> 2009/12/14 Euler Taveira de Oliveira <euler@...>:
>> Dave Page escreveu:
>>> Do you know if this will have any unpleasant side-effects in Japan or
>>> other regions with what we would consider to be unusual keyboard
>>> layouts?
>>>
>>>
>> As I said, I don't know if we'll have problems with it; but if they map Fx key
>> to some character, they have trouble using our shortcuts anyway. Could Hiroshi
>> or someone else confirm this?
>
> The function keys on Japanese keyboards (I am typing on one right now)
> are not used for any special Japanese characters. They can be used when
> inputting Japanese to modify the input string, but any keypresses should be
> caught by the IME and not passed through to the underlying application.
> When inputting SQL, the keyboard would effectively be the same as a US
> keyboard. The same applies, AFAIK, to other East Asian languages.
>
> I also happen to have a Thai keyboard knocking around and the function
> keys are not used for anything special there either.

Thanks for the info Ian, that's good to know.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: unpleasant characters

2009-12-14T08:27:17Z

On Mon, Dec 14, 2009 at 2:02 PM, Euler Taveira de Oliveira
<euler@...> wrote:

> Dave Page escreveu:
>> Do you know if this will have any unpleasant side-effects in Japan or
>> other regions with what we would consider to be unusual keyboard
>> layouts?
>>
>>
> As I said, I don't know if we'll have problems with it; but if they map Fx key
> to some character, they have trouble using our shortcuts anyway. Could Hiroshi
> or someone else confirm this? If we have problems, I'm afraid the only path is
> coding OnChar() (which would be a pain in the neck because we'll have to
> maintain code that IMHO is WX responsibility).
>
> I noticed that even if we don't event.Skip() on OnKeyDown() event (the patch)
> the shortcut is executed (for example F5) maybe because it is caught by
> OnKeyUp(), another key event, or another object? I don't know how events are
> handled in WX but somehow OnKeyDown() are processed _before_ OnChar() so the
> character are not printed. Also, it didn't prevent another object (wxMenu) to
> capture that event too.
>
> Did you reproduce the problem?

Nope - cannot reproduce any problem here, but then my Windows machine
is running in vmware fusion which may not be helping matters.

Anyone else?

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: pgAdmin3 icon

2009-12-14T08:25:53Z

2009/12/14 Jean-Michel Pouré <jmpoure@...>:

> Sorry for not following the thread this week-end. I was away and now I
> am a little sick, so I have more time!
>>
>> As discussed, it doesn't scale down to 16x16 without becoming a mess,
>> so I presented the alternative as a simplification which does.
>
> Look at my screenshot:
> http://www.poure.com/images/capture.png
>
> The simplified logo does not scale down to 16x16 nor 32x32.

It does if done properly, which your file browser doesn't seem to be
doing. See the attached image, which shows the various Mac versions.

>> If you can come up with something better that does scale down, I'm
>> happy to look at it. As it happens, I've just seen that the new one
>> goes fuzzy when displayed on an XP style application bar, so it'll
>> have to be changed again anyway.
>
> It seems to me that Guillaume proposal scales pretty well to 16x16 and
> 32x32. I uploaded Guillaume's PNG icons there:
> http://www.poure.com/images/
>
> If you believe that the 16x16 icon does not scale well, why not
> concentrate only on this icon.

I'm not a good enough artist to fix something so small, except by
starting with something more simple at a larger size and then scaling
it down.

BTW, the second screenshot attached shows Guillaumes version of the
original 16x16 next to the simplified one.

> The other icons are (in my opinion) really superb. Just like pgAdmin3
> programming!
>
>> Are you at least happy that the SQL icon is an improvement over the
>> previous nasty blue one?
>
> Yes.
>

Cool. I just committed new versions of the XPMs with a little
transparency added to make them softer in line with the other toolbar
buttons.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Screen shot 2009-12-14 at 16.20.21.png (248K) Download Attachment
Screen shot 2009-12-14 at 16.22.37.png (12K) Download Attachment

SVN Commit by dpage: r8133 - trunk/pgadmin3/pgadmin/include/images

2009-12-14T08:19:40Z

Author: dpage

Date: 2009-12-14 16:19:40 +0000 (Mon, 14 Dec 2009)

New Revision: 8133

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8133&view=rev

Log:
Soften the SQL toolbar icon a little so it doesn't look out of place.

Modified:
trunk/pgadmin3/pgadmin/include/images/sql-16.xpm
trunk/pgadmin3/pgadmin/include/images/sql-32.xpm

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: pgAdmin3 icon

2009-12-14T08:17:06Z

Sorry for not following the thread this week-end. I was away and now I
am a little sick, so I have more time!
>
> As discussed, it doesn't scale down to 16x16 without becoming a mess,
> so I presented the alternative as a simplification which does.

Look at my screenshot:
http://www.poure.com/images/capture.png

The simplified logo does not scale down to 16x16 nor 32x32.

> If you can come up with something better that does scale down, I'm
> happy to look at it. As it happens, I've just seen that the new one
> goes fuzzy when displayed on an XP style application bar, so it'll
> have to be changed again anyway.

It seems to me that Guillaume proposal scales pretty well to 16x16 and
32x32. I uploaded Guillaume's PNG icons there:
http://www.poure.com/images/

If you believe that the 16x16 icon does not scale well, why not
concentrate only on this icon.

The other icons are (in my opinion) really superb. Just like pgAdmin3
programming!

> Are you at least happy that the SQL icon is an improvement over the
> previous nasty blue one?

Yes.

signature.asc (205 bytes) Download Attachment

SVN Commit by dpage: r8132 - in trunk/pgadmin3/pgadmin: dlg include/db

2009-12-14T07:54:28Z

Author: dpage

Date: 2009-12-14 15:54:28 +0000 (Mon, 14 Dec 2009)

New Revision: 8132

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8132&view=rev

Log:
Fix a couple of minor coding errors.

Modified:
trunk/pgadmin3/pgadmin/dlg/dlgClasses.cpp
trunk/pgadmin3/pgadmin/include/db/pgConn.h

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: pgAdmin3 icon

2009-12-14T07:28:49Z

2009/12/14 Jean-Michel Pouré <jmpoure@...>:
> Dear Dave, Guillaume and all,
>
> Here is a screenshot of the committed logos:
> http://www.poure.com/images/capture.png
>
> Sorry if I did not follow the discussions lately, but the outline logo
> does not look like anything usable. Frankly, I cannot stand this logo.
> It makes me shiver!

<sigh>

There was only a handful of messages, in the thread you started. You
could have at least kept half an eye on it and commented when I
submitted the logo for review.

> IMHO, we should stick to the SVG original version of the logo and commit
> ICO, PNG and SVG versions of the logo.
>
> The was a lot of work from the author of the original logo, we should
> preserve this work as far as possible, just adding a shadow.
>
> Here are my versions:
> http://www.poure.com/images/pgadmin3.svg
>
>
> Can we commit my SVG version and use Guillaume's PNGs which scaled down
> nicely? Dave what is your opinion? Do you believe that your simplified
> logo suits better pgAdmin?

As discussed, it doesn't scale down to 16x16 without becoming a mess,
so I presented the alternative as a simplification which does.

If you can come up with something better that does scale down, I'm
happy to look at it. As it happens, I've just seen that the new one
goes fuzzy when displayed on an XP style application bar, so it'll
have to be changed again anyway.

Are you at least happy that the SQL icon is an improvement over the
previous nasty blue one?

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@...)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers