Problem with subtitles, black on black
|
View:
New views
4 Messages
—
Rating Filter:
Alert me
|
 |
Problem with subtitles, black on black
by Jan Kardell
::
Rate this Message:
Hi,
When I made my first dvd, english subtitles were OK but the swedish subtitles became black on black. After some investigation I found this in the file dvdvob.c line 1229: if( (st&0xf8)==0x20 ) { // subtitle procremap(&crs[st&31],buf+dptr,ml-dptr,&s->audch[st].audpts[s->audch[st].numaudpts-1].pts[1]); } Masking with 0xf8 limits remapping of color indexes to the first 8 subtitle channels. After changing this to 0xe0 I got my subtitles visible again. I used dvdauthor-0.6.14. //Jan Kardell ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Dvdauthor-developer mailing list Dvdauthor-developer@... https://lists.sourceforge.net/lists/listinfo/dvdauthor-developer |
|
|
Re: Problem with subtitles, black on black
by Jan Kardell
::
Rate this Message:
Ping!
This fix would be nice to have in 0.6.15. As far as I can see it's not included, so the bug is on the same line number. //Jan Jan Kardell wrote: >Hi, > >When I made my first dvd, english subtitles were OK but the swedish subtitles became black on black. After some investigation I found this in the file dvdvob.c line 1229: > >if( (st&0xf8)==0x20 ) { // subtitle > procremap(&crs[st&31],buf+dptr,ml-dptr,&s->audch[st].audpts[s->audch[st].numaudpts-1].pts[1]); >} > >Masking with 0xf8 limits remapping of color indexes to the first 8 subtitle channels. After changing this to 0xe0 I got my subtitles visible again. I used dvdauthor-0.6.14. > >//Jan Kardell > > >------------------------------------------------------------------------- >This SF.net email is sponsored by DB2 Express >Download DB2 Express C - the FREE version of DB2 express and take >control of your XML. No limits. Just data. Click to get it now. >http://sourceforge.net/powerbar/db2/ >_______________________________________________ >Dvdauthor-developer mailing list >Dvdauthor-developer@... >https://lists.sourceforge.net/lists/listinfo/dvdauthor-developer > > > ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Dvdauthor-developer mailing list Dvdauthor-developer@... https://lists.sourceforge.net/lists/listinfo/dvdauthor-developer |
|
|
Re: Problem with subtitles, black on black
by Joo Martin-4
::
Rate this Message:
Hello!
---- Am Tue, 07 Apr 2009 18:57:49 +0200 schrieb Jan Kardell <jan.kardell@...>: > This fix would be nice to have in 0.6.15. As far as I can see it's not > included, so the bug is on the same line number. I hope another developer, perhaps Lawrence D'Oliveiro, can check your wish. I cannot do this. > Jan Kardell wrote: >> if( (st&0xf8)==0x20 ) { // subtitle >> procremap(&crs[st&31],buf+dptr,ml-dptr,&s->audch[st].audpts[s->audch[st].numaudpts-1].pts[1]); >> } >> >> Masking with 0xf8 limits remapping of color indexes to the first 8 sub- >> title channels. After changing this to 0xe0 I got my subtitles visible >> again. I used dvdauthor-0.6.14. Is there any disadvantage if we take this modification into the code? Have you tested it with some different runs? Ciao, Joo ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Dvdauthor-developer mailing list Dvdauthor-developer@... https://lists.sourceforge.net/lists/listinfo/dvdauthor-developer |
|
|
Re: Problem with subtitles, black on black
by Lawrence D'Oliveiro-2
::
Rate this Message:
Jan Kardell wrote:
> When I made my first dvd, english subtitles were OK but the swedish subtitles became black on black. After some investigation I found this in the file dvdvob.c line 1229: > > if( (st&0xf8)==0x20 ) { // subtitle > procremap(&crs[st&31],buf+dptr,ml-dptr,&s->audch[st].audpts[s->audch[st].numaudpts-1].pts[1]); > } > > Masking with 0xf8 limits remapping of color indexes to the first 8 subtitle channels. After changing this to 0xe0 I got my subtitles visible again. I used dvdauthor-0.6.14. In terms of confirming that this fix is correct, according to <http://www.mpucoder.com/DVD/dvdmpeg.html>, private stream 1 with substream IDs 0x20 .. 0x3f are subpictures. That is, the bottom 5 bits are the subpicture substream ID, while the top 3 bits should be binary 001. The mask 0xf8 is extracting the top 5 bits, which is clearly wrong. 0xe0 extracts the top 3 bits, which looks correct. ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Dvdauthor-developer mailing list Dvdauthor-developer@... https://lists.sourceforge.net/lists/listinfo/dvdauthor-developer |
| Free embeddable forum powered by Nabble | Forum Help |
