Problems/Fixes: Filemanager plugin and Squirrelmail 1.4.19

[Andreas-97]

Hello,

I updated to Squirrelmail 1.4.19 and it is not possible to add with the
"Add Attachment From File Manager" link in the compose screen more than
one file. All previous added attachments get lost.

The problem is in line 58 (compose.php):
----------------------------------------
// compose_messages only useful in SESSION when a forward-as-attachment
// has been preconstructed for us and passed in via that mechanism; once
// we have it, we can clear it from the SESSION
sqsession_unregister('compose_messages');

This will lead to the problem that in line 502 (file_manager.php):
------------------------------------------------------------------
sqgetGlobalVar('compose_messages', $compose_messages);

if (!isset($compose_messages)) {
  $compose_messages = array();
}

which every time creates a new array because compose_messages is
unregistered.

Is there a new way to get $composed_messages for $composeMessage or to
append to $composeMessage a new attachments without $composed_messages?
Can I remove the sqsession_unregister() in the compose.php without any
security issues to get the file_manager plugin working (I think GnuPG also
uses the same functionality)?

Second I have some fixes for the filemanager plugin for SM 1.4.19 and
QuickSave 2.4.2

In line 529 (file_manager.php):
-------------------------------
Change -> $composeMessage->initAttachment($type,
$_POST['attachmentFileName'], $full_localfilename);
To -> $composeMessage->initAttachment($type, $_POST['attachmentFileName'],
$localfilename);

The new compose function already adds the folder hash in front.

In line 48 (print_attach_from_file_manager_link.php):
-----------------------------------------------------
Change -> echo 'QuickSave_activate(false); ';
To -> echo 'quicksave_clear_storage(); ';

QuickSave_activate() is not available any more in QuickSave 2.4.2.


Used Squirrelmail: 1.4.19
Used Quicksave: 2.4.2
Used FileManager: 2.1 (Dev version by Paul Lesneiwski)

Regards,
Andreas


------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com 
-----
squirrelmail-plugins mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-plugins@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.plugins
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-plugins