R13A patches for os_mon on dragonfly

[G.Isenmann]

Hi, would it be possible to include these small patches into R13B? I
believe they have no side effect on other platforms and improve the
situation on dragonfly.

CC dragonfly-users:
 - The first patch is a copy of pkgsrc/wip/erlang/patches/patch-aa.
 - The others are probably also neccessary for both pkgsrc/lang/erlang
   (R12B) and pkgsrc/wip/erlang (R12B-5).
 - Noticed this while playing with rabbitmq.
 - Have ignored other patches from wip/erlang that probably need
   modifications for dragonfly but which do not look so simple (e.g.
   for erts/emulator/sys/unix/sys_float.c).

--
Goetz





_______________________________________________
erlang-patches mailing list
erlang-patches@...
http://www.erlang.org/mailman/listinfo/erlang-patches

[Mikael Pettersson-3]

G.Isenmann writes:
 > Hi, would it be possible to include these small patches into R13B? I
 > believe they have no side effect on other platforms and improve the
 > situation on dragonfly.
 >
 > CC dragonfly-users:
...
 >  - Have ignored other patches from wip/erlang that probably need
 >    modifications for dragonfly but which do not look so simple (e.g.
 >    for erts/emulator/sys/unix/sys_float.c).

I assume the sys_float.c stuff is related to FP exceptions on dragonfly.
You don't need FP exceptions if you ./configure --disable-hipe (which
should be the default since HiPE doesn't support that platform yet).

Enabling FP exceptions on a Unix-like OS involves writing sigaction()
handler code to inspect and modify the faulting mcontext. Unfortunately
that's an area where different OSes differ, so for OSes that we (as in
the Erlang/OTP and HiPE developers) don't have access to, it's up to the
users of those OSes to contribute the required code.
_______________________________________________
erlang-patches mailing list
erlang-patches@...
http://www.erlang.org/mailman/listinfo/erlang-patches

[Björn-Egil Dahlberg]

G.Isenmann wrote:
> Hi, would it be possible to include these small patches into R13B? I
> believe they have no side effect on other platforms and improve the
> situation on dragonfly.

Your patches seems straightforward enough. I will try to include them in
r13b.

We do not have any dragonfly os to try your patches on so they will be
included 'as-is' if it doesn't break any other code.

Regards,
Björn-Egil
Erlang/OTP, Ericsson AB
_______________________________________________
erlang-patches mailing list
erlang-patches@...
http://www.erlang.org/mailman/listinfo/erlang-patches

[Kenji Rikitake]

Dear Bjorn and the list members:

R13B as of 2009-04-11 is broken for FreeBSD 7.1-RELEASE.
Please fix it as proposed.

Kenji Rikitake

R13B snapshot of 2009-04-11
has broken lib/os_mon/c_src/memsup.c
for FreeBSD 7.1-RELEASE
by Kenji Rikitake 12-APR-2009

Symptom: compilation error on lib/os_mon/c_src/memsup.c

Possible reason:

memsup.c was mangled between R13A and R13B, while trying to
patch according to the "patch-aa" file in the following patch set
for DragonFly BSD:

http://erlang.org/pipermail/erlang-patches/2009-April/000395.html

Workaround:

Apply the patch "patch-aa" in the above article AS IS, as follows.

--- lib/os_mon/c_src/memsup.c.FCS 2009-04-08 18:57:44.000000000 +0900
+++ lib/os_mon/c_src/memsup.c 2009-04-12 15:50:34.000000000 +0900
@@ -114,11 +114,11 @@
 #include <sys/types.h>
 #include <sys/sysctl.h>
 #if !defined (__OpenBSD__) && !defined (__NetBSD__)
 #include <vm/vm_param.h>
 #endif
-#if defined (__FreeBSD__) && defined(__DragonFly__)
+#if defined (__FreeBSD__) || defined(__DragonFly__)
 #include <sys/vmmeter.h>
 #endif
 #endif
 
 #if defined (__linux__)
_______________________________________________
erlang-patches mailing list
erlang-patches@...
http://www.erlang.org/mailman/listinfo/erlang-patches

[Björn-Egil Dahlberg]

Hi,

The patch was applied by hand and a typo was introduced.
Never do something yourself that a machine can do better ...

The corrected version is now in r13b.

// Björn-Egil
    Erlang/OTP

Kenji Rikitake wrote:

> Dear Bjorn and the list members:
>
> R13B as of 2009-04-11 is broken for FreeBSD 7.1-RELEASE.
> Please fix it as proposed.
>
> Kenji Rikitake
>
> R13B snapshot of 2009-04-11
> has broken lib/os_mon/c_src/memsup.c
> for FreeBSD 7.1-RELEASE
> by Kenji Rikitake 12-APR-2009
>
> Symptom: compilation error on lib/os_mon/c_src/memsup.c
>
> Possible reason:
>
> memsup.c was mangled between R13A and R13B, while trying to
> patch according to the "patch-aa" file in the following patch set
> for DragonFly BSD:
>
> http://erlang.org/pipermail/erlang-patches/2009-April/000395.html
>
> Workaround:
>
> Apply the patch "patch-aa" in the above article AS IS, as follows.
>
> --- lib/os_mon/c_src/memsup.c.FCS 2009-04-08 18:57:44.000000000 +0900
> +++ lib/os_mon/c_src/memsup.c 2009-04-12 15:50:34.000000000 +0900
> @@ -114,11 +114,11 @@
>  #include <sys/types.h>
>  #include <sys/sysctl.h>
>  #if !defined (__OpenBSD__) && !defined (__NetBSD__)
>  #include <vm/vm_param.h>
>  #endif
> -#if defined (__FreeBSD__) && defined(__DragonFly__)
> +#if defined (__FreeBSD__) || defined(__DragonFly__)
>  #include <sys/vmmeter.h>
>  #endif
>  #endif
>  
>  #if defined (__linux__)

_______________________________________________
erlang-patches mailing list
erlang-patches@...
http://www.erlang.org/mailman/listinfo/erlang-patches