RE: [Issue 129] New - Failing to load rome.properties
|
View:
New views
8 Messages
—
Rating Filter:
Alert me
|
 |
|
|
|
Re: [Issue 129] New - Failing to load rome.properties
by Martin Kurz
::
Rate this Message:
Hi,
I think the suggested patch would really make it easier to switch to another classloader if the default behaviour doesn't work in any special environment. But as Nick allready mentioned, default behavior should be the same as before, so the default for "rome.use.thread.classloader" should be true, not false. As long as the default stays the same, I don't see any problems there. Of course it's getting more complicated, but implementing a fallback routine on many places would be more complicated (when extending for another Classloader for some other special case). Nick Lothian schrieb: > Does anyone have an opinion about this? I'm reluctant to complicate classloading with even more options, but the only other solution I can think of is to try the current behaviour, and if it fails to find the properties files then drop back to using the PropertiesLoader classloader. I don't think that solution is good either. > > If we implemented it we'd have to alter the patch to default to the current behaviour. > >> -----Original Message----- >> From: buckett@... [mailto:buckett@...] >> Sent: Monday, 20 April 2009 8:17 PM >> To: issues@... >> Subject: [Issue 129] New - Failing to load rome.properties >> >> https://rome.dev.java.net/issues/show_bug.cgi?id=129 >> Issue #|129 >> Summary|Failing to load rome.properties >> Component|rome >> Version|current >> Platform|Macintosh >> OS/Version|All >> URL|http://sakaiproject.org >> Status|NEW >> Status whiteboard| >> Keywords| >> Resolution| >> Issue type|DEFECT >> Priority|P3 >> Subcomponent|www >> Assigned to|issues@rome >> Reported by|buckett >> >> >> >> >> >> >> ------- Additional comments from buckett@... Mon Apr 20 >> 10:47:11 +0000 2009 ------- >> Currently we use an old version of rome, rome-fetcher in Sakai >> (http://sakaiproject.org) and I was looking as upgrading them to the >> latest >> version to them. Currently Sakai has complicated classloader setup. >> There is a >> description of it here. >> >> https://source.sakaiproject.org/svn/reference/trunk/docs/architecture/s >> akai_component.doc >> >> >> Sakai runs ontop of tomcat and each "component" has it's own >> classloader that >> child of the shared classloader. The API for the component goes in >> shared so >> that both the component and any webapp can access. The component then >> implements >> this APi. But the implementation code can't be accessed by the webapp >> as the >> component's classloader isn't a parent of the webapps. This prevents >> any webapps >> accessing anything in a component. >> >> Currently there is an API for getting RSS feeds which is implemented by >> a >> component containing rome. The problem is that when a webapp calls >> through to >> this component the thread classloader is still set to the webapp's so >> it >> attempts to load the master configuration file (rome.properties) from >> the >> webapp. This fails and causes rome to stop working. >> >> It would be useful if PropertiesLoader could use either the thread >> classloader >> or the classloader that loaded PropertiesLoader to load the >> configuration. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: issues-unsubscribe@... >> For additional commands, e-mail: issues-help@... > > > IMPORTANT: This e-mail, including any attachments, may contain private or confidential information. If you think you may not be the intended recipient, or if you have received this e-mail in error, please contact the sender immediately and delete all copies of this e-mail. If you are not the intended recipient, you must not reproduce any part of this e-mail or disclose its contents to any other party. This email represents the views of the individual sender, which do not necessarily reflect those of Education.au except where the sender expressly states otherwise. It is your responsibility to scan this email and any files transmitted with it for viruses or any other defects. education.au limited will not be liable for any loss, damage or consequence caused directly or indirectly by this email. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@... For additional commands, e-mail: dev-help@... |
|
|
Re: [Issue 129] New - Failing to load rome.properties
by Martin Kurz
::
Rate this Message:
Hi again,
there's one point I missed in previous mail: The change from default behaviour to another one should IMO be set explicitly (not by setting the default to false) like boolean usePropertiesLoader = Boolean.valueOf( System.getProperty( "rome.classloader.usePropertiesLoader", "false" ) ).booleanValue(); return (usePropertiesLoader) ? PropertiesLoader.class.getClassLoader() : Thread.currentThread().getContextClassLoader() ; This way, it would be easier to extend to other classloader configs. Greetings, martin Martin Kurz schrieb: > Hi, > > I think the suggested patch would really make it easier to switch to > another classloader if the default behaviour doesn't work in any special > environment. But as Nick allready mentioned, default behavior should be > the same as before, so the default for "rome.use.thread.classloader" > should be true, not false. As long as the default stays the same, I > don't see any problems there. Of course it's getting more complicated, > but implementing a fallback routine on many places would be more > complicated (when extending for another Classloader for some other > special case). > > Nick Lothian schrieb: >> Does anyone have an opinion about this? I'm reluctant to complicate >> classloading with even more options, but the only other solution I can >> think of is to try the current behaviour, and if it fails to find the >> properties files then drop back to using the PropertiesLoader >> classloader. I don't think that solution is good either. >> >> If we implemented it we'd have to alter the patch to default to the >> current behaviour. >> >>> -----Original Message----- >>> From: buckett@... [mailto:buckett@...] >>> Sent: Monday, 20 April 2009 8:17 PM >>> To: issues@... >>> Subject: [Issue 129] New - Failing to load rome.properties >>> >>> https://rome.dev.java.net/issues/show_bug.cgi?id=129 >>> Issue #|129 >>> Summary|Failing to load rome.properties >>> Component|rome >>> Version|current >>> Platform|Macintosh >>> OS/Version|All >>> URL|http://sakaiproject.org >>> Status|NEW >>> Status whiteboard| >>> Keywords| >>> Resolution| >>> Issue type|DEFECT >>> Priority|P3 >>> Subcomponent|www >>> Assigned to|issues@rome >>> Reported by|buckett >>> >>> >>> >>> >>> >>> >>> ------- Additional comments from buckett@... Mon Apr 20 >>> 10:47:11 +0000 2009 ------- >>> Currently we use an old version of rome, rome-fetcher in Sakai >>> (http://sakaiproject.org) and I was looking as upgrading them to the >>> latest >>> version to them. Currently Sakai has complicated classloader setup. >>> There is a >>> description of it here. >>> >>> https://source.sakaiproject.org/svn/reference/trunk/docs/architecture/s >>> akai_component.doc >>> >>> >>> Sakai runs ontop of tomcat and each "component" has it's own >>> classloader that >>> child of the shared classloader. The API for the component goes in >>> shared so >>> that both the component and any webapp can access. The component then >>> implements >>> this APi. But the implementation code can't be accessed by the webapp >>> as the >>> component's classloader isn't a parent of the webapps. This prevents >>> any webapps >>> accessing anything in a component. >>> >>> Currently there is an API for getting RSS feeds which is implemented by >>> a >>> component containing rome. The problem is that when a webapp calls >>> through to >>> this component the thread classloader is still set to the webapp's so >>> it >>> attempts to load the master configuration file (rome.properties) from >>> the >>> webapp. This fails and causes rome to stop working. >>> >>> It would be useful if PropertiesLoader could use either the thread >>> classloader >>> or the classloader that loaded PropertiesLoader to load the >>> configuration. >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: issues-unsubscribe@... >>> For additional commands, e-mail: issues-help@... >> >> >> IMPORTANT: This e-mail, including any attachments, may contain private >> or confidential information. If you think you may not be the intended >> recipient, or if you have received this e-mail in error, please >> contact the sender immediately and delete all copies of this e-mail. >> If you are not the intended recipient, you must not reproduce any part >> of this e-mail or disclose its contents to any other party. This email >> represents the views of the individual sender, which do not >> necessarily reflect those of Education.au except where the sender >> expressly states otherwise. It is your responsibility to scan this >> email and any files transmitted with it for viruses or any other >> defects. education.au limited will not be liable for any loss, damage >> or consequence caused directly or indirectly by this email. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@... > For additional commands, e-mail: dev-help@... > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@... For additional commands, e-mail: dev-help@... |
|
|
Re: [Issue 129] New - Failing to load rome.properties
by Sean-127
::
Rate this Message:
If you write that code, watch out for a NullPointerException.
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@... For additional commands, e-mail: dev-help@... |
|
|
RE: [Issue 129] New - Failing to load rome.properties
by jsbournival
::
Rate this Message:
So is there an official workaround? I am trying to write an atom feed in an OSGi container using Rome library bundled by Spring. But, it's throwing me the NPE:
<code> Caused by: java.lang.NullPointerException at java.util.Properties$LineReader.readLine(Properties.java:418) at java.util.Properties.load0(Properties.java:337) at java.util.Properties.load(Properties.java:325) at com.sun.syndication.io.impl.PropertiesLoader.<init>(PropertiesLoader.java:74) at com.sun.syndication.io.impl.PropertiesLoader.getPropertiesLoader(PropertiesLoader.java:46) at com.sun.syndication.io.impl.PluginManager.<init>(PluginManager.java:54) at com.sun.syndication.io.impl.PluginManager.<init>(PluginManager.java:46) at com.sun.syndication.io.impl.FeedGenerators.<init>(FeedGenerators.java:47) at com.sun.syndication.io.WireFeedOutput.getFeedGenerators(WireFeedOutput.java:53) at com.sun.syndication.io.WireFeedOutput.outputJDom(WireFeedOutput.java:262) at com.sun.syndication.io.WireFeedOutput.outputString(WireFeedOutput.java:118) at com.sun.syndication.io.WireFeedOutput.outputString(WireFeedOutput.java:97) </code> Thank you. JS. |
|
|
RE: [Issue 129] New - Failing to load rome.properties
by Nick Lothian
::
Rate this Message:
I'm not a OSGi user, but http://wiki.java.net/bin/view/Javawsxml/RomeAndOSGi may help:
From ROME 1.0 RC2 onwards, the ROME jar includes OSGi information in its manifest. Note that we have received some reports that ROME plugin classloading may cause problems with OSGi. Setting the system property "rome.pluginmanager.useloadclass" to "true" may help avoid this. See [[https://rome.dev.java.net/issues/show_bug.cgi?id=118][Issue 118] for further information. > -----Original Message----- > From: jsbournival [mailto:js@...] > Sent: Thursday, 28 May 2009 12:53 AM > To: dev@... > Subject: RE: [Issue 129] New - Failing to load rome.properties > > > So is there an official workaround? I am trying to write an atom feed > in an > OSGi container using Rome library bundled by Spring. But, it's > throwing me > the NPE: > > <code> > Caused by: java.lang.NullPointerException > at java.util.Properties$LineReader.readLine(Properties.java:418) > at java.util.Properties.load0(Properties.java:337) > at java.util.Properties.load(Properties.java:325) > at > com.sun.syndication.io.impl.PropertiesLoader.<init>(PropertiesLoader.ja > va:74) > at > com.sun.syndication.io.impl.PropertiesLoader.getPropertiesLoader(Proper > tiesLoader.java:46) > at > com.sun.syndication.io.impl.PluginManager.<init>(PluginManager.java:54) > at > com.sun.syndication.io.impl.PluginManager.<init>(PluginManager.java:46) > at > com.sun.syndication.io.impl.FeedGenerators.<init>(FeedGenerators.java:4 > 7) > at > com.sun.syndication.io.WireFeedOutput.getFeedGenerators(WireFeedOutput. > java:53) > at > com.sun.syndication.io.WireFeedOutput.outputJDom(WireFeedOutput.java:26 > 2) > at > com.sun.syndication.io.WireFeedOutput.outputString(WireFeedOutput.java: > 118) > at > com.sun.syndication.io.WireFeedOutput.outputString(WireFeedOutput.java: > 97) > </code> > > > Thank you. > > JS. > -- > View this message in context: http://www.nabble.com/RE%3A--Issue-129-- > New---Failing-to-load-rome.properties-tp23149514p23744788.html > Sent from the Rome - Development mailing list archive at Nabble.com. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@... > For additional commands, e-mail: dev-help@... IMPORTANT: This e-mail, including any attachments, may contain private or confidential information. If you think you may not be the intended recipient, or if you have received this e-mail in error, please contact the sender immediately and delete all copies of this e-mail. If you are not the intended recipient, you must not reproduce any part of this e-mail or disclose its contents to any other party. This email represents the views of the individual sender, which do not necessarily reflect those of Education.au except where the sender expressly states otherwise. It is your responsibility to scan this email and any files transmitted with it for viruses or any other defects. education.au limited will not be liable for any loss, damage or consequence caused directly or indirectly by this email. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@... For additional commands, e-mail: dev-help@... |
|
|
RE: [Issue 129] New - Failing to load rome.properties
by jsbournival
::
Rate this Message:
Thanks for the pointer.
On the other hand, setting "rome.pluginmanager.useloadclass" to "true" didn't helped. As I dug a bit further, I found that Rome is unable to retrieve its base properties. The fault happens in com.sun.syndication.io.impl.PropertiesLoader: InputStream is = classLoader.getResourceAsStream("com/sun/syndication/rome.properties"); Properties p = new Properties(); p.load(is); // Bam! NPE It's probably related to OSGi class loading mechanism, but I don't see the solution at this point. Maybe it's obvious to you guys? Thank you, JS.
|
|
|
RE: [Issue 129] New - Failing to load rome.properties
by Nick Lothian
::
Rate this Message:
It's certainly not obvious to me!
I'd suggest posting that code on a list for the OSGi container you use and see if they can see the problem. I'm happy to fix it once a solution is identified. I'd note that this appears to be the same code that is used to load ROME plugins in an OSGi environment, apparently successfully. There are some details of a change we made to enable plugin loading in OSGi here: https://rome.dev.java.net/issues/show_bug.cgi?id=118 Nick > -----Original Message----- > From: jsbournival [mailto:js@...] > Sent: Friday, 5 June 2009 12:55 AM > To: dev@... > Subject: RE: [Issue 129] New - Failing to load rome.properties > > > Thanks for the pointer. > > On the other hand, setting "rome.pluginmanager.useloadclass" to "true" > didn't helped. As I dug a bit further, I found that Rome is unable to > retrieve its base properties. The fault happens in > com.sun.syndication.io.impl.PropertiesLoader: > > InputStream is = > classLoader.getResourceAsStream("com/sun/syndication/rome.properties"); > Properties p = new Properties(); > p.load(is); // Bam! NPE > > It's probably related to OSGi class loading mechanism, but I don't see > the > solution at this point. Maybe it's obvious to you guys? > > Thank you, > > JS. > > > Nick Lothian wrote: > > > > I'm not a OSGi user, but > > http://wiki.java.net/bin/view/Javawsxml/RomeAndOSGi may help: > > > > From ROME 1.0 RC2 onwards, the ROME jar includes OSGi information in > its > > manifest. > > > > Note that we have received some reports that ROME plugin classloading > may > > cause problems with OSGi. Setting the system property > > "rome.pluginmanager.useloadclass" to "true" may help avoid this. See > > [[https://rome.dev.java.net/issues/show_bug.cgi?id=118][Issue 118] > for > > further information. > > > >> -----Original Message----- > >> From: jsbournival [mailto:js@...] > >> Sent: Thursday, 28 May 2009 12:53 AM > >> To: dev@... > >> Subject: RE: [Issue 129] New - Failing to load rome.properties > >> > >> > >> So is there an official workaround? I am trying to write an atom > feed > >> in an > >> OSGi container using Rome library bundled by Spring. But, it's > >> throwing me > >> the NPE: > >> > >> <code> > >> Caused by: java.lang.NullPointerException > >> at > java.util.Properties$LineReader.readLine(Properties.java:418) > >> at java.util.Properties.load0(Properties.java:337) > >> at java.util.Properties.load(Properties.java:325) > >> at > >> > com.sun.syndication.io.impl.PropertiesLoader.<init>(PropertiesLoader.ja > >> va:74) > >> at > >> > com.sun.syndication.io.impl.PropertiesLoader.getPropertiesLoader(Proper > >> tiesLoader.java:46) > >> at > >> > com.sun.syndication.io.impl.PluginManager.<init>(PluginManager.java:54) > >> at > >> > com.sun.syndication.io.impl.PluginManager.<init>(PluginManager.java:46) > >> at > >> > com.sun.syndication.io.impl.FeedGenerators.<init>(FeedGenerators.java:4 > >> 7) > >> at > >> > com.sun.syndication.io.WireFeedOutput.getFeedGenerators(WireFeedOutput. > >> java:53) > >> at > >> > com.sun.syndication.io.WireFeedOutput.outputJDom(WireFeedOutput.java:26 > >> 2) > >> at > >> > com.sun.syndication.io.WireFeedOutput.outputString(WireFeedOutput.java: > >> 118) > >> at > >> > com.sun.syndication.io.WireFeedOutput.outputString(WireFeedOutput.java: > >> 97) > >> </code> > >> > >> > >> Thank you. > >> > >> JS. > >> -- > >> View this message in context: http://www.nabble.com/RE%3A--Issue- > 129-- > >> New---Failing-to-load-rome.properties-tp23149514p23744788.html > >> Sent from the Rome - Development mailing list archive at Nabble.com. > >> > >> > >> -------------------------------------------------------------------- > - > >> To unsubscribe, e-mail: dev-unsubscribe@... > >> For additional commands, e-mail: dev-help@... > > > > > > IMPORTANT: This e-mail, including any attachments, may contain > private or > > confidential information. If you think you may not be the intended > > recipient, or if you have received this e-mail in error, please > contact > > the sender immediately and delete all copies of this e-mail. If you > are > > not the intended recipient, you must not reproduce any part of this > > or disclose its contents to any other party. This email represents > the > > views of the individual sender, which do not necessarily reflect > those of > > Education.au except where the sender expressly states otherwise. It > is > > your responsibility to scan this email and any files transmitted with > it > > for viruses or any other defects. education.au limited will not be > liable > > for any loss, damage or consequence caused directly or indirectly by > this > > email. > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscribe@... > > For additional commands, e-mail: dev-help@... > > > > > > > > -- > View this message in context: http://www.nabble.com/RE%3A--Issue-129-- > New---Failing-to-load-rome.properties-tp23149514p23872200.html > Sent from the Rome - Development mailing list archive at Nabble.com. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@... > For additional commands, e-mail: dev-help@... IMPORTANT: This e-mail, including any attachments, may contain private or confidential information. If you think you may not be the intended recipient, or if you have received this e-mail in error, please contact the sender immediately and delete all copies of this e-mail. If you are not the intended recipient, you must not reproduce any part of this e-mail or disclose its contents to any other party. This email represents the views of the individual sender, which do not necessarily reflect those of Education.au except where the sender expressly states otherwise. It is your responsibility to scan this email and any files transmitted with it for viruses or any other defects. education.au limited will not be liable for any loss, damage or consequence caused directly or indirectly by this email. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@... For additional commands, e-mail: dev-help@... |
| Free embeddable forum powered by Nabble | Forum Help |
