« Return to Thread: [jira] Created: (CARGO-419) Update redeploy method for Tomcat container to perform actual undeploy and deploy instead of reload

RE: [jira] Commented: (CARGO-419) Update redeploy method for Tomcat container to perform actual undeploy and deploy instead of reload

by vmassol :: Rate this Message:

Reply to Author | View in Thread

> -----Original Message-----
> From: Artamonov, Juri [mailto:jartamonov@...]
> Sent: lundi 16 octobre 2006 11:46
> To: dev@...
> Subject: RE: [cargo-dev] [jira] Commented: (CARGO-419) Update redeploy
> method for Tomcat container to perform actual undeploy and deploy
> instead of reload
>
> Vincent,
>
> What test do you mean? The issue that current content of redeploy
> method
> does different thing (I mean reload) instead of actual redeployment.

If it does a different thing than expected and the build is passing it means
there's currently no test for verifying if redeploy works...

The strategy that I think is best for Cargo is the following:

* when there's a bug, create a test that shows the bug
* fix the bug
* run the test again and it should pass

This will prevent to have any regression for all containers.

I need to dig it up but I think I started writing such a test but as I've
reinstalled my computer yesterday I need to look for it in my backups. Not
sure if I'll find it. Otherwise it should be relatively easy to recreate it:

* create an installed local container
* use a deployer to deploy a WAR to it

* verify it worked
* modify the WAR to add a new html file
* call redeploy
* verify that the new html file is accessible

WDYT?

Thanks
-Vincent

> -----Original Message-----
> From: Vincent Massol (JIRA) [mailto:jira@...]
> Sent: Monday, October 16, 2006 11:04 AM
> To: dev@...
> Subject: [cargo-dev] [jira] Commented: (CARGO-419) Update redeploy
> method for Tomcat container to perform actual undeploy and deploy
> instead of reload
>
>
> [
> http://jira.codehaus.org/browse/CARGO-419?page=comments#action_77714 ]
>
> Vincent Massol commented on CARGO-419:
> --------------------------------------
>
> Hi Juri,
>
> Thanks. It'll good to have first a test that fails, showing the error
> and then applying the patch and showing that it works.
>
> I'll have a look later in the week if you don't beat me to it...
>
> Thanks
> -Vincent
>
> > Update redeploy method for Tomcat container to perform actual
> undeploy
>
> > and deploy instead of reload
> >
> -----------------------------------------------------------------------
> -
> ---------------------------
> >
> > Key: CARGO-419
> > URL: http://jira.codehaus.org/browse/CARGO-419
> > Project: Cargo
> > Issue Type: Improvement
> > Components: Tomcat
> > Affects Versions: 0.8
> > Reporter: Juri Artamonov
> > Attachments: patch.txt
> >
> >
> > Update redeploy method for Tomcat container to perform actual
> undeploy
>
> > and deploy instead of reload. Current redeploy method contains call
> > for reload method of Tomcat Manager instead of performing undeploying
> > and deploying deployable.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://jira.codehaus.org/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list please visit:
>
> http://xircles.codehaus.org/manage_email
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list please visit:
>
> http://xircles.codehaus.org/manage_email

___________________________________________________________________________
Découvrez une nouvelle façon d'obtenir des réponses à toutes vos questions !
Demandez à ceux qui savent sur Yahoo! Questions/Réponses
http://fr.answers.yahoo.com

---------------------------------------------------------------------
To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email

« Return to Thread: [jira] Created: (CARGO-419) Update redeploy method for Tomcat container to perform actual undeploy and deploy instead of reload