RE: Bug in "svn:log" handling in SVNKit svnsync

> -----Original Message-----
> From: Alexander Sinyushkin [mailto:Alexander.Sinyushkin@...]
> Sent: Thursday, May 28, 2009 9:31 AM
> To: svnkit-users@...
> Subject: Re: Bug in "svn:log" handling in SVNKit svnsync
>
> Hello Greg,
>
> Thank you for pointing at this problem, I've found the problem and
> expect the fix to appear soon in trunk. I'll give you to know about
> that
> anyway.
> ----
> Alexander Sinyushkin,
> TMate Software,
> http://svnkit.com/ - Java [Sub]Versioning Library!
>
> Greg Gibeling wrote:
> > SVNKit 1.3.0, and I presume many past versions (based on the
> > contents of my repository backups), seems not to handle the "svn:log"
> > revprop correctly during doSynchronize().  In particular it seems to
> always
> > leave the "svn:log" blank.
> > The logic on lines 133-138 of SVNReplayHandler.java appears to be
> at
> > fault, though I've not yet been able to completely understand it.  In
> > particular the top half of the "if" special cases the author and date
> > revprops, but not the log, which I suspect it should.  I could be
> wrong
> > though as the second half of the if statement (where
> > myHasCommitRevPropsCapability is false) should never be entered
> because
> > unless I misunderstand how svnsync revprop changes are required for
> it to
> > work.
> > I should mention that the source server is SVN 1.4, so
> > replayRangeImpl() on SVNRepository exceptions out, and lines 2289-
> 2294 of
> > SVNRepository.java come into play.  The call to filterProperties()
> from
> > SVNReplayHandler.java line 116 is the one which seems to return
> incorrect
> > revprops, as after that call filtered contains "svn:date" and
> "svn:author"
> > but not "svn:log" though all three are in revisionProperties.
> >
> > Let me know if there's thing more I can do to help narrow this
> down.
> > Thanks in advance for looking into this.
> >
> > -Greg
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: svnkit-users-unsubscribe@...
> > For additional commands, e-mail: svnkit-users-help@...
> >
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svnkit-users-unsubscribe@...
> For additional commands, e-mail: svnkit-users-help@...