|
»
»
« Return to Thread: [pre vote take 3] 2.0.9-RC3
RE: CLI Properties vs. Model Properties (Was Re: [pre vote take 3] 2.0.9-RC3)
by Brian E Fox
::
Rate this Message:
We're actively discussing on IRC, but in my mind a correct fix is one
that fixes the root of the jira, which is that system properties where
hosing versions, and doesn't break more builds.
-----Original Message-----
From: paulus.benedictus@... [mailto:paulus.benedictus@...]
On Behalf Of Paul Benedict
Sent: Thursday, March 27, 2008 3:38 PM
To: Maven Developers List
Subject: Re: CLI Properties vs. Model Properties (Was Re: [pre vote take
3] 2.0.9-RC3)
Brian, what do you consider the correct fix? That CLI takes precedence
over
POM properties? I was trying to glean through this chain to find out
your
proposal.
Paul
On Thu, Mar 27, 2008 at 2:08 PM, Brian E. Fox <brianf@...>
wrote:
>
> >I can't see why overriding model values makes any sense from the
> >command line - that's not what Olivier wanted but rather a straight
> >substitution.
>
> You shouldn't be able to override model values for sure. I was saying
> that if something is defined on the CLI for everything else, it should
> take precedence.
>
> >The only change I can think of here is to have previous behaviourfrom
>
> >${version} and make sure ${project.version} is unaffected, but that's
> >a significant change to the interpolator.
>
> That's not promising.
>
> >I think we're better off leaving this fix in with something in the
> >release notes.
>
> I don't. We need to stop shoving incompatible changes down the user's
> throats. It shouldn't always require reworking of your poms to upgrade
> to the next maven version. That's annoying and wrong. If we do need to
> make changes, and I agree that forward progress must be made that
> sometimes breaks stuff, it should be deprecated first so people canget
> a chance to fix their poms.
>
> Based on the votes and comments in the issue, it's clear we can't just
> revert it either...We need to fix this correctly.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...
that fixes the root of the jira, which is that system properties where
hosing versions, and doesn't break more builds.
-----Original Message-----
From: paulus.benedictus@... [mailto:paulus.benedictus@...]
On Behalf Of Paul Benedict
Sent: Thursday, March 27, 2008 3:38 PM
To: Maven Developers List
Subject: Re: CLI Properties vs. Model Properties (Was Re: [pre vote take
3] 2.0.9-RC3)
Brian, what do you consider the correct fix? That CLI takes precedence
over
POM properties? I was trying to glean through this chain to find out
your
proposal.
Paul
On Thu, Mar 27, 2008 at 2:08 PM, Brian E. Fox <brianf@...>
wrote:
>
> >I can't see why overriding model values makes any sense from the
> >command line - that's not what Olivier wanted but rather a straight
> >substitution.
>
> You shouldn't be able to override model values for sure. I was saying
> that if something is defined on the CLI for everything else, it should
> take precedence.
>
> >The only change I can think of here is to have previous behaviour
>
> >${version} and make sure ${project.version} is unaffected, but that's
> >a significant change to the interpolator.
>
> That's not promising.
>
> >I think we're better off leaving this fix in with something in the
> >release notes.
>
> I don't. We need to stop shoving incompatible changes down the user's
> throats. It shouldn't always require reworking of your poms to upgrade
> to the next maven version. That's annoying and wrong. If we do need to
> make changes, and I agree that forward progress must be made that
> sometimes breaks stuff, it should be deprecated first so people can
> a chance to fix their poms.
>
> Based on the votes and comments in the issue, it's clear we can't just
> revert it either...We need to fix this correctly.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...
« Return to Thread: [pre vote take 3] 2.0.9-RC3
| Free embeddable forum powered by Nabble | Forum Help |
