RFS: colorcode

[Filippo Rusconi]

Dear mentors,

I am looking for a sponsor for my package "colorcode".

* Package name    : colorcode
  Version         : 0.5.5-1
  Upstream Author : Dirk Laebisch <dirk@...>
* URL             : http://colorcode.laebisch.com/
* License         : GPL-3
  Section         : games

It builds these binary packages:
colorcode  - advanced clone of the MasterMind code-breaking game

The package appears to be lintian clean.

The upload would fix these bugs: 553622

My motivation for maintaining this package is simply that this
implementation of the MasterMind code-breaking game is, in my opinion,
very good (and I've been looking for such a software since a pretty
long time).  I am using this program all the time and thus, I reason,
others might enjoy it in the Debian GNU/Linux distro.

The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/c/colorcode
- Source repository: deb-src http://mentors.debian.net/debian unstable
- main contrib non-free
- dget
- http://mentors.debian.net/debian/pool/main/c/colorcode/colorcode_0.5.5-1.dsc

I would be glad if someone uploaded this package for me.

Best regards,
                 Filippo

--
Filippo Rusconi, PhD - CNRS - public key C78F687C
Author of ``massXpert''     at http://www.massxpert.org

[Lionel Elie Mamane-2]

On Thu, Nov 05, 2009 at 11:22:42PM +0100, Filippo Rusconi wrote:
> I am looking for a sponsor for my package "colorcode".

> * Package name    : colorcode
>   Version         : 0.5.5-1
>   Upstream Author : Dirk Laebisch <dirk@...>
> * URL             : http://colorcode.laebisch.com/
> * License         : GPL-3
>   Section         : games

usr/share/pixmaps/colorcode32.xpm: neither gqview nor xli shows it
reasonably. xli complains with error messages like
 Bad color name '#A7ADAD00'


debian/rules:

        - $(MAKE) clean

The space after "-" keeps lintian from detecting this, but

W: colorcode source: debian-rules-ignores-make-clean-error line 32
N:
N:    A rule in the debian/rules file for this package calls the package's
N:    clean or distclean target with a line like:
N:    
N:     -$(MAKE) distclean
N:    or
N:     $(MAKE) -i distclean
N:    
N:    The leading "-" or the option -i tells make to ignore all errors.
N:    Normally this is done for packages using Autoconf since Makefile may not
N:    exist. However, this line ignores all other error messages, not just the
N:    missing Makefile error. It's better to use:
N:    
N:     [ ! -f Makefile ] || $(MAKE) distclean
N:    
N:    so that other error messages from the clean or distclean rule will still
N:    be caught (or just remove the "-" if the package uses a static
N:    makefile).
N:    
N:    Severity: normal, Certainty: certain
N:

Except for that, it looks OK.


--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Filippo Rusconi]

Hello, Lionel,

thanks for caring :-)

On Sun, Nov 08, 2009 at 03:21:19PM +0100, Lionel Elie Mamane wrote:

>
> On Thu, Nov 05, 2009 at 11:22:42PM +0100, Filippo Rusconi wrote:
> > I am looking for a sponsor for my package "colorcode".
>
> > * Package name    : colorcode
> >   Version         : 0.5.5-1
> >   Upstream Author : Dirk Laebisch <dirk@...>
> > * URL             : http://colorcode.laebisch.com/
> > * License         : GPL-3
> >   Section         : games
>
> usr/share/pixmaps/colorcode32.xpm: neither gqview nor xli shows it
> reasonably. xli complains with error messages like
>  Bad color name '#A7ADAD00'

OK, this one is odd :

I installed xli for the test and it ran flawlessly (displaying the pixmap
as expected):

$ xli /usr/share/pixmaps/colorcode32.xpm
/usr/share/pixmaps/colorcode32.xpm is a 32x32 X Pixmap image (Version
3) with 229 colors titled 'colorcode__'
  Default gamma for IRGB image is  2.20
  Compressing colormap...212 unique colors
  Using DirectColor visual
  Building XImage...done

I also opened it using Gwenview and The Gimp (which is in my
experience picky about file formats) without any warning/error
message.

I wonder what this odd behaviour is due to. Note that this xpm file is
created on the fly by calling convert on a .ico file. Maybe the
conversion failed, somehow ? I am attaching the file so that you may
try it on your box.

>
> debian/rules:
>
> - $(MAKE) clean
>
> The space after "-" keeps lintian from detecting this, but
>
> W: colorcode source: debian-rules-ignores-make-clean-error line 32
> N:
> N:    A rule in the debian/rules file for this package calls the package's
> N:    clean or distclean target with a line like:
> N:    
> N:     -$(MAKE) distclean
> N:    or
> N:     $(MAKE) -i distclean
> N:    
> N:    The leading "-" or the option -i tells make to ignore all errors.
> N:    Normally this is done for packages using Autoconf since Makefile may not
> N:    exist. However, this line ignores all other error messages, not just the
> N:    missing Makefile error. It's better to use:
> N:    
> N:     [ ! -f Makefile ] || $(MAKE) distclean
> N:    
> N:    so that other error messages from the clean or distclean rule will still
> N:    be caught (or just remove the "-" if the package uses a static
> N:    makefile).
> N:    
> N:    Severity: normal, Certainty: certain
> N:

Thanks for this one. Fixed.

> Except for that, it looks OK.

Great !

Please, note that the lintian -iEI --pedantic run on the package
complains about the man page since one day (yesterday it did not
complain at all).

Apparently there is a bug in either col or man with respect to
character codes depending on the encoding of the man page. Please have
a look at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=555330.

I am uploading the modified package.

Thanks again !

Ciao,
                 Filippo

--
Filippo Rusconi, PhD - CNRS - public key C78F687C
Author of ``massXpert''     at http://www.massxpert.org

[Lionel Elie Mamane-2]

On Mon, Nov 09, 2009 at 11:28:08PM +0100, Filippo Rusconi wrote:
> On Sun, Nov 08, 2009 at 03:21:19PM +0100, Lionel Elie Mamane wrote:
>> On Thu, Nov 05, 2009 at 11:22:42PM +0100, Filippo Rusconi wrote:

>>> I am looking for a sponsor for my package "colorcode".

>>> * Package name    : colorcode
>>>   Version         : 0.5.5-1
>>>   Upstream Author : Dirk Laebisch <dirk@...>
>>> * URL             : http://colorcode.laebisch.com/
>>> * License         : GPL-3
>>>   Section         : games

>> usr/share/pixmaps/colorcode32.xpm: neither gqview nor xli shows it
>> reasonably. xli complains with error messages like
>>  Bad color name '#A7ADAD00'

> OK, this one is odd :

> I installed xli for the test and it ran flawlessly (displaying the
> pixmap as expected):

> I wonder what this odd behaviour is due to.

Probably different versions of ImageMagick. With imagemagick
7:6.3.7.9.dfsg2-1~lenny3, I get a (slightly) different results than
yours (difference only visible under zoom), but an image that displays
nicely. With... Ah, my other machine has
graphicsmagick-imagemagick-compat and not imagemagick. Filing a
bug. In the meantime, let's build-conflict on
graphicsmagick-imagemagick-compat.

You don't ship anything in /usr/bin, so why have that directory
created (by debian/colorcode.dirs)? Ah no, actually you don't create
it because you don't call dh_installdirs, but then why do you have a
debian/colocode.dirs file?

--
Lionel


--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...