RRDtool 1.3.3 is out (font selection crash fix)

[Tobias Oetiker-3]

Users!

While 1.3.2 did fix the data corruption bug, and was much faster
with creating graphs, it did break badly when you tried to supply
your own font names and sizes. 1.3.3 fixes this regression.

Get it from  http://oss.oetiker.ch/rrdtool/

Changes
=======

* Do not crash when user tries to select a font in rrdgraph
* Another attempt at makeing it compile out-of-the box on solaris 8


Brought to you by the 2008 RRDtool sponsors:
-----------------------------------------------------------
GOLD:   http://www.groundworkopensource.com
        http://www.zenoss.com
SILVER: http://www.hosteurope.de http://www.atc-onlane.com
        http://www.terreactive.ch http://www.google.com
        http://www.hitflip.de http://www.op5.com
        http://www.lancope.com http://www.sidarion.ch
-----------------------------------------------------------

--
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten
http://it.oetiker.ch tobi@... ++41 62 213 9902

_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[Fidelis Assis]

Hi Tobi,

Tobias Oetiker escreveu:
> Fidelis,
>
> thanks ... I have integrated the patch and tried to fix the prefix
> issues .... when I try to build on my hardy setup, it does not seem
> to work though ...
>
> a) lua does not get picked up for building automatically even
>    though I have lua and liblua-dev installed

Probably because of an old version - see below.

>
> b) when I run make lua in the bindings directory I get
>
> oetiker> make lua
> cd lua && /usr/bin/lua Makefile.lua "PREFIX=/usr/local/rrdtool-1.3.2 POD2MAN=/usr/bin/pod2man LUABIN=/usr/bin/lua LIB=/usr/local/rrdtool-1.3.2/lib/lua" > Makefile && make
> /usr/bin/lua: Makefile.lua:3: attempt to call field `match' (a nil value)

The 'match' function in string lib was introduced in Lua 5.1 - minimum
required for RRDLua -, so it seems you have 5.0 or older. And I have a
broken code to check Lua version... Sorry for that, I'll fix it and send
a patch.

BTW, is there a standard way to check version in autoconf?  I'm just
starting to play with autoconf.

--
Fidelis

_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[Tobias Oetiker-3]

Hi Fidelis,

Yesterday Fidelis Assis wrote:

> Hi Tobi,
>
> Tobias Oetiker escreveu:
> > Fidelis,
> >
> > thanks ... I have integrated the patch and tried to fix the prefix
> > issues .... when I try to build on my hardy setup, it does not seem
> > to work though ...
> >
> > a) lua does not get picked up for building automatically even
> >    though I have lua and liblua-dev installed
>
> Probably because of an old version - see below.

I am running hardy which seems to be a pretty current linux
distro. So if you can by any means make it compile with lua 5.0 or
even lower, this would make this contribution much more interesting
to other people since they could actually run it ...

> > b) when I run make lua in the bindings directory I get
> >
> > oetiker> make lua
> > cd lua && /usr/bin/lua Makefile.lua "PREFIX=/usr/local/rrdtool-1.3.2 POD2MAN=/usr/bin/pod2man LUABIN=/usr/bin/lua LIB=/usr/local/rrdtool-1.3.2/lib/lua" > Makefile && make
> > /usr/bin/lua: Makefile.lua:3: attempt to call field `match' (a nil value)
>
> The 'match' function in string lib was introduced in Lua 5.1 - minimum
> required for RRDLua -, so it seems you have 5.0 or older. And I have a
> broken code to check Lua version... Sorry for that, I'll fix it and send
> a patch.
>
> BTW, is there a standard way to check version in autoconf?  I'm just
> starting to play with autoconf.

some libraries have a function call to figure the library, maybe
this exists in lua, then you can use this ...

cheers
tobi


>
>

--
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi@... ++41 62 775 9902 / sb: -9900

_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[Fidelis Assis]

Hi Tobi,

On Tue, Sep 23, 2008 at 1:53 AM, Tobias Oetiker <tobi@...> wrote:

> Hi Fidelis,
>
> Yesterday Fidelis Assis wrote:
>
>> Hi Tobi,
>>
>> Tobias Oetiker escreveu:
>> > Fidelis,
>> >
>> > thanks ... I have integrated the patch and tried to fix the prefix
>> > issues .... when I try to build on my hardy setup, it does not seem
>> > to work though ...
>> >
>> > a) lua does not get picked up for building automatically even
>> >    though I have lua and liblua-dev installed
>>
>> Probably because of an old version - see below.
>
> I am running hardy which seems to be a pretty current linux
> distro. So if you can by any means make it compile with lua 5.0 or
> even lower, this would make this contribution much more interesting
> to other people since they could actually run it ...

I have not used lua 5.0 since 5.1 was released, but OK, I'll get back
to  5.0 and try to make code compatible with both versions.

Lua 5.1 introduced nice changes, including a new module system, which
make keeping compatibility somewhat harder. It also seems that 5.1 is
becoming the de facto standard for Lua. For instance, the number of
packages in hardy for 5.1 is 36 while only 2 for 5.0 - not counting
the language itself and virtual packages.

>
>> > b) when I run make lua in the bindings directory I get
>> >
>> > oetiker> make lua
>> > cd lua && /usr/bin/lua Makefile.lua "PREFIX=/usr/local/rrdtool-1.3.2 POD2MAN=/usr/bin/pod2man LUABIN=/usr/bin/lua LIB=/usr/local/rrdtool-1.3.2/lib/lua" > Makefile && make
>> > /usr/bin/lua: Makefile.lua:3: attempt to call field `match' (a nil value)
>>
>> The 'match' function in string lib was introduced in Lua 5.1 - minimum
>> required for RRDLua -, so it seems you have 5.0 or older. And I have a
>> broken code to check Lua version... Sorry for that, I'll fix it and send
>> a patch.
>>
>> BTW, is there a standard way to check version in autoconf?  I'm just
>> starting to play with autoconf.
>
> some libraries have a function call to figure the library, maybe
> this exists in lua, then you can use this ...

Thanks, but I meant some macro that checks a version string and
returns OK if it's greater than or equal to a given minimum version.

OBS: I'm still using gutsy, but in the process of installing hardy. I
hope to have news by the weekend.

Regards,
--
Fidelis Assis

_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[Fidelis Assis]

Tobi,

Tobias Oetiker escreveu:

> Hi Fidelis,
>
> Yesterday Fidelis Assis wrote:
>
>> Hi Tobi,
>>
>> Tobias Oetiker escreveu:
>>> Fidelis,
>>>
>>> thanks ... I have integrated the patch and tried to fix the prefix
>>> issues .... when I try to build on my hardy setup, it does not seem
>>> to work though ...
>>>
>>> a) lua does not get picked up for building automatically even
>>>    though I have lua and liblua-dev installed
>> Probably because of an old version - see below.
>
> I am running hardy which seems to be a pretty current linux
> distro. So if you can by any means make it compile with lua 5.0 or
> even lower, this would make this contribution much more interesting
> to other people since they could actually run it ...

This new patch adds support to Lua 5.0. It should apply cleanly to trunk
rev 1578:

Files changed:
 configure.ac
 doc/rrdlua.pod
 bindings/Makefile.am
 bindings/lua/README
 bindings/lua/rrdlua.c

Files removed:
 bindings/lua/Makefile.lua
 bindings/lua/test.lua

Files added:
 bindings/lua/Makefile.lua.in
 bindings/lua/test.lua.bottom
 bindings/lua/compat-5.1r5/compat-5.1.c
 bindings/lua/compat-5.1r5/compat-5.1.h
 bindings/lua/compat-5.1r5/compat-5.1.lua


Please, let me know if it's OK or needs any changes.

Regards,
--
Fidelis Assis



_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[Tobias Oetiker-3]

Hi Fidelis,

Today Fidelis Assis wrote:

> This new patch adds support to Lua 5.0. It should apply cleanly to trunk
> rev 1578:
[...]
> Please, let me know if it's OK or needs any changes.

applies and compiles fine. There is one snag, when linking
rrd-0.0.9.so it does not seem to put the -rpath setting in place.

this is a problem when you do not install rrdtool into a
non-standard location, since then rrd.so will not find librrd.so
...

in the docs you may want to use INSTALL_PREFIX instead of
/usr/local/rrdtool-1.3.2

in the Makefile you are using many gcc-like options (-fPIC) this
will beome a problem when compiling with a non gcc compiler. Can't
you use libtool or at least get the relevant options from the
installed lua instance (perl does it this way).

cheers
tobi


> Regards,
>

--
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi@... ++41 62 775 9902 / sb: -9900

_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[kevin brintnall]

On Mon, Oct 06, 2008 at 12:02:32AM -0300, Fidelis Assis wrote:
> This new patch adds support to Lua 5.0. It should apply cleanly to trunk
> rev 1578:

I can't build from the current /trunk@r1579 source due to missing file:

% ./MakeMakefile
...
configure.ac:877: required file `bindings/lua/Makefile.lua.in' not found

% ./configure --disable-lua
...
config.status: creating bindings/tcl/Makefile
config.status: creating bindings/tcl/ifOctets.tcl
config.status: error: cannot find input file: Makefile.in

> Files removed:
> ...
>  bindings/lua/Makefile.lua
> ...
> Files added:
>  bindings/lua/Makefile.lua.in

Was this patch only half applied?  I see some of the other changes
(i.e. to configure.ac), but no Makefile.lua.in.

In any case, the following patch fixes the trunk so it will build.

--
 kevin brintnall =~ /kbrint@.../

-----------------------------------------------------------------

--- a/configure.ac
+++ b/configure.ac
@@ -874,7 +874,7 @@ AC_CONFIG_FILES([bindings/Makefile])
 AC_CONFIG_FILES([bindings/tcl/Makefile])
 AC_CONFIG_FILES([bindings/tcl/ifOctets.tcl])
 AC_CONFIG_FILES([Makefile])          
-AC_CONFIG_FILES([bindings/lua/Makefile.lua])
+dnl AC_CONFIG_FILES([bindings/lua/Makefile.lua])
 
 AC_CONFIG_COMMANDS([default],[[ chmod +x examples/*.pl]],[[]])
 AC_OUTPUT

_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[Tobias Oetiker-3]

Kevin,

thanks

fixed it ...

cheers
tobi


Today kevin brintnall wrote:

> On Mon, Oct 06, 2008 at 12:02:32AM -0300, Fidelis Assis wrote:
> > This new patch adds support to Lua 5.0. It should apply cleanly to trunk
> > rev 1578:
>
> I can't build from the current /trunk@r1579 source due to missing file:
>
> % ./MakeMakefile
> ...
> configure.ac:877: required file `bindings/lua/Makefile.lua.in' not found
>
> % ./configure --disable-lua
> ...
> config.status: creating bindings/tcl/Makefile
> config.status: creating bindings/tcl/ifOctets.tcl
> config.status: error: cannot find input file: Makefile.in
>
> > Files removed:
> > ...
> >  bindings/lua/Makefile.lua
> > ...
> > Files added:
> >  bindings/lua/Makefile.lua.in
>
> Was this patch only half applied?  I see some of the other changes
> (i.e. to configure.ac), but no Makefile.lua.in.
>
> In any case, the following patch fixes the trunk so it will build.
>
>

--
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi@... ++41 62 775 9902 / sb: -9900

_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[Fidelis Assis]

Tobias Oetiker escreveu:

> Hi Fidelis,
>
> Today Fidelis Assis wrote:
>
>> This new patch adds support to Lua 5.0. It should apply cleanly to trunk
>> rev 1578:
> [...]
>> Please, let me know if it's OK or needs any changes.
>
> applies and compiles fine. There is one snag, when linking
> rrd-0.0.9.so it does not seem to put the -rpath setting in place.
>
> this is a problem when you do not install rrdtool into a
> non-standard location, since then rrd.so will not find librrd.so

Isn't -rpath a libtool option? I didn't use libtool in my patch. I've
started using Autotools a few weeks and haven't got to libtool yet - I'm
still in autoconf :-). Anyway, is that the meaning of -rpath? I thought
it just tells libtool where your library will be installed, not where to
find others.

> ...
>
> in the docs you may want to use INSTALL_PREFIX instead of
> /usr/local/rrdtool-1.3.2

OK.

>
> in the Makefile you are using many gcc-like options (-fPIC) this
> will beome a problem when compiling with a non gcc compiler. Can't
> you use libtool or at least get the relevant options from the
> installed lua instance (perl does it this way).

Unfortunately Lua doesn't have that option, but libtool is in my todo
list. Thanks for the suggestions.

Regards
--
Fidelis Assis

_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[Fidelis Assis]

kevin brintnall escreveu:

> On Mon, Oct 06, 2008 at 12:02:32AM -0300, Fidelis Assis wrote:
>> This new patch adds support to Lua 5.0. It should apply cleanly to trunk
>> rev 1578:
>
> I can't build from the current /trunk@r1579 source due to missing file:
>
> % ./MakeMakefile
> ...
> configure.ac:877: required file `bindings/lua/Makefile.lua.in' not found
>
> % ./configure --disable-lua
> ...
> config.status: creating bindings/tcl/Makefile
> config.status: creating bindings/tcl/ifOctets.tcl
> config.status: error: cannot find input file: Makefile.in
>
>> Files removed:
>> ...
>>  bindings/lua/Makefile.lua
>> ...
>> Files added:
>>  bindings/lua/Makefile.lua.in
>
> Was this patch only half applied?  I see some of the other changes
> (i.e. to configure.ac), but no Makefile.lua.in.

Sorry, I don't know what happened... the patch was supposed to remove
Makefile.lua and add  Makefile.lua.in. The line you commented out is
necessary though, although it doesn't make sense when Lua is not enabled
- the same is valid for tcl files as well. I'll check if it can be moved
inside the if where enable_lua == yes.

--
Fidelis Assis

_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[Tobias Oetiker-3]

Hi Fidelis,

> > applies and compiles fine. There is one snag, when linking
> > rrd-0.0.9.so it does not seem to put the -rpath setting in place.
> >
> > this is a problem when you do not install rrdtool into a
> > non-standard location, since then rrd.so will not find librrd.so
>
> Isn't -rpath a libtool option? I didn't use libtool in my patch. I've
> started using Autotools a few weeks and haven't got to libtool yet - I'm
> still in autoconf :-). Anyway, is that the meaning of -rpath? I thought
> it just tells libtool where your library will be installed, not where to
> find others.
>
> > ...
> >
> > in the docs you may want to use INSTALL_PREFIX instead of
> > /usr/local/rrdtool-1.3.2
>
> OK.
>
> >
> > in the Makefile you are using many gcc-like options (-fPIC) this
> > will beome a problem when compiling with a non gcc compiler. Can't
> > you use libtool or at least get the relevant options from the
> > installed lua instance (perl does it this way).
>
> Unfortunately Lua doesn't have that option, but libtool is in my todo
> list. Thanks for the suggestions.

yes rpath is for this ... you may also want to look at Makefile.PL
for perl, there I change the rpath aequivalent depending on the OS
... for solaris it is -R....

cheers
tobi


> Regards
>

--
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi@... ++41 62 775 9902 / sb: -9900

_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[Fidelis Assis]

Tobias Oetiker escreveu:

>>> in the docs you may want to use INSTALL_PREFIX instead of
>>> /usr/local/rrdtool-1.3.2
>> OK.
>>
>>> in the Makefile you are using many gcc-like options (-fPIC) this
>>> will beome a problem when compiling with a non gcc compiler. Can't
>>> you use libtool or at least get the relevant options from the
>>> installed lua instance (perl does it this way).
>> Unfortunately Lua doesn't have that option, but libtool is in my todo
>> list. Thanks for the suggestions.
>
> yes rpath is for this ... you may also want to look at Makefile.PL
> for perl, there I change the rpath aequivalent depending on the OS
> ... for solaris it is -R....

- Lua module build and install process rewritten using automake+libtool
- improved check for compat-5.1 availability

It should apply OK to trunk rev 1620.

--
Fidelis Assis



_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[Sebastian Harl-2]

Hi Fidelis,

The source files of the Lua bindings include compat-5.1. The copyright
information of those files include the copyright holder only but no
license information:

  Copyright Kepler Project 2004-2006 (http://www.keplerproject.org/compat)

According to the website [1], those files seem to be released under some
BSDish license. Could you please verify that and include that
information in the header of the sources files?

Thanks a lot in advance!

Cheers,
Sebastian

[1] http://www.keplerproject.org/compat/license.html

--
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin



_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[Tobias Oetiker-3]

Hi Sebastian,

thanks ... added ....

cheers
tobi
Today Sebastian Harl wrote:

> Hi Fidelis,
>
> The source files of the Lua bindings include compat-5.1. The copyright
> information of those files include the copyright holder only but no
> license information:
>
>   Copyright Kepler Project 2004-2006 (http://www.keplerproject.org/compat)
>
> According to the website [1], those files seem to be released under some
> BSDish license. Could you please verify that and include that
> information in the header of the sources files?
>
> Thanks a lot in advance!
>
> Cheers,
> Sebastian
>
> [1] http://www.keplerproject.org/compat/license.html
>
>

--
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi@... ++41 62 775 9902 / sb: -9900

_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[Fidelis Assis]

Hi Sebastian,

Sebastian Harl escreveu:

> Hi Fidelis,
>
> The source files of the Lua bindings include compat-5.1. The copyright
> information of those files include the copyright holder only but no
> license information:
>
>   Copyright Kepler Project 2004-2006 (http://www.keplerproject.org/compat)
>
> According to the website [1], those files seem to be released under some
> BSDish license. Could you please verify that and include that
> information in the header of the sources files?

Of course, but it seems Tobi has just done that. Thanks Tobi!

--
Fidelis


_______________________________________________
rrd-developers mailing list
rrd-developers@...
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers