RTLD_DI_LINKMAP

View: New views
4 Messages — Rating Filter:   Alert me  

RTLD_DI_LINKMAP

by Mark Davies-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

wip/jdk16 fails to build on recent 5.0_STABLE (and presumably
recent -currents) with this error

.../wip/jdk16/work.i386/hotspot/src/os/bsd/vm/os_bsd.cpp:1959:
error: 'Link_map' was not declared in this scope
.../wip/jdk16/work.i386/hotspot/src/os/bsd/vm/os_bsd.cpp:1959: error: 'map
' was not declared in this scope

this is because RTLD_DI_LINKMAP has been added but no definition of the
Link_map structure is provided in the standard headers.  How should this
be dealt with?

cheers
mark

Re: RTLD_DI_LINKMAP

by Christos Zoulas-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

In article <200911050036.24876.mark@...>,
Mark Davies  <mark@...> wrote:

>wip/jdk16 fails to build on recent 5.0_STABLE (and presumably
>recent -currents) with this error
>
>.../wip/jdk16/work.i386/hotspot/src/os/bsd/vm/os_bsd.cpp:1959:
>error: 'Link_map' was not declared in this scope
>.../wip/jdk16/work.i386/hotspot/src/os/bsd/vm/os_bsd.cpp:1959: error: 'map
>' was not declared in this scope
>
>this is because RTLD_DI_LINKMAP has been added but no definition of the
>Link_map structure is provided in the standard headers.  How should this
>be dealt with?

Isn't there a link.h and link_elf.h on 5.0? If not, they should be pulled
up or the change to dlfcn.h should be reverted.

christos


Re: RTLD_DI_LINKMAP

by Tobias Nygren-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Thu, 5 Nov 2009 00:36:24 +1300
Mark Davies <mark@...> wrote:

> wip/jdk16 fails to build on recent 5.0_STABLE (and presumably
> recent -currents) with this error
>
> .../wip/jdk16/work.i386/hotspot/src/os/bsd/vm/os_bsd.cpp:1959:
> error: 'Link_map' was not declared in this scope
> .../wip/jdk16/work.i386/hotspot/src/os/bsd/vm/os_bsd.cpp:1959: error: 'map
> ' was not declared in this scope
>
> this is because RTLD_DI_LINKMAP has been added but no definition of the
> Link_map structure is provided in the standard headers.  How should this
> be dealt with?

#if defined(__NetBSD__) && defined(RTLD_DI_LINKMAP)
typedef struct link_map Link_map;
#endif

(from pkgsrc/lang/openjdk7/patches/patch-aa)

Re: RTLD_DI_LINKMAP

by Antti Kantee-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, Nov 04, 2009 at 07:31:49PM +0100, Tobias Nygren wrote:

> On Thu, 5 Nov 2009 00:36:24 +1300
> Mark Davies <mark@...> wrote:
>
> > wip/jdk16 fails to build on recent 5.0_STABLE (and presumably
> > recent -currents) with this error
> >
> > .../wip/jdk16/work.i386/hotspot/src/os/bsd/vm/os_bsd.cpp:1959:
> > error: 'Link_map' was not declared in this scope
> > .../wip/jdk16/work.i386/hotspot/src/os/bsd/vm/os_bsd.cpp:1959: error: 'map
> > ' was not declared in this scope
> >
> > this is because RTLD_DI_LINKMAP has been added but no definition of the
> > Link_map structure is provided in the standard headers.  How should this
> > be dealt with?
>
> #if defined(__NetBSD__) && defined(RTLD_DI_LINKMAP)
> typedef struct link_map Link_map;
> #endif
>
> (from pkgsrc/lang/openjdk7/patches/patch-aa)

... or we could just add this to link_elf.h, which is what I've done.

I'll request a pullup to netbsd-5.  Since RTLD_DI_LINKMAP wasn't
yet in any release, I think all patches of the above sort can just
be removed without any further trickery.