« Return to Thread: Re: RFR : 7149608 (tz): Default TZ detection fails on linux when symbolic links to non default location used.

Re: <i18n dev> RFR : 7149608 (tz): Default TZ detection fails on linux when symbolic links to non default location used.

by Alan Bateman :: Rate this Message:

| View in Thread

On 09/03/2012 16:00, Seán Coffey wrote:

> Issue seen on somewhat irregular linux system configuration where
> /etc/localtime is a symbolic link to a directory outside of
> /usr/share/zoneinfo.
>
> In past, when a symbolic link was seen, the end target file was
> assumed to be under /usr/share/zoneinfo and a string comparison match
> was attempted. We need to factor in the case where symbolic link
> points to any other location and match the end target file with a TZ
> file from
> /usr/share/zoneinfo via findZoneinfoFile function.
>
> webrev : http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8/
> bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7149608
>
> regards,
> Sean.
>
cc'ing i18n-dev as that is where the TZ code is maintained.

The changes look okay but I think it would be more efficient to fstat
the zone info file after opening it.

-Alan

 « Return to Thread: Re: RFR : 7149608 (tz): Default TZ detection fails on linux when symbolic links to non default location used.