Re: [59742] trunk/dports/devel/dbus/Portfile

[Ryan Schmidt-24]

On Oct 21, 2009, at 10:01, jmr@... wrote:

> Revision: 59742
>          http://trac.macports.org/changeset/59742
> Author:   jmr@...
> Date:     2009-10-21 08:01:41 -0700 (Wed, 21 Oct 2009)
> Log Message:
> -----------
> dbus: fix build dependencies (#21654)
>
> Modified Paths:
> --------------
>    trunk/dports/devel/dbus/Portfile
>
> Modified: trunk/dports/devel/dbus/Portfile
> ===================================================================
> --- trunk/dports/devel/dbus/Portfile 2009-10-21 14:54:49 UTC (rev  
> 59741)
> +++ trunk/dports/devel/dbus/Portfile 2009-10-21 15:01:41 UTC (rev  
> 59742)
> @@ -30,8 +30,6 @@
>                 0005-dont-dup-closed-stdin.patch
> patch.pre_args  -p1
>
> -use_autoreconf  yes
> -
> depends_build       \
>     port:pkgconfig
>
> @@ -41,6 +39,8 @@
>
> depends_lib     port:expat
>
> +use_autoreconf  yes
> +
> configure.args  --disable-doxygen-docs \
>                 --disable-xml-docs \
>                 --without-x \

I don't understand this change -- it looks like you're justing moving  
"use_autoreconf yes" to earlier in the portfile, which shouldn't have  
any measurable effect on how the port functions. How does this fix  
build dependencies?



_______________________________________________
macports-dev mailing list
macports-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

[Joshua Root-8]

On 2009-10-26 14:31, Ryan Schmidt wrote:
> I don't understand this change -- it looks like you're justing moving
> "use_autoreconf yes" to earlier in the portfile, which shouldn't have
> any measurable effect on how the port functions. How does this fix build
> dependencies?

Later, not earlier. It's after the depends_build now. Changing that to a
depends_build-append would also have worked.

- Josh
_______________________________________________
macports-dev mailing list
macports-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

[Ryan Schmidt-24]

On Oct 25, 2009, at 22:50, Joshua Root wrote:

> On 2009-10-26 14:31, Ryan Schmidt wrote:
>> I don't understand this change -- it looks like you're justing moving
>> "use_autoreconf yes" to earlier in the portfile, which shouldn't have
>> any measurable effect on how the port functions. How does this fix  
>> build
>> dependencies?
>
> Later, not earlier. It's after the depends_build now. Changing that  
> to a
> depends_build-append would also have worked.

Oh! I totally didn't realize things like use_autoreconf were processed  
in the order in which they appeared in the portfile. Sometimes it's  
hard to know, with all the delayed variable expansion and phases and  
variants and things we have going on.



_______________________________________________
macports-dev mailing list
macports-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev