Re: [60303] trunk/dports/sysutils/memcached/Portfile

View: New views
3 Messages — Rating Filter:   Alert me  

Parent Message unknown Re: [60303] trunk/dports/sysutils/memcached/Portfile

by Ryan Schmidt-24 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On Nov 8, 2009, at 15:03, brett@... wrote:

> Revision: 60303
>          http://trac.macports.org/changeset/60303
> Author:   brett@...
> Date:     2009-11-08 13:03:31 -0800 (Sun, 08 Nov 2009)
> Log Message:
> -----------
> add umem variant to memcached


> +variant umem description {enable libumem support} {
> +    depends_lib-append     port:umem
> +}

The variant should do more than just add a dependency: it should also  
add a configure arg or environment variable or something that tells  
memcached that it's ok to use umem -- and you may have to add  
something to the default port build so that it will *not* use umem,  
even if umem is installed, unless the umem variant is selected.



_______________________________________________
macports-dev mailing list
macports-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Re: [60303] trunk/dports/sysutils/memcached/Portfile

by Brett Eisenberg :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I don't actually agree with that, nor does it make sense to needlessly  
patch memcached's autoconf configuration to support what you're  
proposing.

Given that building with umem hooks provides no material change to the  
application unless the runtime environment is modified, there's simply  
no merit to the proposed solution.

best,
Brett

On Nov 8, 2009, at 4:52 PM, Ryan Schmidt wrote:

>
> On Nov 8, 2009, at 15:03, brett@... wrote:
>
>> Revision: 60303
>>         http://trac.macports.org/changeset/60303
>> Author:   brett@...
>> Date:     2009-11-08 13:03:31 -0800 (Sun, 08 Nov 2009)
>> Log Message:
>> -----------
>> add umem variant to memcached
>
>
>> +variant umem description {enable libumem support} {
>> +    depends_lib-append     port:umem
>> +}
>
> The variant should do more than just add a dependency: it should  
> also add a configure arg or environment variable or something that  
> tells memcached that it's ok to use umem -- and you may have to add  
> something to the default port build so that it will *not* use umem,  
> even if umem is installed, unless the umem variant is selected.
>
>
>
>
> !DSPAM:1000,4af767bc91021468!
>

_______________________________________________
macports-dev mailing list
macports-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Re: [60303] trunk/dports/sysutils/memcached/Portfile

by Blair Zajac :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

You actually do have to do this.  The reason is if you uninstall umem then the
memcached port will fail.  MacPorts must warn the user if they are uninstalling
a port if it'll break any other ports:

bash-3.2# memcached -v -u root
^CSIGINT handled.
bash-3.2# port -v uninstall umem
--->  Deactivating umem @1.0.1_0
--->  Uninstalling umem @1.0.1_0
--->  Uninstall is removing umem from the port registry.
bash-3.2# memcached -v -u root
dyld: Library not loaded: /opt/local/lib/libumem.0.dylib
   Referenced from: /opt/local/bin/memcached
   Reason: image not found
Trace/BPT trap

The standard in MacPorts is if you can pick up a dependency upon configuration
time then you either need to specify a dependency upon it in the Portfile or not
list it as a dependency and then tell configure not to find it.

In your case, I think adding a default ac_cv_search_umem_cache_create=no
environmental variable should be sufficient to disable umem.  You also may need
to do this for ac_cv_search_gethugepagesizes=no

Regards,
Blair

Brett Eisenberg wrote:

> I don't actually agree with that, nor does it make sense to needlessly
> patch memcached's autoconf configuration to support what you're proposing.
>
> Given that building with umem hooks provides no material change to the
> application unless the runtime environment is modified, there's simply
> no merit to the proposed solution.
>
> best,
> Brett
>
> On Nov 8, 2009, at 4:52 PM, Ryan Schmidt wrote:
>
>>
>> On Nov 8, 2009, at 15:03, brett@... wrote:
>>
>>> Revision: 60303
>>>         http://trac.macports.org/changeset/60303
>>> Author:   brett@...
>>> Date:     2009-11-08 13:03:31 -0800 (Sun, 08 Nov 2009)
>>> Log Message:
>>> -----------
>>> add umem variant to memcached
>>
>>
>>> +variant umem description {enable libumem support} {
>>> +    depends_lib-append     port:umem
>>> +}
>>
>> The variant should do more than just add a dependency: it should also
>> add a configure arg or environment variable or something that tells
>> memcached that it's ok to use umem -- and you may have to add
>> something to the default port build so that it will *not* use umem,
>> even if umem is installed, unless the umem variant is selected.
>>
>>
>>
>>
>> !DSPAM:1000,4af767bc91021468!
>>
>
> _______________________________________________
> macports-dev mailing list
> macports-dev@...
> http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
>


--
Blair Zajac, Ph.D.
CTO, OrcaWare Technologies
<blair@...>
Subversion training, consulting and support
http://www.orcaware.com/svn/
_______________________________________________
macports-dev mailing list
macports-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev