On Wed, Aug 12, 2009 at 3:05 AM,
renderguy<
ltatkinson@...> wrote:
> @@ -698,11 +698,11 @@ extern "C" PtDspyError DspyImageOpen(PtDspyImageHandle * image,
> pImage->m_compression = COMPRESSION_PACKBITS;
> }
>
> - // Check if the requested compression format is available in libtiff, if not resort to "none"
> + // Check if the requested compression format is available in libtiff, if not resort to "lzw"
> if(!TIFFIsCODECConfigured(pImage->m_compression))
> {
> /* Aqsis::log() << "Compression type " << compression << " not supported by the libtiff implementation" << std::endl; */
> - pImage->m_compression = COMPRESSION_NONE;
> + pImage->m_compression = COMPRESSION_LZW;
> }
I'm not sure that making LZW the default fallback is a good idea.
Unless you can point me at some documentation or other evidence that
says LZW compression is *always* built into libtiff, please change the
fallback back to COMPRESSION_NONE.
Remember, it's only a fallback, so will only execute in the odd
instance when an error has already occurred; therefore the fallback
should be robust!
Other than that niggle, I think the idea of making the compression
COMPRESSION_LZW by default is good.
~Chris.
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.
http://p.sf.net/sfu/bobj-july_______________________________________________
Aqsis-development mailing list
Aqsis-development@...
https://lists.sourceforge.net/lists/listinfo/aqsis-development
