On Mon, Sep 14, 2009 at 9:26 AM, Paul Gregory
<
pgregory@...> wrote:
[...]
> Fix bug #2853239.
>
> * Apply Chris Foster's patch to reintroduce dof offset shuffling.
> * Switch the jittering based on the Hider "jitter" option, as
> for other jittering.
>
> @@ -334,6 +333,33 @@ void CqImagePixel::Combine( enum EqDepthFilter depthfilter, CqColor zThreshold )
>
> void CqImagePixel::setSamples(IqSampler* sampler, CqVector2D& offset)
> {
> + static CqRandom rnd(123);
> + TqInt nSamps = numSamples();
> +
> + for(TqInt i = 0; i < nSamps; ++i)
> + m_DofOffsetIndices[i] = i;
> +
> + bool jitter = true;
> +
> + const TqInt* jitterOption;
> + if((jitterOption = QGetRenderContext()->poptCurrent()->
> + GetIntegerOption("Hider", "jitter")) != NULL && jitterOption[0] == 0)
> + jitter = false;
I reckon it'd be better to pass the jitter in as an argument to setSamples.
Reasoning:
1) It restricts the use of global state (ie, QGetRenderContext())
2) Option lookup isn't all that cheap, so avoiding doing it once per
pixel is a good thing.
~Chris
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.
http://p.sf.net/sfu/bobj-july_______________________________________________
Aqsis-development mailing list
Aqsis-development@...
https://lists.sourceforge.net/lists/listinfo/aqsis-development
