|
»
»
« Return to Thread: [G3/Patch] More flexibility with themes
Re: [G3/Patch] More flexibility with themes
by Bharat Mediratta
::
Rate this Message:
Romain LE DISEZ wrote:
> I didn't found a link to create an account in Trac so I post here...
If you create an account on sourceforge.net, you can log in and use that
account to create Trac tickets. But it's fine to have this discussion here.
> when I tried to create a theme to customise the uploader interface, I
> found that it was not possible to override the files in core/views/.
> It's a problem for a good themability.
>
> Currently G3 looks for views in :
> - core/views/
> - theme/<active theme>/views/
> - module/<module>/views/
>
> The first file found is selected. The first directory can't be changed,
> it will always be core/views/.
Yes, that is a serious problem. The order I would prefer to see is:
1) theme/ACTIVE_THEME/views
2) modules/MODULE_1/views
3) modules/MODULE_2/views
...
N) core/views
This allows any module to override the core, and the theme to override
everything. This doesn't solve the problem of conflicting modules
trying to override each other, but I'll save that problem for another day.
The problem as I see it is that Kohana::include_paths() puts APPPATH
first. I don't understand why it forces that requirement, but since
it's a private member of a final class, they don't make it easy for us
to get around that issue.
So, I changed the Kohana code in r20909 and filed this ticket:
http://dev.kohanaphp.com/issues/1695
Once you svn up, you should be able to override any view, controller,
library or helper in your theme. Let me know if this doesn't fully
solve your problem.
-Bharat
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com
__[ g a l l e r y - d e v e l ]_________________________
[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]
> I didn't found a link to create an account in Trac so I post here...
If you create an account on sourceforge.net, you can log in and use that
account to create Trac tickets. But it's fine to have this discussion here.
> when I tried to create a theme to customise the uploader interface, I
> found that it was not possible to override the files in core/views/.
> It's a problem for a good themability.
>
> Currently G3 looks for views in :
> - core/views/
> - theme/<active theme>/views/
> - module/<module>/views/
>
> The first file found is selected. The first directory can't be changed,
> it will always be core/views/.
Yes, that is a serious problem. The order I would prefer to see is:
1) theme/ACTIVE_THEME/views
2) modules/MODULE_1/views
3) modules/MODULE_2/views
...
N) core/views
This allows any module to override the core, and the theme to override
everything. This doesn't solve the problem of conflicting modules
trying to override each other, but I'll save that problem for another day.
The problem as I see it is that Kohana::include_paths() puts APPPATH
first. I don't understand why it forces that requirement, but since
it's a private member of a final class, they don't make it easy for us
to get around that issue.
So, I changed the Kohana code in r20909 and filed this ticket:
http://dev.kohanaphp.com/issues/1695
Once you svn up, you should be able to override any view, controller,
library or helper in your theme. Let me know if this doesn't fully
solve your problem.
-Bharat
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com
__[ g a l l e r y - d e v e l ]_________________________
[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]
« Return to Thread: [G3/Patch] More flexibility with themes
| Free embeddable forum powered by Nabble | Forum Help |
