« Return to Thread: AND search finished, request for review

Re: [Gallery-core] AND search finished, request for review

by Alan Harder :: Rate this Message:

hi-
i did a quick first-pass review.
looks pretty good, though I didn't examine all the regexp and
array juggling in the SearchUtilities class in any detail.

http://tools.gallery2.org/pastebin/672

please post a new diff after going over this, and we can get
this into svn.
bharat, any comment on the SearchUtilities::doAndSearch
function? it's currently hardcoded to true.

- Alan

Georg Rehfeld wrote:

> Hi all,
>
> - updated all DB tests to not expect case insensivity searches any more
> - added some more tests
>
>> Please find the patch as text, compressed archive and zipped at:
>>
>> http://georg-rehfeld.de/test/and_search_patch.txt
>> http://georg-rehfeld.de/test/and_search_patch.tgz
>> http://georg-rehfeld.de/test/and_search_patch.zip
>
> regards, Georg

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
__[ g a l l e r y - d e v e l ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]

« Return to Thread: AND search finished, request for review