Re: [GitHub] valo sent you a message

View: New views
1 Messages — Rating Filter:   Alert me  

Parent Message unknown Re: [GitHub] valo sent you a message

by C. K. Ponnappa :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hey Valentin,

Your patch looks good, but I have 7 failing tests after pulling; I just
wanted to confirm if this is happening for you (looks like a missing
cattr_reader :output_limit in Configuration)?
We can merge it in once the others have approved the change.

Thanks,
Sidu.
http://blog.sidu.in
http://twitter.com/ponnappa

GitHub wrote:

> valo wants you to pull from valo/cruisecontrol.rb at master
>
> Body: Hi there!
>
> I made a patch to make the output limit of 100KB configurable. It is a global config option on the Configuration class. If you want and like the patch you can pull it.
>
> Please tell me if the fix is not good enough.
>
> Thanks,
>   Valentin
>
> View repository: http://github.com/valo/cruisecontrol.rb/tree/master
>
>  
_______________________________________________
Cruisecontrolrb-developers mailing list
Cruisecontrolrb-developers@...
http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers