Re: [LTP] [PATCH]pthread_cond_broadcast/1-2.c

> Case pthread_cond_broadcast/1-2.c trys to create as many threads and
> processes as possible which will wait on a condition variable.
>
> Unfortunately,if some thread or child process waits overtime(180s)
> since maybe memory is not enough or whatever, it will call FAILED() and
> exit without unlocking a global mutex.
>
> Above-mentioned matter leads to a deadlock when parent process trys to
> pthread_mutex_lock the global mutex,and obviously status FAILED cannot
> be reahed by parent process.
>
> This patch fixes the deadlock problem.
>

> Signed-off-by: DAN LI <li.dan@...>
> ---
>  .../interfaces/pthread_cond_broadcast/1-2.c        |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_cond_broadcast/1-2.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_cond_broadcast/1-2.c
> index af826ba..f6ad9df 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_cond_broadcast/1-2.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_cond_broadcast/1-2.c
> @@ -189,9 +189,13 @@ static void *child(void *arg)
>   timed, td->predicate, ret);
>   #endif
>   } while ((ret == 0) && (td->predicate == 0));
> - if (ret == ETIMEDOUT)
> + if (ret == ETIMEDOUT) {
> + ret = pthread_mutex_unlock(&td->mtx);
> + if (ret != 0)
> + UNRESOLVED(ret, "Failed to unlock the mutex.");
>   FAILED("Timeout occured. This means a cond signal was lost -- "
>         "or parent died");
> + }
>   if (ret != 0)
>   UNRESOLVED(ret, "Failed to wait for the cond");
>  
> -- 1.7.7.2
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@...
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>