Martin Kersten wrote:
> Update of /cvsroot/monetdb/MonetDB5/src/modules/mal
> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv8920
>
> Modified Files:
> Tag: Nov2009
> mal_io.mx mal_mapi.mx recycle.mx
> Log Message:
> A few Coverity changes.
>
>
> Index: mal_mapi.mx
> ===================================================================
> RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/mal_mapi.mx,v
> retrieving revision 1.37.2.6
> retrieving revision 1.37.2.7
> diff -u -d -r1.37.2.6 -r1.37.2.7
> --- mal_mapi.mx 3 Nov 2009 20:15:01 -0000 1.37.2.6
> +++ mal_mapi.mx 6 Nov 2009 15:17:13 -0000 1.37.2.7
> @@ -402,8 +402,8 @@
> char *buf = (char *) GDKmalloc(BLOCK + 1);
> char *challenge;
> char *algos;
> - stream *fdin = block_stream(in);
> - stream *fdout = block_stream(out);
> + stream *fdin;
> + stream *fdout;
> bstream *bs;
> int len = 0;
>
> @@ -411,10 +411,12 @@
> GDKsyserror("SERVERlisten:"MAL_MALLOC_FAIL);
> return;
> }
> + fdin = block_stream(in);
> if (!fdin || !fdout) {
> GDKsyserror("SERVERlisten:fdin or fdout problems");
> return;
> }
> + fdout = block_stream(out);
>
> assert(buf);
>
>
You're assigning to fdout *after* checking whether it is NULL.
--
Sjoerd Mullender
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.
http://p.sf.net/sfu/bobj-july_______________________________________________
Monetdb-developers mailing list
Monetdb-developers@...
https://lists.sourceforge.net/lists/listinfo/monetdb-developers
signature.asc (379 bytes) 