« Return to Thread: [PATCH] added point-sprite test.

Re: [PATCH] added point-sprite test.

by Nicolai Hähnle :: Rate this Message:

Reply to Author | View in Thread

Am Friday 10 July 2009 01:27:22 schrieb Ian Romanick:

> Ben Holmes wrote:
> > + if (GLEW_VERSION_2_0)
> > + glPointParameteri(GL_POINT_SPRITE_COORD_ORIGIN, GL_UPPER_LEFT);
> > +
> > + glBegin(GL_POINTS);
> > + glVertex2f(175.0f,125.0f);
> > + glEnd();
> > +
> > + GLfloat black[3] = {0.0, 0.0, 0.0};
> > + GLboolean pass = piglit_probe_pixel_rgb(200, 120, black);
>
> I'll let someone else comment here to be sure.  I believe that we're not
> counting on C99 (or C++) in piglit, so variable declarations cannot be
> mixed with code.  Do we care?

Actually, glean is written in C++, so piglit has always depended on C++. The
fact that I wrote all the initial additional tests in plain C is just a
historical accident caused by the fact that most of them were converted Mesa
progs, and those are all written in plain C. I certainly wasn't trying to
avoid C++.

I don't think there's ever been a discussion on C99. My personal opinion is to
go ahead and just use its features. It's been 10 years after all and should be
well supported on all interesting platforms by now.

cu,
Nicolai

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

 « Return to Thread: [PATCH] added point-sprite test.