« Return to Thread: [PATCH] Fix PR34130, extract_muldiv broken

Re: [PATCH] Fix PR34130, extract_muldiv broken

by Richard Guenther-2 :: Rate this Message:

Reply to Author | View in Thread

On Nov 22, 2007 2:18 PM, Matthias Klose <doko@...> wrote:

> Richard Guenther writes:
> >
> > It folds -C*ABS<n> to ABS<-C*n>.  Anyone else thinks this function needs
> > to go? :/
> >
> > Bootstrapped & tested on x86_64-unknown-linux-gnu, applied to mainline.
> >
> > Richard.
> >
> > 2007-11-17  Richard Guenther  <rguenther@...>
> >
> >       PR middle-end/34130
> >       * fold-const.c (extract_muldiv_1): Do not move negative
> >       constants inside ABS_EXPR.
> >
> >       * gcc.c-torture/execute/pr34130.c: New testcase.
>
> The same patch applies to the 4.2 branch as well. checked on
> sparc-linux-gnu without regressions. Ok to checkin?
>
> Currently running the testsuite on the 4.1 branch. Ok to check in on
> this branch, if the testsuite succeeds without regressions?

Ok for both.

Thanks,
Richard.

 « Return to Thread: [PATCH] Fix PR34130, extract_muldiv broken