« Return to Thread: [PATCH] Fixed conkeror-spawn-helper.c for FreeBSD.

Re: [PATCH] Fixed conkeror-spawn-helper.c for FreeBSD.

by burin080 :: Rate this Message:

Reply to Author | View in Thread

Re: Re: [Conkeror] [PATCH] Fixed conkeror-spawn-helper.c for FreeBSD.

> Thanks for the fix.  I'm curious: what error do you get without this
> patch?

---
conkeror-spawn-helper.c: In function 'main':
conkeror-spawn-helper.c:234: error: storage size of 'file_lim' isn't known
conkeror-spawn-helper.c:236: error: 'RLIMIT_NOFILE' undeclared (first use in this function)
conkeror-spawn-helper.c:236: error: (Each undeclared identifier is reported only once
conkeror-spawn-helper.c:236: error: for each function it appears in.)
*** Error code 1
---

The header file <sys/resource.h> defines rlimit related structs, functions and constants. It's not being #included on FreeBSD.

Digging deeper, I have found the reason for this:

On Slackware:
$ grep -n '#include <sys/resource.h>' /usr/include/sys/wait.h
32:#include <sys/resource.h>

On FreeBSD:
$ grep -n '#include <sys/resource.h>' /usr/include/sys/wait.h
(nothing)

My patch #includes the header file manually instead of relying on <sys/wait.h> to do it.

Cheers,

Ricardo Buring


_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

 « Return to Thread: [PATCH] Fixed conkeror-spawn-helper.c for FreeBSD.