Finally, here it an all in one patch, review from your comments, for the MouseClick Event and the standard context menu for the MaskedTextBox.
2009/10/28 Petit Eric
<surfzoid@...>
oki , weired, but i will try to do it;
Effort are duplicate, your comment are really nice and right, i need to took them for next patch, but most of them are to delete some extra data in the patch, after you will review a second time etc :-)
2009/10/28 Carlos Alberto Cortez
<calberto.cortez@...>
No dude, you need to do it directly you. That's the usual process all the contributors do: they send a patch, then the maintainer suggests some changes, then the contributor applies those changes.
Carlos.
2009/10/27 Petit Eric
<surfzoid@...>
Hum, could you directly modify it ! ?2009/10/27 Carlos Alberto Cortez
<calberto.cortez@...>
Comments below:
- protected override void OnMouseUp (MouseEventArgs mevent)
- {
- base.OnMouseUp (mevent);
- }
+ protected override void OnMouseUp(MouseEventArgs mevent)
+ {
+ base.OnMouseUp(mevent);
+ }
+ protected override void OnMouseClick(MouseEventArgs mevent)
+ {
+ base.OnMouseClick(mevent);
+ }
+
Be careful to *not* send changes including style modifications.
+ protected override void OnMouseClick(MouseEventArgs mevent)
+ {
+ if ((mevent.Button & MouseButtons.Left) != 0)
+ {
+ is_pressed = true;
+ Invalidate();
+ }
+
+ base.OnMouseClick(mevent);
+ }
+
In .Net ButtonBase is not overriding this method, so we can't do that. Moreover, we don't need to do this.
- if (!ValidationFailed)
- OnClick (EventArgs.Empty);
+ if (!ValidationFailed)
+ {
+ OnClick(EventArgs.Empty);
+ OnMouseClick(mevent);
+ }
This is fine, and this is the only bit we need to fix the issue. Just follow the coding guidelines: http://www.mono-project.com/Guidelines
Re-send me the patch when it's done ;-)
Carlos.
Hey,I will review the patch later, but there's no need to send the patch to the mono develop list, since the change is related to windows.forms. Also, the mono-patches list is used to receive/catch the changes in svn. Next time send the patch to the winforms list, please.
Carlos.
2009/10/27 Petit Eric
<surfzoid@...>
Hi
Mouse Click Event was missing in SWF implementation, here it is a patch to fix that 
it is released under MIT/X11 or what ever you want.
Carlos, if you apply the patch, could you think about my "coding for fun" and add my nickname in the log ?
--
Cordially.
Small Eric Quotations of the days:
---------------------------------------------------------------------------
I have no special talents. I am only passionately curious
--
Cordially.
Small Eric Quotations of the days:
---------------------------------------------------------------------------
I have no special talents. I am only passionately curious
--
Cordially.
Small Eric Quotations of the days:
---------------------------------------------------------------------------
I have no special talents. I am only passionately curious
--
Cordially.
Small Eric Quotations of the days:
---------------------------------------------------------------------------
I have no special talents. I am only passionately curious
Sent from Paris, France
_______________________________________________
Mono-winforms-list maillist -
Mono-winforms-list@...
http://lists.ximian.com/mailman/listinfo/mono-winforms-list
MouseClickEvAndCtxMenu4MaskedTxtBox.patch (5K) 
