Re: [PATCH] Re: 1.7 winbase.h (ilockcmpexch) compile error

[Dave Korn-6]

Christopher Faylor wrote:

> On Tue, Jul 07, 2009 at 10:55:13PM +0100, Dave Korn wrote:
>> Christopher Faylor wrote:
>>> On Tue, Jul 07, 2009 at 10:21:33PM +0100, Dave Korn wrote:
>>>> winsup/cygwin/ChangeLog:
>>>>
>>>> * winbase.h (ilockexch):  Avoid making 'ret' volatile.
>>>> (ilockcmpexch):  Likewise.
>>>>
>>>>  Ok?
>>> Yes.  Thanks.
>>  Applied, and I even caught the changelog formatting in time!
>
> I think I may have to turn in my Anal Whitespace Enforcer badge.
>
> cgf

<weeblandbob> That's no *white* space .... </weeblandbob>

    cheers,
      DaveK

[Christopher Faylor-8]

On Tue, Jul 07, 2009 at 11:15:46PM +0100, Dave Korn wrote:

>Christopher Faylor wrote:
>> On Tue, Jul 07, 2009 at 10:55:13PM +0100, Dave Korn wrote:
>>> Christopher Faylor wrote:
>>>> On Tue, Jul 07, 2009 at 10:21:33PM +0100, Dave Korn wrote:
>>>>> winsup/cygwin/ChangeLog:
>>>>>
>>>>> * winbase.h (ilockexch):  Avoid making 'ret' volatile.
>>>>> (ilockcmpexch):  Likewise.
>>>>>
>>>>>  Ok?
>>>> Yes.  Thanks.
>>>  Applied, and I even caught the changelog formatting in time!
>>
>> I think I may have to turn in my Anal Whitespace Enforcer badge.
>
><weeblandbob> That's no *white* space .... </weeblandbob>

Er, not really.  It's just making sure whitespace is correct.  For
instance, if you had no spaces after the colon, then it would have been
my job to tell you.

But, whitespace enforcement is a young person's game.  I'm getting too
old for this ...

cgf

[Dave Korn-6]

Christopher Faylor wrote:

> On Tue, Jul 07, 2009 at 11:15:46PM +0100, Dave Korn wrote:
>> Christopher Faylor wrote:
>>> On Tue, Jul 07, 2009 at 10:55:13PM +0100, Dave Korn wrote:
>>>> Christopher Faylor wrote:
>>>>> On Tue, Jul 07, 2009 at 10:21:33PM +0100, Dave Korn wrote:
>>>>>> winsup/cygwin/ChangeLog:
>>>>>>
>>>>>> * winbase.h (ilockexch):  Avoid making 'ret' volatile.
>>>>>> (ilockcmpexch):  Likewise.
>>>>>>
>>>>>>  Ok?
>>>>> Yes.  Thanks.
>>>>  Applied, and I even caught the changelog formatting in time!
>>> I think I may have to turn in my Anal Whitespace Enforcer badge.
>> <weeblandbob> That's no *white* space .... </weeblandbob>
>
> Er, not really.  It's just making sure whitespace is correct.  For
> instance, if you had no spaces after the colon, then it would have been
> my job to tell you.

<weeblandbob> The space after my colon is brown! </weeblandbob>

    cheers,
      DaveK