« Return to Thread: [PATCH] Add TAGS to .gitignore

Re: [PATCH] Show errors from completers, etc.

by Jeremy Maitin-Shepard-2 :: Rate this Message:

Reply to Author | View in Thread

David Kettler <kettler@...> writes:

> If an interactive_error was thrown in a minibuffer completer function,
> the error was previously lost.  This commit ensures that the error
> message is displayed in the minibuffer.

> The problem arises because direct uses of co_call do not propagate
> exceptions.  The same fix is applied to the two other places in
> conkeror that could lose an error message.  One other place, in
> download_helper.handle_show, already handled the problem in the same
> way.

> An alternative fix would be to provide an interactive_co_call to do
> the wrappering.

I'll take a closer look at this patch later today when I have more time.
In some with regard to completions I had specifically intended that an
exception being thrown would just result in no completions being
generated.

--
Jeremy Maitin-Shepard
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

 « Return to Thread: [PATCH] Add TAGS to .gitignore