Re: [PATCH] Support for XAiOX iTrackU GPS Logger

Hi Robert,
 
Thank you very much for your comments. I found some time to continue work on
the itracku module.

Here are the changes:

* Comments added for deg_min_to_deg() and its twin.
* endianness now handled correctly in

        static waypoint*
        to_waypoint(itracku_data_item* d)

        static void
        to_data_item(const waypoint* wp, itracku_data_item* d)

* automatic port detection is now enabled by using "auto:" as input file
* RT positioning fixed.
* two entries in vecs, one for files and one for device:

        itracku               XAiOX iTrackU Logger
          backup                Appends the input to a backup file
          new                   Only waypoints that are not the backup file
        itracku-bin           XAiOX iTrackU Logger Binary File Format
          backup                Appends the input to a backup file
          new                   Only waypoints that are not the backup file

I tried to use routines from nmea.c for the real time output, but function
gprmc_parse is entangled with the static variables of nmea.c and cannot be
used without major refactoring. Since I do not want to break something in
nmea.c, I would like to keep the nmea parsing in itracku.c for this time. I
added a TODO comment there, so I can refactor later.

Note: the diff also fixes a typo in
/cvsroot/gpsbabel/gpsbabel/xmldoc/formats/navilink.xml,v

Best regards,

Andreas


________________________________

From: robertlipe@... [mailto:robertlipe@...] On Behalf Of Robert
Lipe
Sent: Montag, 6. Oktober 2008 19:20
To: Andreas Grimme; Andy Armstrong
Cc: gpsbabel-code@...
Subject: Re: [Gpsbabel-code] [PATCH] Support for XAiOX iTrackU GPS Logger


Hi.


On Sun, Oct 5, 2008 at 1:13 AM, Andreas Grimme <andreas.grimme@...>
wrote:


        Hello,
       
        here is a patch to support the
       
        XAiOX iTrackU BLUETOOTH GPS-RECEIVER SiRF III Logger
        http://www.xaiox.com/itracku_sirf3.htm
       


Thanx for the patch.  Skimming over this, it seems pretty reasonable.  I do
have
a few questions/comments on the code.

Please include a comment for deg_min_to_deg() and its twin.  It's not
obvious at first blush what they do and those kinds of functions tend to
have to be debugged by people in different hemispheres. :-)

I don't see endianness handling in here.  Big endian systems are out of
vogue these days and we don't have a large number of Sparc users, but we do
still get Power PC Mac users in numbers.  (Yes, I know this is a pain to
develop/debug if you don't have such a system.)  I think you can get away
with most of what you need to "fix" in to_waypoint() and its inverse.

I like the idea of "auto", but I don't think it's right to have it here.
I'd be inclined to move that logic into gbser_open - special case the
"auto:" device and start the search there as it'd then be available to all
the formats using devices.   The current logic is probably too simplistic -
it wouldn't detect bluetooth on a Mac or even many serial devices - but we
could iterate on that over time.   Also, there's the reality that some
serial devices will hang on an open and some devices will have weird
interactions if you open them.   Andy, how do you feel about that?


What's the deal with RT positioning?  itracku_read() aborts on it, yet you
have functions to do it.

Rather than duplicating code from nmea.c, I'd rather just make them public.
It's not like NMEA is uncommon...In fact, if itracku_rt_init() and friends
could just send the init/deinit strings and then call over to the NMEA code,
that would be even better.

I'd prefer two entries in vecs, one for files and one for device.   This
lets the various GUIs present a "file open" for the files and a "choose a
serial port" UI for direct device comms.

And finally, the most pressing question, how does one pronounce "XAiox"? :-)
 
We can work through these things and commit it.  I think we're pretty close.




        Is there anybody out there who also has this logger? Then I would be
happy
       


This post is the first time I've heard the word "Xaiox" and it's the first
time I see it in my archives...but that doesn't mean that you're the only
one with it.




        - copy itracku.dat to /reference/itracku.dat (I could not figure out
how to
        make cvs diff work for binary files)
       


You can't.  It's one more way that CVS is retarded.


Thanx!
RJL



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code@...
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code