Re: [PATCH] replacing -Wextra with -W

> On Thursday 05 November 2009 11:59:13 Cyril Hrubis wrote:
>> > > Lately gcc developers introduced -Wextra flag that does the same as -W
>> > > but is more descriptive. According to this using -W flag should be safe
>> > > (as gcc is backward compatlible) but using -Wextra is limited to newer
>> > > gcc releases.
>> > >
>> > > Attached patch replaces all -Wextra occurences with -W and thus fixes
>> > > compliation failures with older gcc (mine was gcc-3.3.3 on sles).
>> >
>> > it'd be better if we had configure tests for -W flags, but that would
>> > take a bit more effort, and i dont think it should preclude applying your
>> > patch. however, please make this change first:
>> >  - integrated Makefiles shouldnt be setting flags at all, so just delete
>> > the whole line in
>> > testcases/kernel/controllers/{cpuctl,cgroup}_fj/Makefile
>>
>> Patch that should be applied over the previous one attached.
>
> thanks, ive merged the two and added to the tree.  hopefully i didnt screw
> anything up in the (simple) process ;).